BRNSystems/ServerShop
BRNSystems/ServerShop
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Decimals #2

New Issue
Open
opened 2024-11-03 19:52:42 +01:00 by GinkAbu · 17 comments
GinkAbu commented 2024-11-03 19:52:42 +01:00
Copy Link

We currently are using you ServerShop and it's perfect, however is it possible to implement decimals for prices e.g 1.00? As I'm adding all the prices from my datapack however they all include decimals, and I'm currently circumventing this issue by using a scale factor of 100 e.g 1.23 => 123.

Thanks for the ServerShop!!!

We currently are using you ServerShop and it's perfect, however is it possible to implement decimals for prices e.g 1.00? As I'm adding all the prices from my datapack however they all include decimals, and I'm currently circumventing this issue by using a scale factor of 100 e.g 1.23 => 123. Thanks for the ServerShop!!!
BRNSystems commented 2024-11-03 19:53:50 +01:00
Owner
Copy Link

I intended to use the scale factor.
Is it really needed?

I intended to use the scale factor. Is it really needed?
BRNSystems commented 2024-11-03 19:54:02 +01:00
Owner
Copy Link

Technically it is possible

Technically it is possible
BRNSystems commented 2024-11-03 19:55:03 +01:00
Owner
Copy Link

Or I can just divide it by 100 when displaying to keep it fixed decimal point

Or I can just divide it by 100 when displaying to keep it fixed decimal point
GinkAbu commented 2024-11-03 19:57:56 +01:00
Author
Copy Link

Yeah even on my datapack I started off using whole number then just dividing it by 100 when displaying which made things way easier. Another method I tried was storing the whole number as price1 and the decimals as price2 but that was way more complex.

Yeah even on my datapack I started off using whole number then just dividing it by 100 when displaying which made things way easier. Another method I tried was storing the whole number as price1 and the decimals as price2 but that was way more complex.
BRNSystems commented 2024-11-03 19:58:19 +01:00
Owner
Copy Link

I could implement it as true floating point if I wanted to

I could implement it as true floating point if I wanted to
GinkAbu commented 2024-11-03 20:00:42 +01:00
Author
Copy Link

Ow you could is it that not complex? I've had many issues trying to store a float value on scoreboard since it only handles integers.

Ow you could is it that not complex? I've had many issues trying to store a float value on scoreboard since it only handles integers.
BRNSystems commented 2024-11-03 20:01:14 +01:00
Owner
Copy Link

This is a java mod. I have access to normal code. It would not be that complex actually

This is a java mod. I have access to normal code. It would not be that complex actually
GinkAbu commented 2024-11-03 20:05:51 +01:00
Author
Copy Link

Ow would you not have to make major changes tho? Also how do you handle the price.dat info I'm currently adding this one by one, I'm trying to write a python code to convert snbt to nbt but having to errors as my datapack uses json.

Ow would you not have to make major changes tho? Also how do you handle the price.dat info I'm currently adding this one by one, I'm trying to write a python code to convert snbt to nbt but having to errors as my datapack uses json.
GinkAbu commented 2024-11-03 20:10:48 +01:00
Author
Copy Link

I've just realised how much quicker /shop edit XD

I've just realised how much quicker /shop edit XD
BRNSystems commented 2024-11-03 20:11:21 +01:00
Owner
Copy Link

This project has a CSV import as well. It can't import item metadata though.
I included the csv price thing.
And for the dat, it is a normal NBT file. Try it with a minecraft NBT editor.
There surely is a python option.

This project has a CSV import as well. It can't import item metadata though. I included the csv price thing. And for the dat, it is a normal NBT file. Try it with a minecraft NBT editor. There surely is a python option.
prices.csv
51 KiB
❤️ 1
BRNSystems commented 2024-11-03 20:12:16 +01:00
Owner
Copy Link

Everything about price storage is here: https://git.brn.systems/BRNSystems/ServerShop/src/branch/main/src/main/java/systems/brn/servershop/lib/storages/PriceStorage.java

Feel free to explore the code.

Everything about price storage is here: [https://git.brn.systems/BRNSystems/ServerShop/src/branch/main/src/main/java/systems/brn/servershop/lib/storages/PriceStorage.java](https://git.brn.systems/BRNSystems/ServerShop/src/branch/main/src/main/java/systems/brn/servershop/lib/storages/PriceStorage.java) Feel free to explore the code.
❤️ 1
GinkAbu commented 2024-11-03 20:18:23 +01:00
Author
Copy Link

I began editing the prices file, should I continue to use the scale factor method of wait until a decimals update?

Thanks.

I began editing the prices file, should I continue to use the scale factor method of wait until a decimals update? Thanks.
BRNSystems commented 2024-11-03 20:43:18 +01:00
Owner
Copy Link

Could you test this build for me?
https://modrinth.com/mod/servershop/version/ZvaH9AeR

Could you test this build for me? https://modrinth.com/mod/servershop/version/ZvaH9AeR
GinkAbu commented 2024-11-03 20:49:02 +01:00
Author
Copy Link

sure

sure
BRNSystems commented 2024-11-03 20:53:19 +01:00
Owner
Copy Link

Is it working?

Is it working?
GinkAbu commented 2024-11-03 21:06:41 +01:00
Author
Copy Link

Works perfectly!!!

Works perfectly!!!
GinkAbu commented 2024-11-03 21:12:03 +01:00
Author
Copy Link

There seems to be an error when trying /balance list, I get incorrect argument as a player and the second error as admin.

image.png image.png
There seems to be an error when trying /balance list, I get incorrect argument as a player and the second error as admin. <img width="718" alt="image.png" src="attachments/eb94dda6-3cf8-49d4-a678-29ee464d53ce"> <img width="722" alt="image.png" src="attachments/971cd8ff-6434-4a0d-9b99-43fc8d9cb1aa">
image.png
275 KiB
image.png
145 KiB
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BRNSystems/ServerShop#2
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?