From 30c077b5d0386233d3285803f5ef7cd920d3f3a4 Mon Sep 17 00:00:00 2001 From: Justin White Date: Mon, 7 Oct 2024 14:18:03 -0400 Subject: [PATCH 1/3] fix enabling NOAA: restore `BITMAP_NOAA` there was data missing in bitmaps.c, I added it back from the last state before it was removed, unsure if this is correct data, but it works on my radio --- bitmaps.c | 17 +++++++++++++++++ bitmaps.h | 2 ++ 2 files changed, 19 insertions(+) diff --git a/bitmaps.c b/bitmaps.c index 27569e1..0a2253a 100644 --- a/bitmaps.c +++ b/bitmaps.c @@ -298,6 +298,23 @@ const uint8_t BITMAP_PowerUser[3] = 0b00001000, }; +#ifdef ENABLE_NOAA +const uint8_t BITMAP_NOAA[12] = +{ // "WX" + 0b00000000, + 0b01111111, + 0b00100000, + 0b00011000, + 0b00100000, + 0b01111111, + 0b00000000, + 0b01100011, + 0b00010100, + 0b00001000, + 0b00010100, + 0b01100011 +}; +#endif #ifndef ENABLE_CUSTOM_MENU_LAYOUT const uint8_t BITMAP_CurrentIndicator[8] = { diff --git a/bitmaps.h b/bitmaps.h index 51ef41a..a7853ec 100644 --- a/bitmaps.h +++ b/bitmaps.h @@ -41,6 +41,8 @@ extern const uint8_t BITMAP_ScanListE[7]; extern const uint8_t BITMAP_PowerUser[3]; extern const uint8_t BITMAP_compand[6]; +extern const uint8_t BITMAP_NOAA[12]; + #ifndef ENABLE_CUSTOM_MENU_LAYOUT extern const uint8_t BITMAP_CurrentIndicator[8]; #endif From 21475ef9bacb18302ee7f3406e022372b72b2984 Mon Sep 17 00:00:00 2001 From: Justin White Date: Mon, 7 Oct 2024 16:21:57 -0400 Subject: [PATCH 2/3] Use CODE_TYPE_OFF for NOAA channels It seemed to default to CTCSS, which means you never hear the NOAA channels unless you use Monitor mode or SQL 0, which is not ideal --- functions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/functions.c b/functions.c index abc8e61..ada5019 100644 --- a/functions.c +++ b/functions.c @@ -79,7 +79,7 @@ void FUNCTION_Init(void) gNOAACountdown_10ms = 0; if (IS_NOAA_CHANNEL(gRxVfo->CHANNEL_SAVE)) { - gCurrentCodeType = CODE_TYPE_CONTINUOUS_TONE; + gCurrentCodeType = CODE_TYPE_OFF; } #endif From f1ccc367c080b06ab2863d28b6f3db7d03e2c3d0 Mon Sep 17 00:00:00 2001 From: Justin White Date: Mon, 7 Oct 2024 13:58:43 -0400 Subject: [PATCH 3/3] exit NOAA mode back to MR mode instead of VFO mode If Scan Ranges are enabled, you can't get to NOAA from VFO anyway --- app/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/main.c b/app/main.c index 5c5d8d4..328cb06 100644 --- a/app/main.c +++ b/app/main.c @@ -210,9 +210,9 @@ static void processFKeyFunction(const KEY_Code_t Key, const bool beep) gEeprom.ScreenChannel[Vfo] = gEeprom.NoaaChannel[gEeprom.TX_VFO]; } else { - gEeprom.ScreenChannel[Vfo] = gEeprom.FreqChannel[gEeprom.TX_VFO]; + gEeprom.ScreenChannel[Vfo] = gEeprom.MrChannel[gEeprom.TX_VFO]; #ifdef ENABLE_VOICE - gAnotherVoiceID = VOICE_ID_FREQUENCY_MODE; + gAnotherVoiceID = VOICE_ID_CHANNEL_MODE; #endif } gRequestSaveVFO = true;