Commit Graph

505 Commits

Author SHA1 Message Date
Juan Antonio
e5cff16d98 Merge guarded code. Simplify DTMF_CheckGroupCall 2023-12-28 22:08:56 +01:00
Juan Antonio
36ecde86e9 Reduce nesting 2023-12-28 22:08:56 +01:00
Krzysiek Egzmont
1882ab0cc1 Refactor 2023-12-26 01:40:04 +01:00
Krzysiek Egzmont
995045006f Read/write BK4819 regs through UART 2023-12-25 23:52:15 +01:00
Juan Antonio
cbf4a7c140 Use function table. Simplify logic
Size: 60364 -> 60220
2023-12-25 22:49:06 +01:00
Juan Antonio
7a7010da55 Unify PrintSmall functions
Size: 60420 -> 60364
2023-12-25 22:49:06 +01:00
Juan Antonio
78a45d9bbd Create function to zero gFrameBuffer
Size: 60464 -> 60420
2023-12-25 22:49:06 +01:00
Juan Antonio
f8ef687026 Use pointers to avoid some string copying
Size: 60664 -> 60464
2023-12-25 22:49:06 +01:00
Juan Antonio
986c0ce368 Fix RX not honoring Backlight on TX/RX settings properly
Fixes #317
2023-12-24 22:56:35 +01:00
Juan Antonio
ee0ba9886d Simplify DTMF_FindContact 2023-12-24 13:34:05 +01:00
Juan Antonio
084fe4dd26 Fix 1750Hz so that it can perform STE
1750Hz and CTCSS tones can be send together.
2023-12-24 13:34:05 +01:00
Juan Antonio
6f1cabc807 Simplify gSchedulePowerSave logic
There was quite convoluted logic there, and what I believe, was a bug.

Rationale:

Both,
- gBatterySaveCountdown_10ms = battery_save_count_10ms;, and
- gSchedulePowerSave = false
are always executed inside FUNCTION_Select().

So the code is equivalent to:

if (any of those OR'd) {
	gBatterySaveCountdown_10ms = battery_save_count_10ms;
	gSchedulePowerSave = false; (but only if we have NOAA disabled)
} else {
	[other stuff from FUNCTION_Select()]
	gBatterySaveCountdown_10ms = battery_save_count_10ms;
	gSchedulePowerSave = false; (regarless of having NOAA or not)
}

So:
- OR is true, have NOAA-> don't clear gSchedulePowerSave
	-> implies we will enter here, again, until the OR is false, but only if we have NOAA.
- OR is False -> clear gSchedulePowerSave.

Moreover, checking with DualTachyon code at
6f8afac886/app/app.c (L747)
gSchedulePowerSave is always set to false if it was true.
2023-12-24 13:34:05 +01:00
Juan Antonio
1f4f026162 Simplify APP_EndTransmission
* Unify Roger-Beep selection
 * Extract function for DTMF EoT
2023-12-24 13:34:05 +01:00
Juan Antonio
34f2168856 Spectrum warp-around when switching steps 2023-12-24 13:34:05 +01:00
Juan Antonio
bc9bb489e6 Un-unroll some loops and save a few bytes 2023-12-24 13:34:05 +01:00
Krzysiek Egzmont
2cc60da9ab Fix #314:Reset current bar when blacklisting in scan range 2023-12-22 20:22:39 +01:00
Krzysiek Egzmont
39eb3e835e Scan range in spectrum 2023-12-19 18:25:45 +01:00
Krzysiek Egzmont
13b6bb06b2 Spectrum analyzer, more frequency steps 2023-12-19 03:08:18 +01:00
Juan Antonio
2a75f8a9be Refactoring #285
Signed-off-by: Krzysiek Egzmont <egzumer@gmail.com>
2023-12-16 18:34:54 +01:00
Krzysiek Egzmont
fc679c77a4 Fix other backlight menu issues #275 2023-12-15 18:08:40 +01:00
Krzysiek Egzmont
af6b542da1 Cleanup 2023-12-15 13:47:07 +01:00
Juan Antonio
cc49a5007c Fix #275 Backlight does not get back to MAX brightness after exiting backlight menu entries
Backlight is set to FULL when interacting with backlight menu entries,
but it is not set back to MAX when exiting from those entries. This
commit corrects that behaviour.
2023-12-15 13:00:08 +01:00
Juan Antonio
9dc79ce868 Fix compilation errors when UART is disabled 2023-12-14 22:03:44 +01:00
Juan Antonio
7f5236c44e Fix compilation errors when FM radio is disabled 2023-12-14 22:03:44 +01:00
Juan Antonio
4b583bf2bd Assign NOP function when the flashlight is disabled 2023-12-14 22:03:44 +01:00
Juan Antonio
d0ae34f9b4 Replace memmove by memcpy 2023-12-13 16:07:07 +01:00
Juan Antonio
34d688b101 Logic simplification. Replace memmove by memcpy 2023-12-13 16:07:07 +01:00
Krzysiek Egzmont
0c2fc6184c Fix #234: Bring back FM radio status indicator, show dual watch inactive while in FM radio 2023-12-12 00:52:26 +01:00
Juan Antonio
2e69acbdc4 Fix aircopy bypassing TX restrictions & refactor
And scrapes together a few more bytes.
2023-12-09 19:07:20 +01:00
Krzysiek Egzmont
eb6a3d0867 Fix compile error 2023-12-09 16:21:11 +01:00
Krzysiek Egzmont
e22cc4ccd0 Code comments 2023-12-09 15:51:40 +01:00
Juan Antonio
a153e63be1 Add function to test if serial configuration is in progress
This was formely tested all over using testing for the state of
gSerialConfigCountDown_500ms in a couple of ways. This logic have been
extracted into a function to make the code more readable.
Also testing it with > 0 was a bit misleading as the variable is
unsigned so tesing with == and != is enough.
2023-12-09 15:50:59 +01:00
Juan Antonio
4322a7d8a9 Drop gScreenToDisplay switch and use function table
Saves some bytes
2023-12-09 15:50:59 +01:00
Juan Antonio
1203fdf0ca Use stepping instead of branching using modulus
Modulus operations are very costly and generally should be avoided.
They also take a few bytes.

This version is actually a quite faster.
2023-12-09 15:50:59 +01:00
Juan Antonio
cfc4763dd1 Scrape together a few bytes 2023-12-09 15:50:59 +01:00
Juan Antonio
b6a49db31d FM Radio: Simplify logic 2023-12-08 23:18:19 +01:00
Juan Antonio
82ddbcd375 Refactor stepFruencyTable & drop ARRAY_SIZE for frequencyBandTable 2023-12-08 23:17:33 +01:00
Juan Antonio
335c2ec9cd ACTION_Handle: Drop switch in favour of a function array 2023-12-08 01:43:12 +01:00
Juan Antonio
4249d917f8 Refactor of app/action.c
* Extracted funcionts
* Simplified logic of some functions
* Moved things arround a bit. Conditional code moved to the end
2023-12-08 01:43:12 +01:00
Juan Antonio
2164461449 Use function to check if in RX mode 2023-12-08 01:43:12 +01:00
Juan Antonio
4fd1ab8899 Remove redudant symbol 2023-12-08 01:43:12 +01:00
Krzysiek Egzmont
f7061c3195 FIX #206: missing 254.1Hz CTCSS code 2023-12-07 22:03:22 +01:00
Krzysiek Egzmont
5e78916dd3 AM-fix cleanup 2023-12-07 21:08:12 +01:00
Krzysiek Egzmont
c697596806 FIX #194: Spectrum going crazy when AM-fix is active 2023-12-07 17:45:20 +01:00
Juan Antonio
754d2ce5fb Make Flashlight optional 2023-12-07 00:46:59 +01:00
Juan Antonio
cd032c39d2 Refactor alarm code
- Fixes Alarms bypassing TX restrictions

- Adds enumerations

- Makes use of mode ALARM_STATE_SITE_ALARM (formely ALARM_STATE_ALARM) instead
  checking against ALARM_STATE_TXALARM && ALARM_MODE == ALARM_MODE_TONE
  all over the place
2023-12-07 00:46:59 +01:00
Juan Antonio
103bdf212f Use enum for Flaslight & return early 2023-12-07 00:44:51 +01:00
Juan Antonio
bafe372cbc Simplify backlight logic 2023-12-07 00:44:51 +01:00
Krzysiek Egzmont
e5659ad6ab Fix battery save broken in last commits 2023-12-06 20:36:15 +01:00
Krzysiek Egzmont
c1a009cc2f AM fix modification 2023-12-06 17:54:32 +01:00