2011-12-06 14:21:56 +01:00
|
|
|
/*
|
2013-02-24 18:40:43 +01:00
|
|
|
Minetest
|
2013-02-24 19:38:45 +01:00
|
|
|
Copyright (C) 2010-2013 celeron55, Perttu Ahola <celeron55@gmail.com>
|
2011-12-06 14:21:56 +01:00
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
2012-06-05 16:56:56 +02:00
|
|
|
it under the terms of the GNU Lesser General Public License as published by
|
|
|
|
the Free Software Foundation; either version 2.1 of the License, or
|
2011-12-06 14:21:56 +01:00
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
2012-06-05 16:56:56 +02:00
|
|
|
GNU Lesser General Public License for more details.
|
2011-12-06 14:21:56 +01:00
|
|
|
|
2012-06-05 16:56:56 +02:00
|
|
|
You should have received a copy of the GNU Lesser General Public License along
|
2011-12-06 14:21:56 +01:00
|
|
|
with this program; if not, write to the Free Software Foundation, Inc.,
|
|
|
|
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "inventorymanager.h"
|
2017-08-18 19:25:07 +02:00
|
|
|
#include "debug.h"
|
2011-12-06 14:21:56 +01:00
|
|
|
#include "log.h"
|
2017-01-08 11:01:35 +01:00
|
|
|
#include "serverenvironment.h"
|
2017-04-25 19:38:08 +02:00
|
|
|
#include "scripting_server.h"
|
2020-04-10 21:25:42 +02:00
|
|
|
#include "server/serveractiveobject.h"
|
2012-01-12 06:10:39 +01:00
|
|
|
#include "settings.h"
|
2012-01-21 21:21:41 +01:00
|
|
|
#include "craftdef.h"
|
2012-07-26 21:06:45 +02:00
|
|
|
#include "rollback_interface.h"
|
2016-03-19 17:08:24 +01:00
|
|
|
#include "util/strfnd.h"
|
2016-12-13 23:16:26 +01:00
|
|
|
#include "util/basic_macros.h"
|
2012-06-01 23:33:51 +02:00
|
|
|
|
2013-08-11 04:09:45 +02:00
|
|
|
#define PLAYER_TO_SA(p) p->getEnv()->getScriptIface()
|
|
|
|
|
2011-12-06 14:21:56 +01:00
|
|
|
/*
|
2012-01-12 06:10:39 +01:00
|
|
|
InventoryLocation
|
2011-12-06 14:21:56 +01:00
|
|
|
*/
|
|
|
|
|
2012-01-12 06:10:39 +01:00
|
|
|
std::string InventoryLocation::dump() const
|
2011-12-06 14:21:56 +01:00
|
|
|
{
|
2012-01-12 06:10:39 +01:00
|
|
|
std::ostringstream os(std::ios::binary);
|
|
|
|
serialize(os);
|
|
|
|
return os.str();
|
|
|
|
}
|
2011-12-06 14:21:56 +01:00
|
|
|
|
2012-01-12 06:10:39 +01:00
|
|
|
void InventoryLocation::serialize(std::ostream &os) const
|
|
|
|
{
|
2017-07-01 14:07:40 +02:00
|
|
|
switch (type) {
|
2012-07-25 01:36:54 +02:00
|
|
|
case InventoryLocation::UNDEFINED:
|
|
|
|
os<<"undefined";
|
|
|
|
break;
|
|
|
|
case InventoryLocation::CURRENT_PLAYER:
|
|
|
|
os<<"current_player";
|
|
|
|
break;
|
|
|
|
case InventoryLocation::PLAYER:
|
|
|
|
os<<"player:"<<name;
|
|
|
|
break;
|
|
|
|
case InventoryLocation::NODEMETA:
|
|
|
|
os<<"nodemeta:"<<p.X<<","<<p.Y<<","<<p.Z;
|
|
|
|
break;
|
|
|
|
case InventoryLocation::DETACHED:
|
|
|
|
os<<"detached:"<<name;
|
|
|
|
break;
|
|
|
|
default:
|
2015-03-06 11:21:51 +01:00
|
|
|
FATAL_ERROR("Unhandled inventory location type");
|
2012-07-25 01:36:54 +02:00
|
|
|
}
|
2011-12-06 14:21:56 +01:00
|
|
|
}
|
2012-01-12 06:10:39 +01:00
|
|
|
|
|
|
|
void InventoryLocation::deSerialize(std::istream &is)
|
2011-12-06 14:21:56 +01:00
|
|
|
{
|
2012-01-12 06:10:39 +01:00
|
|
|
std::string tname;
|
|
|
|
std::getline(is, tname, ':');
|
2017-07-01 14:07:40 +02:00
|
|
|
if (tname == "undefined") {
|
2012-01-12 06:10:39 +01:00
|
|
|
type = InventoryLocation::UNDEFINED;
|
2017-07-01 14:07:40 +02:00
|
|
|
} else if (tname == "current_player") {
|
2012-01-12 06:10:39 +01:00
|
|
|
type = InventoryLocation::CURRENT_PLAYER;
|
2017-07-01 14:07:40 +02:00
|
|
|
} else if (tname == "player") {
|
2012-01-12 06:10:39 +01:00
|
|
|
type = InventoryLocation::PLAYER;
|
|
|
|
std::getline(is, name, '\n');
|
2017-07-01 14:07:40 +02:00
|
|
|
} else if (tname == "nodemeta") {
|
2012-01-12 06:10:39 +01:00
|
|
|
type = InventoryLocation::NODEMETA;
|
|
|
|
std::string pos;
|
|
|
|
std::getline(is, pos, '\n');
|
|
|
|
Strfnd fn(pos);
|
2011-12-06 14:21:56 +01:00
|
|
|
p.X = stoi(fn.next(","));
|
|
|
|
p.Y = stoi(fn.next(","));
|
|
|
|
p.Z = stoi(fn.next(","));
|
2017-07-01 14:07:40 +02:00
|
|
|
} else if (tname == "detached") {
|
2012-07-24 19:57:17 +02:00
|
|
|
type = InventoryLocation::DETACHED;
|
|
|
|
std::getline(is, name, '\n');
|
2017-07-01 14:07:40 +02:00
|
|
|
} else {
|
2012-01-12 06:10:39 +01:00
|
|
|
infostream<<"Unknown InventoryLocation type=\""<<tname<<"\""<<std::endl;
|
|
|
|
throw SerializationError("Unknown InventoryLocation type");
|
|
|
|
}
|
|
|
|
}
|
2011-12-06 14:21:56 +01:00
|
|
|
|
Optimize string (mis)handling (#8128)
* Optimize statbar drawing
The texture name of the statbar is a string passed by value.
That slows down the client and creates litter in the heap
as the content of the string is allocated there. Convert the
offending parameter to a const reference to avoid the
performance hit.
* Optimize texture cache
There is an unnecessary temporary created when the texture
path is being generated. This slows down the cache each time
a new texture is encountered and it needs to be loaded into
the cache. Additionally, the heap litter created by this
unnecessary temporary is particularly troublesome here as
the following code then piles another string (the resulting
full path of the texture) on top of it, followed by the
texture itself, which both are quite long term objects as
they are subsequently inserted into the cache where they can
remain for quite a while (especially if the texture turns
out to be a common one like dirt, grass or stone).
Use std::string.append to get rid of the temporary which
solves both issues (speed and heap fragmentation).
* Optimize animations in client
Each time an animated node is updated, an unnecessary copy of
the texture name is created, littering the heap with lots of
fragments. This can be specifically troublesome when looking
at oceans or large lava lakes as both of these nodes are
usually animated (the lava animation is pretty visible).
Convert the parameter of GenericCAO::updateTextures to a
const reference to get rid of the unnecessary copy.
There is a comment stating "std::string copy is mandatory as
mod can be a class member and there is a swap on those class
members ... do NOT pass by reference", reinforcing the
belief that the unnecessary copy is in fact necessary.
However one of the first things the code of the method does
is to assign the parameter to its class member, creating
another copy. By rearranging the code a little bit this
"another copy" can then be used by the subsequent code,
getting rid of the need to pass the parameter by value and
thus saving that copying effort.
* Optimize chat console history handling
The GUIChatConsole::replaceAndAddToHistory was getting the
line to work on by value which turns out to be unnecessary.
Get rid of that unnecessary copy by converting the parameter
to a const reference.
* Optimize gui texture setting
The code used to set the texture for GUI components was
getting the name of the texture by value, creating
unnecessary performance bottleneck for mods/games with
heavily textured GUIs. Get rid of the bottleneck by passing
the texture name as a const reference.
* Optimize sound playing code in GUIEngine
The GUIEngine's code receives the specification of the sound
to be played by value, which turns out to be most likely a
mistake as the underlying sound manager interface receives
the same thing by reference. Convert the offending parameter
to a const reference to get rid of the rather bulky copying
effort and the associated performance hit.
* Silence CLANG TIDY warnings for unit tests
Change "std::string" to "const std::string &" to avoid an
unnecessary local value copy, silencing the CLANG TIDY
process.
* Optimize formspec handling
The "formspec prepend" parameter was passed to the formspec
handling code by value, creating unnecessary copy of
std::string and slowing down the game if mods add things like
textured backgrounds for the player inventory and/or other
forms. Get rid of that performance bottleneck by converting
the parameter to a const reference.
* Optimize hotbar image handling
The code that sets the background images for the hotbar is
getting the name of the image by value, creating an
unnecessary std::string copying effort. Fix that by
converting the relevant parameters to const references.
* Optimize inventory deserialization
The inventory manager deserialization code gets the
serialized version of the inventory by value, slowing the
server and the client down when there are inventory updates.
This can get particularly troublesome with pipeworks which
adds nodes that can mess around with inventories
automatically or with mods that have mobs with inventories
that actively use them.
* Optimize texture scaling cache
There is an io::path parameter passed by value in the
procedure used to add images converted from textures,
leading to slowdown when the image is not yet created and
the conversion is thus needed. The performance hit is
quite significant as io::path is similar to std::string
so convert the parameter to a const reference to get rid of
it.
* Optimize translation file loader
Use "std::string::append" when calculating the final index
for the translation table to avoid unnecessary temporary
strings. This speeds the translation file loader up
significantly as std::string uses heap allocation which
tends to be rather slow. Additionally, the heap is no
longer being littered by these unnecessary string
temporaries, increasing performance of code that gets
executed after the translation file loader finishes.
* Optimize server map saving
When the directory structure for the world data is created
during server map saving, an unnecessary value passing of
the directory name slows things down. Remove that overhead
by converting the offending parameter to a const reference.
2019-05-18 17:19:13 +02:00
|
|
|
void InventoryLocation::deSerialize(const std::string &s)
|
2012-01-12 06:10:39 +01:00
|
|
|
{
|
|
|
|
std::istringstream is(s, std::ios::binary);
|
|
|
|
deSerialize(is);
|
2011-12-06 14:21:56 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
InventoryAction
|
|
|
|
*/
|
|
|
|
|
2017-07-01 14:07:40 +02:00
|
|
|
InventoryAction *InventoryAction::deSerialize(std::istream &is)
|
2011-12-06 14:21:56 +01:00
|
|
|
{
|
|
|
|
std::string type;
|
|
|
|
std::getline(is, type, ' ');
|
|
|
|
|
2017-07-01 14:07:40 +02:00
|
|
|
InventoryAction *a = nullptr;
|
2011-12-06 14:21:56 +01:00
|
|
|
|
2015-06-20 12:55:48 +02:00
|
|
|
if (type == "Move") {
|
|
|
|
a = new IMoveAction(is, false);
|
|
|
|
} else if (type == "MoveSomewhere") {
|
|
|
|
a = new IMoveAction(is, true);
|
|
|
|
} else if (type == "Drop") {
|
2011-12-06 14:21:56 +01:00
|
|
|
a = new IDropAction(is);
|
2017-07-01 14:07:40 +02:00
|
|
|
} else if (type == "Craft") {
|
2012-01-21 21:21:41 +01:00
|
|
|
a = new ICraftAction(is);
|
|
|
|
}
|
2011-12-06 14:21:56 +01:00
|
|
|
|
|
|
|
return a;
|
|
|
|
}
|
|
|
|
|
2012-01-22 00:49:02 +01:00
|
|
|
/*
|
|
|
|
IMoveAction
|
|
|
|
*/
|
|
|
|
|
2017-07-01 14:07:40 +02:00
|
|
|
IMoveAction::IMoveAction(std::istream &is, bool somewhere) :
|
|
|
|
move_somewhere(somewhere)
|
2011-12-06 14:21:56 +01:00
|
|
|
{
|
|
|
|
std::string ts;
|
|
|
|
|
|
|
|
std::getline(is, ts, ' ');
|
|
|
|
count = stoi(ts);
|
|
|
|
|
2012-01-12 06:10:39 +01:00
|
|
|
std::getline(is, ts, ' ');
|
|
|
|
from_inv.deSerialize(ts);
|
2011-12-06 14:21:56 +01:00
|
|
|
|
|
|
|
std::getline(is, from_list, ' ');
|
|
|
|
|
|
|
|
std::getline(is, ts, ' ');
|
|
|
|
from_i = stoi(ts);
|
|
|
|
|
2012-01-12 06:10:39 +01:00
|
|
|
std::getline(is, ts, ' ');
|
|
|
|
to_inv.deSerialize(ts);
|
2011-12-06 14:21:56 +01:00
|
|
|
|
|
|
|
std::getline(is, to_list, ' ');
|
|
|
|
|
2015-06-20 12:55:48 +02:00
|
|
|
if (!somewhere) {
|
|
|
|
std::getline(is, ts, ' ');
|
|
|
|
to_i = stoi(ts);
|
|
|
|
}
|
2011-12-06 14:21:56 +01:00
|
|
|
}
|
|
|
|
|
2020-09-04 20:49:07 +02:00
|
|
|
void IMoveAction::swapDirections()
|
|
|
|
{
|
|
|
|
std::swap(from_inv, to_inv);
|
|
|
|
std::swap(from_list, to_list);
|
|
|
|
std::swap(from_i, to_i);
|
|
|
|
}
|
|
|
|
|
|
|
|
void IMoveAction::onPutAndOnTake(const ItemStack &src_item, ServerActiveObject *player) const
|
|
|
|
{
|
|
|
|
ServerScripting *sa = PLAYER_TO_SA(player);
|
|
|
|
if (to_inv.type == InventoryLocation::DETACHED)
|
|
|
|
sa->detached_inventory_OnPut(*this, src_item, player);
|
|
|
|
else if (to_inv.type == InventoryLocation::NODEMETA)
|
|
|
|
sa->nodemeta_inventory_OnPut(*this, src_item, player);
|
|
|
|
else if (to_inv.type == InventoryLocation::PLAYER)
|
|
|
|
sa->player_inventory_OnPut(*this, src_item, player);
|
|
|
|
else
|
|
|
|
assert(false);
|
|
|
|
|
|
|
|
if (from_inv.type == InventoryLocation::DETACHED)
|
|
|
|
sa->detached_inventory_OnTake(*this, src_item, player);
|
|
|
|
else if (from_inv.type == InventoryLocation::NODEMETA)
|
|
|
|
sa->nodemeta_inventory_OnTake(*this, src_item, player);
|
|
|
|
else if (from_inv.type == InventoryLocation::PLAYER)
|
|
|
|
sa->player_inventory_OnTake(*this, src_item, player);
|
|
|
|
else
|
|
|
|
assert(false);
|
|
|
|
}
|
|
|
|
|
|
|
|
void IMoveAction::onMove(int count, ServerActiveObject *player) const
|
|
|
|
{
|
|
|
|
ServerScripting *sa = PLAYER_TO_SA(player);
|
|
|
|
if (from_inv.type == InventoryLocation::DETACHED)
|
|
|
|
sa->detached_inventory_OnMove(*this, count, player);
|
|
|
|
else if (from_inv.type == InventoryLocation::NODEMETA)
|
|
|
|
sa->nodemeta_inventory_OnMove(*this, count, player);
|
|
|
|
else if (from_inv.type == InventoryLocation::PLAYER)
|
|
|
|
sa->player_inventory_OnMove(*this, count, player);
|
|
|
|
else
|
|
|
|
assert(false);
|
|
|
|
}
|
|
|
|
|
|
|
|
int IMoveAction::allowPut(const ItemStack &dst_item, ServerActiveObject *player) const
|
|
|
|
{
|
|
|
|
ServerScripting *sa = PLAYER_TO_SA(player);
|
|
|
|
int dst_can_put_count = 0xffff;
|
|
|
|
if (to_inv.type == InventoryLocation::DETACHED)
|
|
|
|
dst_can_put_count = sa->detached_inventory_AllowPut(*this, dst_item, player);
|
|
|
|
else if (to_inv.type == InventoryLocation::NODEMETA)
|
|
|
|
dst_can_put_count = sa->nodemeta_inventory_AllowPut(*this, dst_item, player);
|
|
|
|
else if (to_inv.type == InventoryLocation::PLAYER)
|
|
|
|
dst_can_put_count = sa->player_inventory_AllowPut(*this, dst_item, player);
|
|
|
|
else
|
|
|
|
assert(false);
|
|
|
|
return dst_can_put_count;
|
|
|
|
}
|
|
|
|
|
|
|
|
int IMoveAction::allowTake(const ItemStack &src_item, ServerActiveObject *player) const
|
|
|
|
{
|
|
|
|
ServerScripting *sa = PLAYER_TO_SA(player);
|
|
|
|
int src_can_take_count = 0xffff;
|
|
|
|
if (from_inv.type == InventoryLocation::DETACHED)
|
|
|
|
src_can_take_count = sa->detached_inventory_AllowTake(*this, src_item, player);
|
|
|
|
else if (from_inv.type == InventoryLocation::NODEMETA)
|
|
|
|
src_can_take_count = sa->nodemeta_inventory_AllowTake(*this, src_item, player);
|
|
|
|
else if (from_inv.type == InventoryLocation::PLAYER)
|
|
|
|
src_can_take_count = sa->player_inventory_AllowTake(*this, src_item, player);
|
|
|
|
else
|
|
|
|
assert(false);
|
|
|
|
return src_can_take_count;
|
|
|
|
}
|
|
|
|
|
|
|
|
int IMoveAction::allowMove(int try_take_count, ServerActiveObject *player) const
|
|
|
|
{
|
|
|
|
ServerScripting *sa = PLAYER_TO_SA(player);
|
|
|
|
int src_can_take_count = 0xffff;
|
|
|
|
if (from_inv.type == InventoryLocation::DETACHED)
|
|
|
|
src_can_take_count = sa->detached_inventory_AllowMove(*this, try_take_count, player);
|
|
|
|
else if (from_inv.type == InventoryLocation::NODEMETA)
|
|
|
|
src_can_take_count = sa->nodemeta_inventory_AllowMove(*this, try_take_count, player);
|
|
|
|
else if (from_inv.type == InventoryLocation::PLAYER)
|
|
|
|
src_can_take_count = sa->player_inventory_AllowMove(*this, try_take_count, player);
|
|
|
|
else
|
|
|
|
assert(false);
|
|
|
|
return src_can_take_count;
|
|
|
|
}
|
|
|
|
|
2012-01-21 21:21:41 +01:00
|
|
|
void IMoveAction::apply(InventoryManager *mgr, ServerActiveObject *player, IGameDef *gamedef)
|
2011-12-06 14:21:56 +01:00
|
|
|
{
|
2012-01-12 06:10:39 +01:00
|
|
|
Inventory *inv_from = mgr->getInventory(from_inv);
|
|
|
|
Inventory *inv_to = mgr->getInventory(to_inv);
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2015-07-01 17:03:02 +02:00
|
|
|
if (!inv_from) {
|
|
|
|
infostream << "IMoveAction::apply(): FAIL: source inventory not found: "
|
|
|
|
<< "from_inv=\""<<from_inv.dump() << "\""
|
|
|
|
<< ", to_inv=\"" << to_inv.dump() << "\"" << std::endl;
|
2011-12-06 14:21:56 +01:00
|
|
|
return;
|
|
|
|
}
|
2015-07-01 17:03:02 +02:00
|
|
|
if (!inv_to) {
|
|
|
|
infostream << "IMoveAction::apply(): FAIL: destination inventory not found: "
|
|
|
|
<< "from_inv=\"" << from_inv.dump() << "\""
|
|
|
|
<< ", to_inv=\"" << to_inv.dump() << "\"" << std::endl;
|
2011-12-06 14:21:56 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
InventoryList *list_from = inv_from->getList(from_list);
|
|
|
|
InventoryList *list_to = inv_to->getList(to_list);
|
|
|
|
|
|
|
|
/*
|
|
|
|
If a list doesn't exist or the source item doesn't exist
|
|
|
|
*/
|
2015-07-01 17:03:02 +02:00
|
|
|
if (!list_from) {
|
|
|
|
infostream << "IMoveAction::apply(): FAIL: source list not found: "
|
|
|
|
<< "from_inv=\"" << from_inv.dump() << "\""
|
|
|
|
<< ", from_list=\"" << from_list << "\"" << std::endl;
|
2011-12-06 14:21:56 +01:00
|
|
|
return;
|
|
|
|
}
|
2015-07-01 17:03:02 +02:00
|
|
|
if (!list_to) {
|
|
|
|
infostream << "IMoveAction::apply(): FAIL: destination list not found: "
|
|
|
|
<< "to_inv=\""<<to_inv.dump() << "\""
|
|
|
|
<< ", to_list=\"" << to_list << "\"" << std::endl;
|
2011-12-06 14:21:56 +01:00
|
|
|
return;
|
|
|
|
}
|
2012-07-25 01:36:54 +02:00
|
|
|
|
2015-06-20 12:55:48 +02:00
|
|
|
if (move_somewhere) {
|
|
|
|
s16 old_to_i = to_i;
|
|
|
|
u16 old_count = count;
|
|
|
|
caused_by_move_somewhere = true;
|
|
|
|
move_somewhere = false;
|
|
|
|
|
|
|
|
infostream << "IMoveAction::apply(): moving item somewhere"
|
|
|
|
<< " msom=" << move_somewhere
|
|
|
|
<< " count=" << count
|
|
|
|
<< " from inv=\"" << from_inv.dump() << "\""
|
|
|
|
<< " list=\"" << from_list << "\""
|
|
|
|
<< " i=" << from_i
|
|
|
|
<< " to inv=\"" << to_inv.dump() << "\""
|
|
|
|
<< " list=\"" << to_list << "\""
|
|
|
|
<< std::endl;
|
|
|
|
|
|
|
|
// Try to add the item to destination list
|
|
|
|
s16 dest_size = list_to->getSize();
|
|
|
|
// First try all the non-empty slots
|
|
|
|
for (s16 dest_i = 0; dest_i < dest_size && count > 0; dest_i++) {
|
|
|
|
if (!list_to->getItem(dest_i).empty()) {
|
|
|
|
to_i = dest_i;
|
|
|
|
apply(mgr, player, gamedef);
|
2021-02-21 20:02:23 +01:00
|
|
|
assert(move_count <= count);
|
2015-06-20 12:55:48 +02:00
|
|
|
count -= move_count;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Then try all the empty ones
|
|
|
|
for (s16 dest_i = 0; dest_i < dest_size && count > 0; dest_i++) {
|
|
|
|
if (list_to->getItem(dest_i).empty()) {
|
|
|
|
to_i = dest_i;
|
|
|
|
apply(mgr, player, gamedef);
|
|
|
|
count -= move_count;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
to_i = old_to_i;
|
|
|
|
count = old_count;
|
|
|
|
caused_by_move_somewhere = false;
|
|
|
|
move_somewhere = true;
|
|
|
|
return;
|
|
|
|
}
|
2015-07-01 17:03:02 +02:00
|
|
|
|
|
|
|
if ((u16)to_i > list_to->getSize()) {
|
|
|
|
infostream << "IMoveAction::apply(): FAIL: destination index out of bounds: "
|
|
|
|
<< "to_i=" << to_i
|
|
|
|
<< ", size=" << list_to->getSize() << std::endl;
|
|
|
|
return;
|
|
|
|
}
|
2012-07-26 21:06:45 +02:00
|
|
|
/*
|
|
|
|
Do not handle rollback if both inventories are that of the same player
|
|
|
|
*/
|
|
|
|
bool ignore_rollback = (
|
|
|
|
from_inv.type == InventoryLocation::PLAYER &&
|
2018-04-01 22:50:26 +02:00
|
|
|
from_inv == to_inv);
|
2012-07-26 21:06:45 +02:00
|
|
|
|
2012-07-25 01:36:54 +02:00
|
|
|
/*
|
|
|
|
Collect information of endpoints
|
|
|
|
*/
|
|
|
|
|
2020-09-04 20:49:07 +02:00
|
|
|
ItemStack src_item = list_from->getItem(from_i);
|
|
|
|
if (count > 0)
|
|
|
|
src_item.count = count;
|
|
|
|
if (src_item.empty())
|
|
|
|
return;
|
2012-07-25 01:36:54 +02:00
|
|
|
|
|
|
|
int src_can_take_count = 0xffff;
|
|
|
|
int dst_can_put_count = 0xffff;
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2020-09-04 20:49:07 +02:00
|
|
|
// this is needed for swapping items inside one inventory to work
|
|
|
|
ItemStack restitem;
|
|
|
|
bool allow_swap = !list_to->itemFits(to_i, src_item, &restitem)
|
|
|
|
&& restitem.count == src_item.count
|
|
|
|
&& !caused_by_move_somewhere;
|
2021-02-21 20:02:23 +01:00
|
|
|
move_count = src_item.count - restitem.count;
|
2012-07-25 01:36:54 +02:00
|
|
|
|
2020-09-04 20:49:07 +02:00
|
|
|
// Shift-click: Cannot fill this stack, proceed with next slot
|
2021-02-21 20:02:23 +01:00
|
|
|
if (caused_by_move_somewhere && move_count == 0) {
|
2020-09-04 20:49:07 +02:00
|
|
|
return;
|
2021-02-21 20:02:23 +01:00
|
|
|
}
|
2012-07-25 01:36:54 +02:00
|
|
|
|
2020-09-04 20:49:07 +02:00
|
|
|
if (allow_swap) {
|
|
|
|
// Swap will affect the entire stack if it can performed.
|
|
|
|
src_item = list_from->getItem(from_i);
|
|
|
|
count = src_item.count;
|
2012-07-25 01:36:54 +02:00
|
|
|
}
|
2012-07-25 15:52:00 +02:00
|
|
|
|
2020-09-04 20:49:07 +02:00
|
|
|
if (from_inv == to_inv) {
|
|
|
|
// Move action within the same inventory
|
|
|
|
src_can_take_count = allowMove(src_item.count, player);
|
|
|
|
|
|
|
|
bool swap_expected = allow_swap;
|
|
|
|
allow_swap = allow_swap
|
|
|
|
&& (src_can_take_count == -1 || src_can_take_count >= src_item.count);
|
|
|
|
if (allow_swap) {
|
|
|
|
int try_put_count = list_to->getItem(to_i).count;
|
|
|
|
swapDirections();
|
|
|
|
dst_can_put_count = allowMove(try_put_count, player);
|
|
|
|
allow_swap = allow_swap
|
|
|
|
&& (dst_can_put_count == -1 || dst_can_put_count >= try_put_count);
|
|
|
|
swapDirections();
|
|
|
|
} else {
|
|
|
|
dst_can_put_count = src_can_take_count;
|
2018-03-31 12:30:43 +02:00
|
|
|
}
|
2020-09-04 20:49:07 +02:00
|
|
|
if (swap_expected != allow_swap)
|
|
|
|
src_can_take_count = dst_can_put_count = 0;
|
|
|
|
} else {
|
|
|
|
// Take from one inventory, put into another
|
2021-02-21 20:02:23 +01:00
|
|
|
int src_item_count = src_item.count;
|
|
|
|
if (caused_by_move_somewhere)
|
|
|
|
// When moving somewhere: temporarily use the actual movable stack
|
|
|
|
// size to ensure correct callback execution.
|
|
|
|
src_item.count = move_count;
|
2020-09-04 20:49:07 +02:00
|
|
|
dst_can_put_count = allowPut(src_item, player);
|
|
|
|
src_can_take_count = allowTake(src_item, player);
|
2021-02-21 20:02:23 +01:00
|
|
|
if (caused_by_move_somewhere)
|
|
|
|
// Reset source item count
|
|
|
|
src_item.count = src_item_count;
|
2020-09-04 20:49:07 +02:00
|
|
|
bool swap_expected = allow_swap;
|
|
|
|
allow_swap = allow_swap
|
|
|
|
&& (src_can_take_count == -1 || src_can_take_count >= src_item.count)
|
|
|
|
&& (dst_can_put_count == -1 || dst_can_put_count >= src_item.count);
|
|
|
|
// A swap is expected, which means that we have to
|
|
|
|
// run the "allow" callbacks a second time with swapped inventories
|
|
|
|
if (allow_swap) {
|
|
|
|
ItemStack dst_item = list_to->getItem(to_i);
|
|
|
|
swapDirections();
|
|
|
|
|
|
|
|
int src_can_take = allowPut(dst_item, player);
|
|
|
|
int dst_can_put = allowTake(dst_item, player);
|
|
|
|
allow_swap = allow_swap
|
|
|
|
&& (src_can_take == -1 || src_can_take >= dst_item.count)
|
|
|
|
&& (dst_can_put == -1 || dst_can_put >= dst_item.count);
|
|
|
|
swapDirections();
|
2018-03-31 12:30:43 +02:00
|
|
|
}
|
2020-09-04 20:49:07 +02:00
|
|
|
if (swap_expected != allow_swap)
|
|
|
|
src_can_take_count = dst_can_put_count = 0;
|
2018-03-31 12:30:43 +02:00
|
|
|
}
|
|
|
|
|
2012-07-25 15:52:00 +02:00
|
|
|
int old_count = count;
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2012-07-25 01:36:54 +02:00
|
|
|
/* Modify count according to collected data */
|
2020-09-04 20:49:07 +02:00
|
|
|
count = src_item.count;
|
2017-07-01 14:07:40 +02:00
|
|
|
if (src_can_take_count != -1 && count > src_can_take_count)
|
2012-07-25 15:52:00 +02:00
|
|
|
count = src_can_take_count;
|
2017-07-01 14:07:40 +02:00
|
|
|
if (dst_can_put_count != -1 && count > dst_can_put_count)
|
2012-07-25 15:52:00 +02:00
|
|
|
count = dst_can_put_count;
|
2021-02-21 20:02:23 +01:00
|
|
|
|
2012-07-25 15:52:00 +02:00
|
|
|
/* Limit according to source item count */
|
2017-07-01 14:07:40 +02:00
|
|
|
if (count > list_from->getItem(from_i).count)
|
2012-07-25 15:52:00 +02:00
|
|
|
count = list_from->getItem(from_i).count;
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2012-07-25 01:36:54 +02:00
|
|
|
/* If no items will be moved, don't go further */
|
2017-07-01 14:07:40 +02:00
|
|
|
if (count == 0) {
|
2021-02-21 20:02:23 +01:00
|
|
|
if (caused_by_move_somewhere)
|
|
|
|
// Set move count to zero, as no items have been moved
|
|
|
|
move_count = 0;
|
|
|
|
|
2019-09-18 18:47:09 +02:00
|
|
|
// Undo client prediction. See 'clientApply'
|
|
|
|
if (from_inv.type == InventoryLocation::PLAYER)
|
|
|
|
list_from->setModified();
|
|
|
|
|
|
|
|
if (to_inv.type == InventoryLocation::PLAYER)
|
|
|
|
list_to->setModified();
|
|
|
|
|
2012-07-25 15:52:00 +02:00
|
|
|
infostream<<"IMoveAction::apply(): move was completely disallowed:"
|
|
|
|
<<" count="<<old_count
|
2012-06-01 23:33:51 +02:00
|
|
|
<<" from inv=\""<<from_inv.dump()<<"\""
|
|
|
|
<<" list=\""<<from_list<<"\""
|
|
|
|
<<" i="<<from_i
|
|
|
|
<<" to inv=\""<<to_inv.dump()<<"\""
|
|
|
|
<<" list=\""<<to_list<<"\""
|
|
|
|
<<" i="<<to_i
|
|
|
|
<<std::endl;
|
2021-02-21 20:02:23 +01:00
|
|
|
|
2012-07-25 01:36:54 +02:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-09-04 20:49:07 +02:00
|
|
|
src_item = list_from->getItem(from_i);
|
2012-07-25 13:35:59 +02:00
|
|
|
src_item.count = count;
|
2012-07-25 15:52:00 +02:00
|
|
|
ItemStack from_stack_was = list_from->getItem(from_i);
|
|
|
|
ItemStack to_stack_was = list_to->getItem(to_i);
|
2012-07-25 01:36:54 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
Perform actual move
|
|
|
|
|
|
|
|
If something is wrong (source item is empty, destination is the
|
|
|
|
same as source), nothing happens
|
|
|
|
*/
|
2015-08-19 02:28:37 +02:00
|
|
|
bool did_swap = false;
|
2015-06-20 12:55:48 +02:00
|
|
|
move_count = list_from->moveItem(from_i,
|
2020-09-04 20:49:07 +02:00
|
|
|
list_to, to_i, count, allow_swap, &did_swap);
|
2021-02-21 20:02:23 +01:00
|
|
|
if (caused_by_move_somewhere)
|
|
|
|
count = old_count;
|
2020-09-04 20:49:07 +02:00
|
|
|
assert(allow_swap == did_swap);
|
2012-07-25 01:36:54 +02:00
|
|
|
|
2012-07-25 15:52:00 +02:00
|
|
|
// If source is infinite, reset it's stack
|
2015-07-19 02:27:12 +02:00
|
|
|
if (src_can_take_count == -1) {
|
|
|
|
// For the caused_by_move_somewhere == true case we didn't force-put the item,
|
|
|
|
// which guarantees there is no leftover, and code below would duplicate the
|
|
|
|
// (not replaced) to_stack_was item.
|
|
|
|
if (!caused_by_move_somewhere) {
|
|
|
|
// If destination stack is of different type and there are leftover
|
|
|
|
// items, attempt to put the leftover items to a different place in the
|
|
|
|
// destination inventory.
|
|
|
|
// The client-side GUI will try to guess if this happens.
|
|
|
|
if (from_stack_was.name != to_stack_was.name) {
|
|
|
|
for (u32 i = 0; i < list_to->getSize(); i++) {
|
|
|
|
if (list_to->getItem(i).empty()) {
|
|
|
|
list_to->changeItem(i, to_stack_was);
|
|
|
|
break;
|
|
|
|
}
|
2012-09-02 21:51:38 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2015-08-19 02:28:37 +02:00
|
|
|
if (move_count > 0 || did_swap) {
|
2015-07-19 02:27:12 +02:00
|
|
|
list_from->deleteItem(from_i);
|
|
|
|
list_from->addItem(from_i, from_stack_was);
|
|
|
|
}
|
2012-07-25 15:52:00 +02:00
|
|
|
}
|
|
|
|
// If destination is infinite, reset it's stack and take count from source
|
2017-07-01 14:07:40 +02:00
|
|
|
if (dst_can_put_count == -1) {
|
2012-07-25 15:52:00 +02:00
|
|
|
list_to->deleteItem(to_i);
|
|
|
|
list_to->addItem(to_i, to_stack_was);
|
2012-09-02 22:01:40 +02:00
|
|
|
list_from->deleteItem(from_i);
|
|
|
|
list_from->addItem(from_i, from_stack_was);
|
2012-07-25 15:52:00 +02:00
|
|
|
list_from->takeItem(from_i, count);
|
|
|
|
}
|
|
|
|
|
2015-06-20 12:55:48 +02:00
|
|
|
infostream << "IMoveAction::apply(): moved"
|
|
|
|
<< " msom=" << move_somewhere
|
|
|
|
<< " caused=" << caused_by_move_somewhere
|
|
|
|
<< " count=" << count
|
|
|
|
<< " from inv=\"" << from_inv.dump() << "\""
|
|
|
|
<< " list=\"" << from_list << "\""
|
|
|
|
<< " i=" << from_i
|
|
|
|
<< " to inv=\"" << to_inv.dump() << "\""
|
|
|
|
<< " list=\"" << to_list << "\""
|
|
|
|
<< " i=" << to_i
|
|
|
|
<< std::endl;
|
2012-07-25 01:36:54 +02:00
|
|
|
|
2015-07-19 02:27:12 +02:00
|
|
|
// If we are inside the move somewhere loop, we don't need to report
|
2021-02-21 20:02:23 +01:00
|
|
|
// anything if nothing happened
|
2017-07-01 14:07:40 +02:00
|
|
|
if (caused_by_move_somewhere && move_count == 0)
|
2015-07-19 02:27:12 +02:00
|
|
|
return;
|
|
|
|
|
2012-07-26 21:06:45 +02:00
|
|
|
/*
|
|
|
|
Record rollback information
|
|
|
|
*/
|
2017-07-01 14:07:40 +02:00
|
|
|
if (!ignore_rollback && gamedef->rollback()) {
|
2014-06-26 02:28:41 +02:00
|
|
|
IRollbackManager *rollback = gamedef->rollback();
|
2012-07-26 21:06:45 +02:00
|
|
|
|
|
|
|
// If source is not infinite, record item take
|
2017-07-01 14:07:40 +02:00
|
|
|
if (src_can_take_count != -1) {
|
2012-07-26 21:06:45 +02:00
|
|
|
RollbackAction action;
|
|
|
|
std::string loc;
|
|
|
|
{
|
|
|
|
std::ostringstream os(std::ios::binary);
|
|
|
|
from_inv.serialize(os);
|
|
|
|
loc = os.str();
|
|
|
|
}
|
|
|
|
action.setModifyInventoryStack(loc, from_list, from_i, false,
|
2014-06-26 02:28:41 +02:00
|
|
|
src_item);
|
2012-07-26 21:06:45 +02:00
|
|
|
rollback->reportAction(action);
|
|
|
|
}
|
|
|
|
// If destination is not infinite, record item put
|
2017-07-01 14:07:40 +02:00
|
|
|
if (dst_can_put_count != -1) {
|
2012-07-26 21:06:45 +02:00
|
|
|
RollbackAction action;
|
|
|
|
std::string loc;
|
|
|
|
{
|
|
|
|
std::ostringstream os(std::ios::binary);
|
|
|
|
to_inv.serialize(os);
|
|
|
|
loc = os.str();
|
|
|
|
}
|
|
|
|
action.setModifyInventoryStack(loc, to_list, to_i, true,
|
2014-06-26 02:28:41 +02:00
|
|
|
src_item);
|
2012-07-26 21:06:45 +02:00
|
|
|
rollback->reportAction(action);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-07-25 01:36:54 +02:00
|
|
|
/*
|
|
|
|
Report move to endpoints
|
|
|
|
*/
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2020-09-04 20:49:07 +02:00
|
|
|
// Source = destination => move
|
|
|
|
if (from_inv == to_inv) {
|
|
|
|
onMove(count, player);
|
|
|
|
if (did_swap) {
|
|
|
|
// Item is now placed in source list
|
|
|
|
src_item = list_from->getItem(from_i);
|
|
|
|
swapDirections();
|
|
|
|
onMove(src_item.count, player);
|
|
|
|
swapDirections();
|
2012-07-25 01:36:54 +02:00
|
|
|
}
|
2020-09-04 20:49:07 +02:00
|
|
|
mgr->setInventoryModified(from_inv);
|
2018-03-31 12:30:43 +02:00
|
|
|
} else {
|
2021-02-21 20:02:23 +01:00
|
|
|
int src_item_count = src_item.count;
|
|
|
|
if (caused_by_move_somewhere)
|
|
|
|
// When moving somewhere: temporarily use the actual movable stack
|
|
|
|
// size to ensure correct callback execution.
|
|
|
|
src_item.count = move_count;
|
2020-09-04 20:49:07 +02:00
|
|
|
onPutAndOnTake(src_item, player);
|
2021-02-21 20:02:23 +01:00
|
|
|
if (caused_by_move_somewhere)
|
|
|
|
// Reset source item count
|
|
|
|
src_item.count = src_item_count;
|
2020-09-04 20:49:07 +02:00
|
|
|
if (did_swap) {
|
|
|
|
// Item is now placed in source list
|
|
|
|
src_item = list_from->getItem(from_i);
|
|
|
|
swapDirections();
|
|
|
|
onPutAndOnTake(src_item, player);
|
|
|
|
swapDirections();
|
2018-03-31 12:30:43 +02:00
|
|
|
}
|
2019-08-25 10:55:27 +02:00
|
|
|
mgr->setInventoryModified(to_inv);
|
2020-09-04 20:49:07 +02:00
|
|
|
mgr->setInventoryModified(from_inv);
|
|
|
|
}
|
2011-12-06 14:21:56 +01:00
|
|
|
}
|
|
|
|
|
2012-01-22 00:49:02 +01:00
|
|
|
void IMoveAction::clientApply(InventoryManager *mgr, IGameDef *gamedef)
|
|
|
|
{
|
|
|
|
// Optional InventoryAction operation that is run on the client
|
|
|
|
// to make lag less apparent.
|
|
|
|
|
|
|
|
Inventory *inv_from = mgr->getInventory(from_inv);
|
|
|
|
Inventory *inv_to = mgr->getInventory(to_inv);
|
2017-07-01 14:07:40 +02:00
|
|
|
if (!inv_from || !inv_to)
|
2012-01-22 00:49:02 +01:00
|
|
|
return;
|
|
|
|
|
|
|
|
InventoryLocation current_player;
|
|
|
|
current_player.setCurrentPlayer();
|
|
|
|
Inventory *inv_player = mgr->getInventory(current_player);
|
2017-07-01 14:07:40 +02:00
|
|
|
if (inv_from != inv_player || inv_to != inv_player)
|
2012-01-22 00:49:02 +01:00
|
|
|
return;
|
|
|
|
|
|
|
|
InventoryList *list_from = inv_from->getList(from_list);
|
|
|
|
InventoryList *list_to = inv_to->getList(to_list);
|
2017-07-01 14:07:40 +02:00
|
|
|
if (!list_from || !list_to)
|
2012-01-22 00:49:02 +01:00
|
|
|
return;
|
|
|
|
|
2015-06-20 12:55:48 +02:00
|
|
|
if (!move_somewhere)
|
|
|
|
list_from->moveItem(from_i, list_to, to_i, count);
|
|
|
|
else
|
|
|
|
list_from->moveItemSomewhere(from_i, list_to, count);
|
2012-01-22 00:49:02 +01:00
|
|
|
|
|
|
|
mgr->setInventoryModified(from_inv);
|
2017-07-01 14:07:40 +02:00
|
|
|
if (inv_from != inv_to)
|
2012-01-22 00:49:02 +01:00
|
|
|
mgr->setInventoryModified(to_inv);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
IDropAction
|
|
|
|
*/
|
|
|
|
|
2011-12-06 14:21:56 +01:00
|
|
|
IDropAction::IDropAction(std::istream &is)
|
|
|
|
{
|
|
|
|
std::string ts;
|
|
|
|
|
|
|
|
std::getline(is, ts, ' ');
|
|
|
|
count = stoi(ts);
|
|
|
|
|
2012-01-12 06:10:39 +01:00
|
|
|
std::getline(is, ts, ' ');
|
|
|
|
from_inv.deSerialize(ts);
|
2011-12-06 14:21:56 +01:00
|
|
|
|
|
|
|
std::getline(is, from_list, ' ');
|
|
|
|
|
|
|
|
std::getline(is, ts, ' ');
|
|
|
|
from_i = stoi(ts);
|
|
|
|
}
|
|
|
|
|
2012-01-21 21:21:41 +01:00
|
|
|
void IDropAction::apply(InventoryManager *mgr, ServerActiveObject *player, IGameDef *gamedef)
|
2011-12-06 14:21:56 +01:00
|
|
|
{
|
2012-01-12 06:10:39 +01:00
|
|
|
Inventory *inv_from = mgr->getInventory(from_inv);
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2017-07-01 14:07:40 +02:00
|
|
|
if (!inv_from) {
|
2011-12-06 14:21:56 +01:00
|
|
|
infostream<<"IDropAction::apply(): FAIL: source inventory not found: "
|
2012-01-12 06:10:39 +01:00
|
|
|
<<"from_inv=\""<<from_inv.dump()<<"\""<<std::endl;
|
2011-12-06 14:21:56 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
InventoryList *list_from = inv_from->getList(from_list);
|
|
|
|
|
|
|
|
/*
|
|
|
|
If a list doesn't exist or the source item doesn't exist
|
|
|
|
*/
|
2017-07-01 14:07:40 +02:00
|
|
|
if (!list_from) {
|
2011-12-06 14:21:56 +01:00
|
|
|
infostream<<"IDropAction::apply(): FAIL: source list not found: "
|
2012-01-12 06:10:39 +01:00
|
|
|
<<"from_inv=\""<<from_inv.dump()<<"\""<<std::endl;
|
2011-12-06 14:21:56 +01:00
|
|
|
return;
|
|
|
|
}
|
2017-07-01 14:07:40 +02:00
|
|
|
if (list_from->getItem(from_i).empty()) {
|
2011-12-06 14:21:56 +01:00
|
|
|
infostream<<"IDropAction::apply(): FAIL: source item not found: "
|
2012-01-12 06:10:39 +01:00
|
|
|
<<"from_inv=\""<<from_inv.dump()<<"\""
|
2011-12-06 14:21:56 +01:00
|
|
|
<<", from_list=\""<<from_list<<"\""
|
|
|
|
<<" from_i="<<from_i<<std::endl;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-07-26 21:06:45 +02:00
|
|
|
/*
|
|
|
|
Do not handle rollback if inventory is player's
|
|
|
|
*/
|
|
|
|
bool ignore_src_rollback = (from_inv.type == InventoryLocation::PLAYER);
|
|
|
|
|
2012-07-25 01:36:54 +02:00
|
|
|
/*
|
|
|
|
Collect information of endpoints
|
|
|
|
*/
|
2012-06-01 23:42:56 +02:00
|
|
|
|
2012-07-25 01:36:54 +02:00
|
|
|
int take_count = list_from->getItem(from_i).count;
|
2017-07-01 14:07:40 +02:00
|
|
|
if (count != 0 && count < take_count)
|
2012-07-25 01:36:54 +02:00
|
|
|
take_count = count;
|
|
|
|
int src_can_take_count = take_count;
|
|
|
|
|
2018-03-31 13:47:19 +02:00
|
|
|
ItemStack src_item = list_from->getItem(from_i);
|
|
|
|
src_item.count = take_count;
|
2012-07-25 01:36:54 +02:00
|
|
|
|
2018-03-31 13:47:19 +02:00
|
|
|
// Run callbacks depending on source inventory
|
|
|
|
switch (from_inv.type) {
|
|
|
|
case InventoryLocation::DETACHED:
|
|
|
|
src_can_take_count = PLAYER_TO_SA(player)->detached_inventory_AllowTake(
|
|
|
|
*this, src_item, player);
|
|
|
|
break;
|
|
|
|
case InventoryLocation::NODEMETA:
|
2013-05-25 00:51:02 +02:00
|
|
|
src_can_take_count = PLAYER_TO_SA(player)->nodemeta_inventory_AllowTake(
|
2018-03-31 13:47:19 +02:00
|
|
|
*this, src_item, player);
|
|
|
|
break;
|
|
|
|
case InventoryLocation::PLAYER:
|
|
|
|
src_can_take_count = PLAYER_TO_SA(player)->player_inventory_AllowTake(
|
|
|
|
*this, src_item, player);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
2012-06-01 23:42:56 +02:00
|
|
|
}
|
2012-01-13 12:35:55 +01:00
|
|
|
|
2017-07-01 14:07:40 +02:00
|
|
|
if (src_can_take_count != -1 && src_can_take_count < take_count)
|
2012-07-25 01:36:54 +02:00
|
|
|
take_count = src_can_take_count;
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2018-03-31 13:47:19 +02:00
|
|
|
// Update item due executed callbacks
|
|
|
|
src_item = list_from->getItem(from_i);
|
2012-07-25 13:35:59 +02:00
|
|
|
|
2012-07-25 01:36:54 +02:00
|
|
|
// Drop the item
|
|
|
|
ItemStack item1 = list_from->getItem(from_i);
|
2012-08-12 14:49:06 +02:00
|
|
|
item1.count = take_count;
|
2015-05-29 20:30:55 +02:00
|
|
|
if(PLAYER_TO_SA(player)->item_OnDrop(item1, player,
|
|
|
|
player->getBasePosition())) {
|
2019-09-17 19:02:01 +02:00
|
|
|
int actually_dropped_count = take_count - item1.count;
|
2012-01-13 12:35:55 +01:00
|
|
|
|
2017-07-01 14:07:40 +02:00
|
|
|
if (actually_dropped_count == 0) {
|
2012-07-25 01:36:54 +02:00
|
|
|
infostream<<"Actually dropped no items"<<std::endl;
|
2019-09-18 18:47:09 +02:00
|
|
|
|
|
|
|
// Revert client prediction. See 'clientApply'
|
|
|
|
if (from_inv.type == InventoryLocation::PLAYER)
|
|
|
|
list_from->setModified();
|
2012-07-25 01:36:54 +02:00
|
|
|
return;
|
|
|
|
}
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2012-07-25 15:52:00 +02:00
|
|
|
// If source isn't infinite
|
2017-07-01 14:07:40 +02:00
|
|
|
if (src_can_take_count != -1) {
|
2012-07-25 15:52:00 +02:00
|
|
|
// Take item from source list
|
|
|
|
ItemStack item2 = list_from->takeItem(from_i, actually_dropped_count);
|
2012-01-13 12:35:55 +01:00
|
|
|
|
2017-07-01 14:07:40 +02:00
|
|
|
if (item2.count != actually_dropped_count)
|
2012-07-25 15:52:00 +02:00
|
|
|
errorstream<<"Could not take dropped count of items"<<std::endl;
|
|
|
|
}
|
2019-09-17 19:02:01 +02:00
|
|
|
|
|
|
|
src_item.count = actually_dropped_count;
|
|
|
|
mgr->setInventoryModified(from_inv);
|
2012-01-12 06:10:39 +01:00
|
|
|
}
|
2011-12-06 14:21:56 +01:00
|
|
|
|
|
|
|
infostream<<"IDropAction::apply(): dropped "
|
2012-01-12 06:10:39 +01:00
|
|
|
<<" from inv=\""<<from_inv.dump()<<"\""
|
2011-12-06 14:21:56 +01:00
|
|
|
<<" list=\""<<from_list<<"\""
|
|
|
|
<<" i="<<from_i
|
|
|
|
<<std::endl;
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2012-07-25 01:36:54 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
Report drop to endpoints
|
|
|
|
*/
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2018-03-31 13:47:19 +02:00
|
|
|
switch (from_inv.type) {
|
|
|
|
case InventoryLocation::DETACHED:
|
2013-05-25 00:51:02 +02:00
|
|
|
PLAYER_TO_SA(player)->detached_inventory_OnTake(
|
2018-03-31 13:47:19 +02:00
|
|
|
*this, src_item, player);
|
|
|
|
break;
|
|
|
|
case InventoryLocation::NODEMETA:
|
2013-05-25 00:51:02 +02:00
|
|
|
PLAYER_TO_SA(player)->nodemeta_inventory_OnTake(
|
2018-03-31 13:47:19 +02:00
|
|
|
*this, src_item, player);
|
|
|
|
break;
|
|
|
|
case InventoryLocation::PLAYER:
|
|
|
|
PLAYER_TO_SA(player)->player_inventory_OnTake(
|
|
|
|
*this, src_item, player);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
2012-07-25 01:36:54 +02:00
|
|
|
}
|
2012-07-26 21:06:45 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
Record rollback information
|
|
|
|
*/
|
2017-07-01 14:07:40 +02:00
|
|
|
if (!ignore_src_rollback && gamedef->rollback()) {
|
2014-06-26 02:28:41 +02:00
|
|
|
IRollbackManager *rollback = gamedef->rollback();
|
2012-07-26 21:06:45 +02:00
|
|
|
|
|
|
|
// If source is not infinite, record item take
|
2017-07-01 14:07:40 +02:00
|
|
|
if (src_can_take_count != -1) {
|
2012-07-26 21:06:45 +02:00
|
|
|
RollbackAction action;
|
|
|
|
std::string loc;
|
|
|
|
{
|
|
|
|
std::ostringstream os(std::ios::binary);
|
|
|
|
from_inv.serialize(os);
|
|
|
|
loc = os.str();
|
|
|
|
}
|
|
|
|
action.setModifyInventoryStack(loc, from_list, from_i,
|
2014-06-26 02:28:41 +02:00
|
|
|
false, src_item);
|
2012-07-26 21:06:45 +02:00
|
|
|
rollback->reportAction(action);
|
|
|
|
}
|
|
|
|
}
|
2011-12-06 14:21:56 +01:00
|
|
|
}
|
2012-01-21 21:21:41 +01:00
|
|
|
|
2012-01-22 00:49:02 +01:00
|
|
|
void IDropAction::clientApply(InventoryManager *mgr, IGameDef *gamedef)
|
|
|
|
{
|
|
|
|
// Optional InventoryAction operation that is run on the client
|
|
|
|
// to make lag less apparent.
|
|
|
|
|
|
|
|
Inventory *inv_from = mgr->getInventory(from_inv);
|
2017-07-01 14:07:40 +02:00
|
|
|
if (!inv_from)
|
2012-01-22 00:49:02 +01:00
|
|
|
return;
|
|
|
|
|
|
|
|
InventoryLocation current_player;
|
|
|
|
current_player.setCurrentPlayer();
|
|
|
|
Inventory *inv_player = mgr->getInventory(current_player);
|
2017-07-01 14:07:40 +02:00
|
|
|
if (inv_from != inv_player)
|
2012-01-22 00:49:02 +01:00
|
|
|
return;
|
|
|
|
|
|
|
|
InventoryList *list_from = inv_from->getList(from_list);
|
2017-07-01 14:07:40 +02:00
|
|
|
if (!list_from)
|
2012-01-22 00:49:02 +01:00
|
|
|
return;
|
|
|
|
|
2017-07-01 14:07:40 +02:00
|
|
|
if (count == 0)
|
2012-01-22 00:49:02 +01:00
|
|
|
list_from->changeItem(from_i, ItemStack());
|
|
|
|
else
|
|
|
|
list_from->takeItem(from_i, count);
|
|
|
|
|
|
|
|
mgr->setInventoryModified(from_inv);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
ICraftAction
|
|
|
|
*/
|
|
|
|
|
2012-01-21 21:21:41 +01:00
|
|
|
ICraftAction::ICraftAction(std::istream &is)
|
|
|
|
{
|
|
|
|
std::string ts;
|
|
|
|
|
|
|
|
std::getline(is, ts, ' ');
|
|
|
|
count = stoi(ts);
|
|
|
|
|
|
|
|
std::getline(is, ts, ' ');
|
|
|
|
craft_inv.deSerialize(ts);
|
|
|
|
}
|
|
|
|
|
2015-06-02 20:30:04 +02:00
|
|
|
void ICraftAction::apply(InventoryManager *mgr,
|
|
|
|
ServerActiveObject *player, IGameDef *gamedef)
|
2012-01-21 21:21:41 +01:00
|
|
|
{
|
|
|
|
Inventory *inv_craft = mgr->getInventory(craft_inv);
|
2015-07-19 02:27:12 +02:00
|
|
|
|
2015-06-02 20:30:04 +02:00
|
|
|
if (!inv_craft) {
|
|
|
|
infostream << "ICraftAction::apply(): FAIL: inventory not found: "
|
|
|
|
<< "craft_inv=\"" << craft_inv.dump() << "\"" << std::endl;
|
2012-01-21 21:21:41 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
InventoryList *list_craft = inv_craft->getList("craft");
|
|
|
|
InventoryList *list_craftresult = inv_craft->getList("craftresult");
|
2015-06-02 20:30:04 +02:00
|
|
|
InventoryList *list_main = inv_craft->getList("main");
|
2012-01-21 21:21:41 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
If a list doesn't exist or the source item doesn't exist
|
|
|
|
*/
|
2015-06-02 20:30:04 +02:00
|
|
|
if (!list_craft) {
|
|
|
|
infostream << "ICraftAction::apply(): FAIL: craft list not found: "
|
|
|
|
<< "craft_inv=\"" << craft_inv.dump() << "\"" << std::endl;
|
2012-01-21 21:21:41 +01:00
|
|
|
return;
|
|
|
|
}
|
2015-06-02 20:30:04 +02:00
|
|
|
if (!list_craftresult) {
|
|
|
|
infostream << "ICraftAction::apply(): FAIL: craftresult list not found: "
|
|
|
|
<< "craft_inv=\"" << craft_inv.dump() << "\"" << std::endl;
|
2012-01-21 21:21:41 +01:00
|
|
|
return;
|
|
|
|
}
|
2015-06-02 20:30:04 +02:00
|
|
|
if (list_craftresult->getSize() < 1) {
|
|
|
|
infostream << "ICraftAction::apply(): FAIL: craftresult list too short: "
|
|
|
|
<< "craft_inv=\"" << craft_inv.dump() << "\"" << std::endl;
|
2012-01-21 21:21:41 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
ItemStack crafted;
|
2013-10-26 11:25:28 +02:00
|
|
|
ItemStack craftresultitem;
|
2012-01-21 21:21:41 +01:00
|
|
|
int count_remaining = count;
|
2015-06-02 20:30:04 +02:00
|
|
|
std::vector<ItemStack> output_replacements;
|
|
|
|
getCraftingResult(inv_craft, crafted, output_replacements, false, gamedef);
|
2013-10-26 11:25:28 +02:00
|
|
|
PLAYER_TO_SA(player)->item_CraftPredict(crafted, player, list_craft, craft_inv);
|
2015-01-10 12:05:42 +01:00
|
|
|
bool found = !crafted.empty();
|
2012-01-21 21:21:41 +01:00
|
|
|
|
2015-06-02 20:30:04 +02:00
|
|
|
while (found && list_craftresult->itemFits(0, crafted)) {
|
2013-10-26 11:25:28 +02:00
|
|
|
InventoryList saved_craft_list = *list_craft;
|
2015-06-02 20:30:04 +02:00
|
|
|
|
|
|
|
std::vector<ItemStack> temp;
|
2012-01-21 21:21:41 +01:00
|
|
|
// Decrement input and add crafting output
|
2015-06-02 20:30:04 +02:00
|
|
|
getCraftingResult(inv_craft, crafted, temp, true, gamedef);
|
2013-10-26 11:25:28 +02:00
|
|
|
PLAYER_TO_SA(player)->item_OnCraft(crafted, player, &saved_craft_list, craft_inv);
|
2012-01-21 21:21:41 +01:00
|
|
|
list_craftresult->addItem(0, crafted);
|
|
|
|
mgr->setInventoryModified(craft_inv);
|
|
|
|
|
2015-06-02 20:30:04 +02:00
|
|
|
// Add the new replacements to the list
|
|
|
|
IItemDefManager *itemdef = gamedef->getItemDefManager();
|
2017-08-18 08:07:59 +02:00
|
|
|
for (auto &itemstack : temp) {
|
|
|
|
for (auto &output_replacement : output_replacements) {
|
|
|
|
if (itemstack.name == output_replacement.name) {
|
|
|
|
itemstack = output_replacement.addItem(itemstack, itemdef);
|
|
|
|
if (itemstack.empty())
|
2015-06-02 20:30:04 +02:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
2017-08-18 08:07:59 +02:00
|
|
|
output_replacements.push_back(itemstack);
|
2015-06-02 20:30:04 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
actionstream << player->getDescription()
|
|
|
|
<< " crafts "
|
|
|
|
<< crafted.getItemString()
|
|
|
|
<< std::endl;
|
2012-01-21 21:21:41 +01:00
|
|
|
|
|
|
|
// Decrement counter
|
2015-06-02 20:30:04 +02:00
|
|
|
if (count_remaining == 1)
|
2012-01-21 21:21:41 +01:00
|
|
|
break;
|
2017-08-18 08:07:59 +02:00
|
|
|
|
|
|
|
if (count_remaining > 1)
|
2012-01-21 21:21:41 +01:00
|
|
|
count_remaining--;
|
|
|
|
|
|
|
|
// Get next crafting result
|
2018-09-23 21:12:39 +02:00
|
|
|
getCraftingResult(inv_craft, crafted, temp, false, gamedef);
|
2013-10-26 11:25:28 +02:00
|
|
|
PLAYER_TO_SA(player)->item_CraftPredict(crafted, player, list_craft, craft_inv);
|
|
|
|
found = !crafted.empty();
|
2012-01-21 21:21:41 +01:00
|
|
|
}
|
|
|
|
|
2015-06-02 20:30:04 +02:00
|
|
|
// Put the replacements in the inventory or drop them on the floor, if
|
2019-08-08 14:30:38 +02:00
|
|
|
// the inventory is full
|
2017-08-18 08:07:59 +02:00
|
|
|
for (auto &output_replacement : output_replacements) {
|
2015-06-02 20:30:04 +02:00
|
|
|
if (list_main)
|
2017-08-18 08:07:59 +02:00
|
|
|
output_replacement = list_main->addItem(output_replacement);
|
|
|
|
if (output_replacement.empty())
|
2015-06-02 20:30:04 +02:00
|
|
|
continue;
|
2017-08-18 08:07:59 +02:00
|
|
|
u16 count = output_replacement.count;
|
2015-06-02 20:30:04 +02:00
|
|
|
do {
|
2017-08-18 08:07:59 +02:00
|
|
|
PLAYER_TO_SA(player)->item_OnDrop(output_replacement, player,
|
2015-05-29 20:30:55 +02:00
|
|
|
player->getBasePosition());
|
2017-08-18 08:07:59 +02:00
|
|
|
if (count >= output_replacement.count) {
|
2015-06-02 20:30:04 +02:00
|
|
|
errorstream << "Couldn't drop replacement stack " <<
|
2017-08-18 08:07:59 +02:00
|
|
|
output_replacement.getItemString() << " because drop loop didn't "
|
2015-06-02 20:30:04 +02:00
|
|
|
"decrease count." << std::endl;
|
|
|
|
|
|
|
|
break;
|
|
|
|
}
|
2017-08-18 08:07:59 +02:00
|
|
|
} while (!output_replacement.empty());
|
2015-06-02 20:30:04 +02:00
|
|
|
}
|
|
|
|
|
2012-01-21 21:21:41 +01:00
|
|
|
infostream<<"ICraftAction::apply(): crafted "
|
|
|
|
<<" craft_inv=\""<<craft_inv.dump()<<"\""
|
|
|
|
<<std::endl;
|
|
|
|
}
|
|
|
|
|
2012-01-22 00:49:02 +01:00
|
|
|
void ICraftAction::clientApply(InventoryManager *mgr, IGameDef *gamedef)
|
|
|
|
{
|
|
|
|
// Optional InventoryAction operation that is run on the client
|
|
|
|
// to make lag less apparent.
|
|
|
|
}
|
|
|
|
|
2012-01-21 21:21:41 +01:00
|
|
|
|
|
|
|
// Crafting helper
|
2017-07-01 14:07:40 +02:00
|
|
|
bool getCraftingResult(Inventory *inv, ItemStack &result,
|
2015-06-02 20:30:04 +02:00
|
|
|
std::vector<ItemStack> &output_replacements,
|
2012-01-21 21:21:41 +01:00
|
|
|
bool decrementInput, IGameDef *gamedef)
|
|
|
|
{
|
|
|
|
result.clear();
|
|
|
|
|
|
|
|
// Get the InventoryList in which we will operate
|
|
|
|
InventoryList *clist = inv->getList("craft");
|
2017-07-01 14:07:40 +02:00
|
|
|
if (!clist)
|
2012-01-21 21:21:41 +01:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// Mangle crafting grid to an another format
|
|
|
|
CraftInput ci;
|
|
|
|
ci.method = CRAFT_METHOD_NORMAL;
|
2012-08-19 23:29:56 +02:00
|
|
|
ci.width = clist->getWidth() ? clist->getWidth() : 3;
|
2017-07-01 14:07:40 +02:00
|
|
|
for (u16 i=0; i < clist->getSize(); i++)
|
2012-01-21 21:21:41 +01:00
|
|
|
ci.items.push_back(clist->getItem(i));
|
|
|
|
|
|
|
|
// Find out what is crafted and add it to result item slot
|
|
|
|
CraftOutput co;
|
|
|
|
bool found = gamedef->getCraftDefManager()->getCraftResult(
|
2015-06-02 20:30:04 +02:00
|
|
|
ci, co, output_replacements, decrementInput, gamedef);
|
2017-07-01 14:07:40 +02:00
|
|
|
if (found)
|
2012-01-21 21:21:41 +01:00
|
|
|
result.deSerialize(co.item, gamedef->getItemDefManager());
|
|
|
|
|
2017-07-01 14:07:40 +02:00
|
|
|
if (found && decrementInput) {
|
2012-01-21 21:21:41 +01:00
|
|
|
// CraftInput has been changed, apply changes in clist
|
2017-07-01 14:07:40 +02:00
|
|
|
for (u16 i=0; i < clist->getSize(); i++) {
|
2012-01-21 21:21:41 +01:00
|
|
|
clist->changeItem(i, ci.items[i]);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return found;
|
|
|
|
}
|
|
|
|
|