From 260de1c2b5a74595f9dd5ed9671834dca13414b2 Mon Sep 17 00:00:00 2001 From: x2048 Date: Sun, 30 Oct 2022 16:54:06 +0100 Subject: [PATCH] Enable negative values for sun/moon orbit tilt (Northern hemisphere) (#12904) --- builtin/settingtypes.txt | 2 +- src/client/sky.cpp | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/builtin/settingtypes.txt b/builtin/settingtypes.txt index e4d345e2d..eaaf74943 100644 --- a/builtin/settingtypes.txt +++ b/builtin/settingtypes.txt @@ -447,7 +447,7 @@ shadow_soft_radius (Soft shadow radius) float 5.0 1.0 15.0 # Set the tilt of Sun/Moon orbit in degrees. # Value of 0 means no tilt / vertical orbit. # Minimum value: 0.0; maximum value: 60.0 -shadow_sky_body_orbit_tilt (Sky Body Orbit Tilt) float 0.0 0.0 60.0 +shadow_sky_body_orbit_tilt (Sky Body Orbit Tilt) float 0.0 -60.0 60.0 [**Post processing] diff --git a/src/client/sky.cpp b/src/client/sky.cpp index e622a6a94..dd1c33b3e 100644 --- a/src/client/sky.cpp +++ b/src/client/sky.cpp @@ -103,10 +103,8 @@ Sky::Sky(s32 id, RenderingEngine *rendering_engine, ITextureSource *tsrc, IShade m_directional_colored_fog = g_settings->getBool("directional_colored_fog"); - if (g_settings->getBool("enable_dynamic_shadows")) { - float val = g_settings->getFloat("shadow_sky_body_orbit_tilt"); - m_sky_body_orbit_tilt = rangelim(val, 0.0f, 60.0f); - } + if (g_settings->getBool("enable_dynamic_shadows")) + m_sky_body_orbit_tilt = g_settings->getFloat("shadow_sky_body_orbit_tilt", -60.0f, 60.0f); setStarCount(1000); }