BRNSystems/minetest
1
0
Fork 0
forked from Mirrorlandia_minetest/minetest
Code Pull Requests 1 Activity

Fix synchronization issue at thread start

Browse Source 
If a newly started thread immediately exits then m_running would
immediately be set to false again and the caller would be stuck
waiting for m_running to become true forever.
Since a mutex for synchronizing startup already exists we can
simply move the while loop into it.

see also: #5134 which introduced m_start_finished_mutex
This commit is contained in:
sfan5 2022-04-30 16:04:19 +02:00
parent 56a558baf8
commit 663c936428
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/threading/thread.cpp
View File

@ -121,12 +121,12 @@ bool Thread::start()
return false; return false;
} }
// Allow spawned thread to continue
m_start_finished_mutex.unlock();
while (!m_running) while (!m_running)
sleep_ms(1); sleep_ms(1);
// Allow spawned thread to continue
m_start_finished_mutex.unlock();
m_joinable = true; m_joinable = true;
return true; return true;