BRNSystems/minetest
1
0
Fork 0
forked from Mirrorlandia_minetest/minetest
Code Pull Requests 1 Activity

Don't print whole json data buffer to errorstream on error

Browse Source 
`errorstream` must not be overly verbose as clientside it is directly printed
onto the ingame chat window. These days, the serverlist can contain > 200k bytes,
so better print it to warningstream if the data buffer is too long.
This commit is contained in:
est31 2016-01-28 23:53:58 +01:00
parent e52ebda8b2
commit 860d70bd0e
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/convert_json.cpp
View File

@ -52,7 +52,13 @@ Json::Value fetchJsonValue(const std::string &url,
if (!reader.parse(stream, root)) { if (!reader.parse(stream, root)) {
errorstream << "URL: " << url << std::endl; errorstream << "URL: " << url << std::endl;
errorstream << "Failed to parse json data " << reader.getFormattedErrorMessages(); errorstream << "Failed to parse json data " << reader.getFormattedErrorMessages();
if (fetch_result.data.size() > 100) {
errorstream << "Data (" << fetch_result.data.size()
<< " bytes) printed to warningstream." << std::endl;
warningstream << "data: \"" << fetch_result.data << "\"" << std::endl;
} else {
errorstream << "data: \"" << fetch_result.data << "\"" << std::endl; errorstream << "data: \"" << fetch_result.data << "\"" << std::endl;
}
return Json::Value(); return Json::Value();
} }

10
src/script/lua_api/l_util.cpp
View File

@ -161,8 +161,14 @@ int ModApiUtil::l_parse_json(lua_State *L)
if (!reader.parse(stream, root)) { if (!reader.parse(stream, root)) {
errorstream << "Failed to parse json data " errorstream << "Failed to parse json data "
<< reader.getFormattedErrorMessages(); << reader.getFormattedErrorMessages();
errorstream << "data: \"" << jsonstr << "\"" size_t jlen = strlen(jsonstr);
<< std::endl; if (jlen > 100) {
errorstream << "Data (" << jlen
<< " bytes) printed to warningstream." << std::endl;
warningstream << "data: \"" << jsonstr << "\"" << std::endl;
} else {
errorstream << "data: \"" << jsonstr << "\"" << std::endl;
}
lua_pushnil(L); lua_pushnil(L);
return 1; return 1;
} }