BRNSystems/minetest
1
0
Fork 0
forked from Mirrorlandia_minetest/minetest
Code Pull Requests 1 Activity

Fix the part of the float test that requires IEC559/IEEE754 compliance

Browse Source 
GCC and CLang compilers fail to support full IEC559 compliance required for the test, when certain compiler flags are active. This patch implements a heuristic that checks for the most common flag in GCC and CLang, plues an extra check which GCC disables when it's not compliant, to hopefully catch most cases where it can't run.
This commit is contained in:
Pedro Gimeno 2018-12-18 11:47:29 +01:00 committed by Loïc Blot
parent 7a4d4bc9e6
commit 8e4095f068
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/unittest/test_serialization.cpp
View File

@ -674,6 +674,19 @@ void TestSerialization::testFloatFormat()
return;
}
// The code below compares the IEEE conversion functions with a
// known good IEC559/IEEE754 implementation. This test neeeds
// IEC559 compliance in the compiler.
#if defined(__GNUC__) && (!defined(__STDC_IEC_559__) || defined(__FAST_MATH__))
// GNU C++ lies about its IEC559 support when -ffast-math is active.
// https://gcc.gnu.org/bugzilla//show_bug.cgi?id=84949
bool is_iec559 = false;
#else
bool is_iec559 = std::numeric_limits<f32>::is_iec559;
#endif
if (!is_iec559)
return;
auto test_single = [&fs, &fm](const u32 &i) -> bool {
memcpy(&fm, &i, 4);
fs = u32Tof32Slow(i);