BRNSystems/minetest
1
0
Fork 0
forked from Mirrorlandia_minetest/minetest
Code Pull Requests 1 Activity

NetworkPacket::putRawPacket: resize m_data to datasize + memcpy

Browse Source 
In some cases NetworkPacket was created using default constructor and m_data is not properly sized.
This fixed out of bounds memory copy
Also use memcpy instead of std::vector affectation to enhance packet creation
This commit is contained in:
Loic Blot 2017-10-10 00:47:37 +02:00
parent 0c9ca27ffc
commit 9d295906ef
No known key found for this signature in database
GPG Key ID: EFAA458E8C153987
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/network/networkpacket.cpp
View File

@ -59,9 +59,11 @@ void NetworkPacket::putRawPacket(u8 *data, u32 datasize, session_t peer_id)
m_datasize = datasize - 2; m_datasize = datasize - 2;
m_peer_id = peer_id; m_peer_id = peer_id;
m_data.resize(m_datasize);
// split command and datas // split command and datas
m_command = readU16(&data[0]); m_command = readU16(&data[0]);
m_data = std::vector<u8>(&data[2], &data[2 + m_datasize]); memcpy(&m_data[0], &data[2], m_datasize);
} }
const char* NetworkPacket::getString(u32 from_offset) const char* NetworkPacket::getString(u32 from_offset)