BRNSystems/minetest
1
0
Fork 0
forked from Mirrorlandia_minetest/minetest
Code Pull Requests 1 Activity

Throw exception instead of assert on nested reliable packets

Browse Source 
Fixes a denial of service vulnerability, issue #784
This commit is contained in:
Kahrl 2013-07-04 06:18:50 +02:00
parent 3f6f327cb9
commit a013f762c4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/connection.cpp
View File

@ -1436,7 +1436,8 @@ SharedBuffer<u8> Connection::processPacket(Channel *channel,
else if(type == TYPE_RELIABLE) else if(type == TYPE_RELIABLE)
{ {
// Recursive reliable packets not allowed // Recursive reliable packets not allowed
assert(reliable == false); if(reliable)
throw InvalidIncomingDataException("Found nested reliable packets");
if(packetdata.getSize() < RELIABLE_HEADER_SIZE) if(packetdata.getSize() < RELIABLE_HEADER_SIZE)
throw InvalidIncomingDataException throw InvalidIncomingDataException