BRNSystems/minetest
1
0
Fork 0
forked from Mirrorlandia_minetest/minetest
Code Pull Requests 1 Activity

Fix Settings::remove() always returning true

Browse Source
This commit is contained in:
Kahrl 2016-01-19 10:15:01 +01:00
parent 87291ea44a
commit b67eab3b00
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/settings.cpp
View File

@ -880,8 +880,14 @@ bool Settings::remove(const std::string &name)
{ {
MutexAutoLock lock(m_mutex); MutexAutoLock lock(m_mutex);
delete m_settings[name].group; std::map<std::string, SettingsEntry>::iterator it = m_settings.find(name);
return m_settings.erase(name); if (it != m_settings.end()) {
delete it->second.group;
m_settings.erase(it);
return true;
} else {
return false;
}
} }