BRNSystems/minetest
1
0
Fork 0
forked from Mirrorlandia_minetest/minetest
Code Pull Requests 1 Activity

Remove a misleading MutexAutoLock in l_to_table

Browse Source 
The temporary is immediately destructed, so the mutex isn't locked
after the line.
Removed the lock, because the Settings member-functions used by
push_settings_table lock the mutex and are thread-safe, but would
cause a dead-lock.
This commit is contained in:
Desour 2023-05-27 07:37:05 +02:00 committed by sfan5
parent 252c79d53a
commit d9f478cbfb
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/script/lua_api/l_settings.cpp
View File

@ -332,7 +332,6 @@ int LuaSettings::l_to_table(lua_State* L)
NO_MAP_LOCK_REQUIRED; NO_MAP_LOCK_REQUIRED;
LuaSettings* o = checkObject<LuaSettings>(L, 1); LuaSettings* o = checkObject<LuaSettings>(L, 1);
MutexAutoLock(o->m_settings->m_mutex);
push_settings_table(L, o->m_settings); push_settings_table(L, o->m_settings);
return 1; return 1;
} }