BRNSystems/minetest
1
0
Fork 0
forked from Mirrorlandia_minetest/minetest
Code Pull Requests 1 Activity

Document how to work with ClangFormat (#10468)

Browse Source 
To avoid the common misunderstanding where a contributor thinks they
must apply the unsuitable formatting requests ClangFormat makes.
This commit is contained in:
Paramat 2020-10-13 23:57:46 +01:00 committed by GitHub
parent 7499ebe46a
commit fc2e120b03
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.github/CONTRIBUTING.md vendored
View File

@ -43,6 +43,14 @@ Contributions are welcome! Here's how you can help:
4. The code's interfaces are well designed, regardless of other aspects that might need more work in the future. 4. The code's interfaces are well designed, regardless of other aspects that might need more work in the future.
5. It uses protocols and formats which include the required compatibility. 5. It uses protocols and formats which include the required compatibility.
### Important note about automated GitHub checks
When you submit a pull request, GitHub automatically runs checks on the Minetest Engine combined with your changes. One of these checks is called 'cpp lint / clang format', which checks code formatting.
Because formatting for readability requires human judgement this check often fails and often makes unsuitable formatting requests which make code readability worse.
If this check fails, look at the details to check for any clear mistakes and correct those. However you should not apply everything ClangFormat requests, ignore requests that make code readability worse and any other clearly unsuitable requests.
Discuss with a core developer if in any doubt and for how to progress.
## Issues ## Issues
If you experience an issue, we would like to know the details - especially when a stable release is on the way. If you experience an issue, we would like to know the details - especially when a stable release is on the way.