Address review comments

This commit is contained in:
teknomunk 2025-01-03 16:12:00 -06:00 committed by the-real-herowl
parent cc125d8eac
commit 7c7c2bcb6d
3 changed files with 4 additions and 5 deletions

@ -634,7 +634,7 @@ minetest.register_globalstep(function(dtime)
--[[ --[[
local pos = mod.get_cart_position(staticdata) local pos = mod.get_cart_position(staticdata)
local le = mcl_util.get_luaentity_from_uuid(staticdata.uuid) local le = mcl_util.get_luaentity_from_uuid(staticdata.uuid)
print("cart# "..uuid.. print("cart# "..staticdata.uuid..
",velocity="..tostring(staticdata.velocity).. ",velocity="..tostring(staticdata.velocity)..
",pos="..tostring(pos).. ",pos="..tostring(pos)..
",le="..tostring(le).. ",le="..tostring(le)..

@ -1,5 +1,6 @@
local modname = minetest.get_current_modname() local modname = minetest.get_current_modname()
local S = minetest.get_translator(modname) local S = minetest.get_translator(modname)
local mcl_log = mcl_util.make_mcl_logger("mcl_logging_minecarts", "Minecarts")
local mod = mcl_minecarts local mod = mcl_minecarts
-- Imports -- Imports
@ -40,7 +41,7 @@ function mod.attach_driver(cart, player)
-- Update player information -- Update player information
mcl_player.player_attached[player_name] = true mcl_player.player_attached[player_name] = true
--minetest.log("action", player_name.." entered minecart #"..tostring(uuid).." at "..tostring(cart._start_pos)) mcl_log(player_name.." entered minecart #"..tostring(staticdata.uuid).." at "..tostring(cart._start_pos))
-- Attach the player object to the minecart -- Attach the player object to the minecart
player:set_attach(cart.object, "", vector.new(1,-1.75,-2), vector.new(0,0,0)) player:set_attach(cart.object, "", vector.new(1,-1.75,-2), vector.new(0,0,0))

@ -512,7 +512,5 @@ function mod.reverse_cart_direction(staticdata)
staticdata.distance = 1 - (staticdata.distance or 0) staticdata.distance = 1 - (staticdata.distance or 0)
-- recalculate direction -- recalculate direction
next_dir = mod:get_rail_direction(staticdata.connected_at, next_dir) staticdata.dir = mod:get_rail_direction(staticdata.connected_at, next_dir)
staticdata.dir = next_dir
end end