MineClone2/mods/ITEMS/mcl_buckets
𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 a620d24ec8 Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914)
Fixes: #3913 #3915

~~You can reproduce the crash by placing a fish bucket on top snow above an unknown node.

I also noticed that the code always uses pointed_thing.above so I fixed that and also added a function to mcl_utils to figure out where a node should be placed (either above or below). Looks like the rest of the code could also use improvement but at least it does not crash now.~~

Cora fixed a bunch of related crashes in Mineclona so I am replacing my commit and cherry picking all her commits here.
https://codeberg.org/mineclonia/mineclonia/pulls/549

Here is the list of fixes from that PR:
- Crash when placing snow layer on unknown nodes
- Crash when snow layers on unknown nodes are flooded
- Crash when placing fishbucket on snow on top of unknown nodes
- Crash when placing chorus flower and stem on unknown
- Crash when placing mob spawners on unknown
- The fishbucket on place to actually replace buildable_to

Co-authored-by: cora <coradelamouche@gmx.ch>
Reviewed-on: https://git.minetest.land/MineClone2/MineClone2/pulls/3914
Reviewed-by: ancientmarinerdev <ancientmariner_dev@proton.me>
Co-authored-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
Co-committed-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
2023-09-29 18:47:07 +00:00
..
locale Update russian translation 2023-08-31 14:16:42 +08:00
API.md fix documentation 2021-07-14 15:22:27 +02:00
fishbuckets.lua Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914) 2023-09-29 18:47:07 +00:00
init.lua Rename Bucket Textures (#3708) 2023-05-14 11:41:39 +00:00
mod.conf Add missing dependency 2022-02-17 14:42:01 +00:00
README.md rewrite README to markdown 2021-07-15 01:03:50 +02:00
register.lua Fix waterlogged mangrove roots leaving water in the nether 2023-05-16 19:35:56 +00:00

MineClone2 Bucket (mcl_bucket)

Originally taken from Minetest Game, adapted for MineClone2.

This mod add buckets to the game, including an API to register your own (see API.md).

License

Copyright (C) 2011-2012 Kahrl kahrl@gmx.net

Copyright (C) 2011-2012 celeron55, Perttu Ahola celeron55@gmail.com

This program is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.

http://www.gnu.org/licenses/lgpl-2.1.html