Add notification when release creation fails

app/blueprints/packages/packages.py

@@ -448,8 +448,12 @@ def edit_maintainers(package):
 		usernames = [x.strip().lower() for x in form.maintainers_str.data.split(",")]
 		users = User.query.filter(func.lower(User.username).in_(usernames)).all()
 
+		thread = package.threads.filter_by(author=get_system_user()).first()
+
 		for user in users:
 			if not user in package.maintainers:
+				if thread:
+					thread.watchers.append(user)
 				addNotification(user, current_user, NotificationType.MAINTAINER,
 						"Added you as a maintainer of {}".format(package.title), package.getDetailsURL(), package)
 

app/tasks/importtasks.py

@@ -70,7 +70,7 @@ def getMeta(urlstr, author):
 		return result
 
 
-def postReleaseCheckUpdate(self, release, path):
+def postReleaseCheckUpdate(self, release: PackageRelease, path):
 	try:
 		tree = build_tree(path, expected_type=ContentType[release.package.type.name],
 				author=release.package.author.username, name=release.package.name)
@@ -130,6 +130,9 @@ def postReleaseCheckUpdate(self, release, path):
 	except MinetestCheckError as err:
 		db.session.rollback()
 
+		msg = f"{err}\n\nTask ID: {self.request.id}\n\nRelease: [View Release]({release.getEditURL()})"
+		post_bot_message(release.package, f"Release {release.title} validation failed", msg)
+
 		if "Fails validation" not in release.title:
 			release.title += " (Fails validation)"
 

app/utils/models.py

@@ -110,7 +110,7 @@ def post_bot_message(package: Package, title: str, message: str):
 		thread.title = "Bot messages for {}".format(package.title)
 		thread.author = system_user
 		thread.private = True
-		thread.watchers.append(package.author)
+		thread.watchers.extend(package.maintainers)
 		db.session.add(thread)
 		db.session.flush()