Mirrorlandia_minetest/contentdb
1
0
Fork 0
mirror of https://github.com/minetest/contentdb.git synced 2024-12-22 22:12:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash when generating diff on new package

Browse Source
This commit is contained in:
rubenwardy 2023-05-12 15:53:06 +01:00
parent dee9959fda
commit 35afd50f3d
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/logic/packages.py
View File

@ -113,7 +113,9 @@ def do_edit_package(user: User, package: Package, was_new: bool, was_web: bool,
not package.checkPerm(user, Permission.CHANGE_NAME):
raise LogicError(403, lazy_gettext("You don't have permission to change the package name"))
before_dict = package.getAsDictionary("/")
before_dict = None
if not was_new:
before_dict = package.getAsDictionary("/")
for alias, to in ALIASES.items():
if alias in data:
@ -190,16 +192,16 @@ def do_edit_package(user: User, package: Package, was_new: bool, was_web: bool,
raise LogicError(400, "Unknown warning: " + warning_id)
package.content_warnings.append(warning)
after_dict = package.getAsDictionary("/")
diff = diff_dictionaries(before_dict, after_dict)
if not was_new:
after_dict = package.getAsDictionary("/")
diff = diff_dictionaries(before_dict, after_dict)
if reason is None:
msg = "Edited {}".format(package.title)
else:
msg = "Edited {} ({})".format(package.title, reason)
diff_desc = describe_difference(diff, 100 - len(msg) - 3)
diff_desc = describe_difference(diff, 100 - len(msg) - 3) if diff else None
if diff_desc:
msg += " [" + diff_desc + "]"