Mirrorlandia_minetest/contentdb
1
0
Fork 0
mirror of https://github.com/minetest/contentdb.git synced 2024-11-08 08:33:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken links in reviews hypertext

Browse Source
This commit is contained in:
rubenwardy 2024-05-02 20:40:54 +01:00
parent 4ac0016c0b
commit 8e719e3503
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/utils/minetest_hypertext.py
View File

@ -56,10 +56,11 @@ def make_indent(w):
class MinetestHTMLParser(HTMLParser): class MinetestHTMLParser(HTMLParser):
def __init__(self, page_url: str, include_images: bool): def __init__(self, page_url: str, include_images: bool, link_prefix: str):
super().__init__() super().__init__()
self.page_url = page_url self.page_url = page_url
self.include_images = include_images self.include_images = include_images
self.link_prefix = link_prefix
self.completed_text = "" self.completed_text = ""
self.current_line = "" self.current_line = ""
@ -101,7 +102,7 @@ class MinetestHTMLParser(HTMLParser):
if self.last_id is not None: if self.last_id is not None:
url = url + "#" + self.last_id url = url + "#" + self.last_id
name = f"link_{len(self.links)}" name = f"{self.link_prefix}{len(self.links)}"
self.links[name] = url self.links[name] = url
self.current_line += f"<action name={name}><u>" self.current_line += f"<action name={name}><u>"
self.current_line += escape_hypertext(gettext("(view table in browser)")) self.current_line += escape_hypertext(gettext("(view table in browser)"))
@ -117,7 +118,7 @@ class MinetestHTMLParser(HTMLParser):
self.current_line += "<b>" self.current_line += "<b>"
elif tag == "a": elif tag == "a":
if "href" in attr_by_name: if "href" in attr_by_name:
name = f"link_{len(self.links)}" name = f"{self.link_prefix}{len(self.links)}"
self.links[name] = self.resolve_url(attr_by_name["href"]) self.links[name] = self.resolve_url(attr_by_name["href"])
self.current_line += f"<action name={name}><u>" self.current_line += f"<action name={name}><u>"
else: else:
@ -223,8 +224,8 @@ class MinetestHTMLParser(HTMLParser):
self.current_line += f"&{name};" self.current_line += f"&{name};"
def html_to_minetest(html, page_url: str, formspec_version: int = 7, include_images: bool = True): def html_to_minetest(html, page_url: str, formspec_version: int = 7, include_images: bool = True, link_prefix: str = "link_"):
parser = MinetestHTMLParser(page_url, include_images) parser = MinetestHTMLParser(page_url, include_images, link_prefix)
parser.feed(html) parser.feed(html)
parser.finish_line() parser.finish_line()
@ -324,7 +325,8 @@ def package_reviews_as_hypertext(package: Package, formspec_version: int = 7):
for review in package.reviews: for review in package.reviews:
review: PackageReview review: PackageReview
html = render_markdown(review.thread.first_reply.comment) html = render_markdown(review.thread.first_reply.comment)
content = html_to_minetest(html, package.get_url("packages.view", absolute=True), formspec_version)["body"].strip() content = html_to_minetest(html, package.get_url("packages.view", absolute=True),
formspec_version, False, f"review_{review.id}_")["body"].strip()
author = make_link(abs_url_for("users.profile", username=review.author.username), review.author.display_name) author = make_link(abs_url_for("users.profile", username=review.author.username), review.author.display_name)
rating = ["👎", "👎", "-", "👍", "👍"][review.rating - 1] rating = ["👎", "👎", "-", "👍", "👍"][review.rating - 1]
comments = make_link(abs_url_for("threads.view", id=review.thread.id), "Comments") comments = make_link(abs_url_for("threads.view", id=review.thread.id), "Comments")