From 954a849ba63881bb143f802c4b8b131ea93a7a7a Mon Sep 17 00:00:00 2001 From: rubenwardy Date: Sun, 3 Mar 2024 01:34:22 +0000 Subject: [PATCH] Fix crash on deleting failed releases --- app/blueprints/api/endpoints.py | 3 ++- app/blueprints/packages/releases.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/blueprints/api/endpoints.py b/app/blueprints/api/endpoints.py index 8c0fc75b..f642309b 100644 --- a/app/blueprints/api/endpoints.py +++ b/app/blueprints/api/endpoints.py @@ -351,7 +351,8 @@ def delete_release(token: APIToken, package: Package, id: int): db.session.delete(release) db.session.commit() - os.remove(release.file_path) + if release.file_path and os.path.isfile(release.file_path): + os.remove(release.file_path) return jsonify({"success": True}) diff --git a/app/blueprints/packages/releases.py b/app/blueprints/packages/releases.py index a3a142fb..f6e15fef 100644 --- a/app/blueprints/packages/releases.py +++ b/app/blueprints/packages/releases.py @@ -242,7 +242,8 @@ def delete_release(package, id): db.session.delete(release) db.session.commit() - os.remove(release.file_path) + if release.file_path and os.path.isfile(release.file_path): + os.remove(release.file_path) return redirect(package.get_url("packages.view"))