Mirrorlandia_minetest/contentdb
1
0
Fork 0
mirror of https://github.com/minetest/contentdb.git synced 2024-12-23 06:22:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

MinetestCheck: Forbid the use of reserved mod names

Browse Source
This commit is contained in:
rubenwardy 2023-08-06 12:21:06 +01:00
parent 92a9a7268c
commit d31162a1fa
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/tasks/minetestcheck/tree.py
View File

@ -23,6 +23,8 @@ from .config import parse_conf
basenamePattern = re.compile("^([a-z0-9_]+)$") basenamePattern = re.compile("^([a-z0-9_]+)$")
DISALLOWED_NAMES = {"core", "minetest", "group"}
def get_base_dir(path): def get_base_dir(path):
if not os.path.isdir(path): if not os.path.isdir(path):
@ -79,6 +81,10 @@ class PackageTreeNode:
elif self.type == ContentType.MOD: elif self.type == ContentType.MOD:
if self.name and not basenamePattern.match(self.name): if self.name and not basenamePattern.match(self.name):
raise MinetestCheckError(f"Invalid base name for mod {self.name} at {self.relative}, names must only contain a-z0-9_.") raise MinetestCheckError(f"Invalid base name for mod {self.name} at {self.relative}, names must only contain a-z0-9_.")
if self.name and self.name in DISALLOWED_NAMES:
raise MinetestCheckError(f"Forbidden mod name '{self.name}' used at {self.relative}")
self.check_dir_casing(["textures", "media", "sounds", "models", "locale"]) self.check_dir_casing(["textures", "media", "sounds", "models", "locale"])
elif self.type == ContentType.MODPACK: elif self.type == ContentType.MODPACK:
self.add_children_from_mod_dir(None) self.add_children_from_mod_dir(None)