Mirrorlandia_minetest/contentdb
1
0
Fork 0
mirror of https://github.com/minetest/contentdb.git synced 2025-03-22 10:12:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make package approval threads private

Browse Source 
We've found that a lot of users comment in these
threads when they shouldn't
This commit is contained in:
rubenwardy
2023-07-22 12:45:21 +01:00
parent c24013435c
commit d374ce27cf
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/blueprints/threads/__init__.py
View File

@ -265,7 +265,7 @@ def view(id):
approvers = User.query.filter(User.rank >= UserRank.APPROVER).all() approvers = User.query.filter(User.rank >= UserRank.APPROVER).all()
add_notification(approvers, current_user, NotificationType.EDITOR_MISC, msg, add_notification(approvers, current_user, NotificationType.EDITOR_MISC, msg,
thread.get_view_url(), thread.package) thread.get_view_url(), thread.package)
post_discord_webhook.delay(current_user.username, post_discord_webhook.delay(current_user.display_name,
"Replied to bot messages: {}".format(thread.get_view_url(absolute=True)), True) "Replied to bot messages: {}".format(thread.get_view_url(absolute=True)), True)
db.session.commit() db.session.commit()
@ -297,8 +297,10 @@ def new():
if package is None and not current_user.rank.at_least(UserRank.APPROVER): if package is None and not current_user.rank.at_least(UserRank.APPROVER):
abort(404) abort(404)
allow_private_change = not package or package.approved
is_review_thread = package and not package.approved is_review_thread = package and not package.approved
allow_private_change = not is_review_thread
if is_review_thread:
def_is_private = True
# Check that user can make the thread # Check that user can make the thread
if package and not package.check_perm(current_user, Permission.CREATE_THREAD): if package and not package.check_perm(current_user, Permission.CREATE_THREAD):
@ -372,7 +374,7 @@ def new():
add_notification(approvers, current_user, NotificationType.EDITOR_MISC, notif_msg, thread.get_view_url(), package) add_notification(approvers, current_user, NotificationType.EDITOR_MISC, notif_msg, thread.get_view_url(), package)
if is_review_thread: if is_review_thread:
post_discord_webhook.delay(current_user.username, post_discord_webhook.delay(current_user.display_name,
"Opened approval thread: {}".format(thread.get_view_url(absolute=True)), True) "Opened approval thread: {}".format(thread.get_view_url(absolute=True)), True)
db.session.commit() db.session.commit()