From dcce351ad2c0fb024c9faeab0efbc275860853b9 Mon Sep 17 00:00:00 2001
From: rubenwardy <rw@rubenwardy.com>
Date: Tue, 20 Jun 2023 00:36:33 +0100
Subject: [PATCH] Improve messages relating to game support

---
 app/blueprints/packages/packages.py      |  4 ++--
 app/templates/packages/game_support.html | 10 ++++++----
 app/templates/todo/game_support.html     |  2 +-
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/app/blueprints/packages/packages.py b/app/blueprints/packages/packages.py
index ba7754c3..4c614d9f 100644
--- a/app/blueprints/packages/packages.py
+++ b/app/blueprints/packages/packages.py
@@ -651,8 +651,8 @@ def similar(package):
 
 class GameSupportForm(FlaskForm):
 	enable_support_detection = BooleanField(lazy_gettext("Enable support detection based on dependencies (recommended)"), [Optional()])
-	supported = StringField(lazy_gettext("Supported games (Comma-separated)"), [Optional()])
-	unsupported = StringField(lazy_gettext("Unsupported games (Comma-separated)"), [Optional()])
+	supported = StringField(lazy_gettext("Supported games"), [Optional()])
+	unsupported = StringField(lazy_gettext("Unsupported games"), [Optional()])
 	supports_all_games = BooleanField(lazy_gettext("Supports all games (unless stated) / is game independent"), [Optional()])
 	submit = SubmitField(lazy_gettext("Save"))
 
diff --git a/app/templates/packages/game_support.html b/app/templates/packages/game_support.html
index 7ff8baba..7373f5fd 100644
--- a/app/templates/packages/game_support.html
+++ b/app/templates/packages/game_support.html
@@ -30,7 +30,7 @@
 
 		{% if package.supports_all_games %}
 			<div class="list-group-item">
-				{{ _("Supports all games unless otherwise stated") }}
+				{{ _("Supports all games (unless excluded by unsupported_games)") }}
 			</div>
 		{% endif %}
 
@@ -93,7 +93,7 @@
 			{{ render_checkbox_field(form.supports_all_games, disabled=not can_support_all_games) }}
 			{% if can_support_all_games %}
 				<p class="text-muted">
-					{{ _("Unless otherwise stated, this package should work with all games.") }}
+					{{ _("When checked, this indicates that this package should support all games, unless excluded by unsupported_games.") }}
 					{{ _("You can check this and still specify games in supported_games that you've tested.") }}
 				</p>
 			{% elif package.type.name == "TXP" %}
@@ -109,9 +109,11 @@
 				<p class="text-muted">
 					{{ _("It's best to add supported/unsupported games to %(conf)s, but in the meantime you can add them here.",
 							conf=package.get_conf_file_name()) }}
+					{{ _("Adding to %(conf)s allows users who install outside ContentDB to benefit as well.",
+							conf=package.get_conf_file_name()) }}
 				</p>
-				{{ render_field(form.supported) }}
-				{{ render_field(form.unsupported) }}
+				{{ render_field(form.supported, hint=_("Comma-separated game names, ex: minetest_game, nodecore")) }}
+				{{ render_field(form.unsupported, hint=_("Comma-separated game names, ex: minetest_game, nodecore")) }}
 			{% endif %}
 
 			{{ render_submit_field(form.submit, class_="mt-4 btn btn-primary") }}
diff --git a/app/templates/todo/game_support.html b/app/templates/todo/game_support.html
index dabe6e77..a87ff68d 100644
--- a/app/templates/todo/game_support.html
+++ b/app/templates/todo/game_support.html
@@ -10,7 +10,7 @@
 	<p>
 		{{ _("You should specify the games supported by your mods and texture packs.") }}
 		{{ _("Specifying game support makes it easier for players to find your content.") }}
-		{{ _("If your package supports all games unless otherwise stated, confirm this using 'Supports all games'") }}
+		{{ _("If your package is game independent, confirm this using 'Supports all games'") }}
 	</p>