From af20d9ff861ffb7cb7e22e5323bd499f70bbe6b1 Mon Sep 17 00:00:00 2001 From: Caleb Butler Date: Sun, 3 Sep 2023 19:22:37 -0400 Subject: [PATCH] Remove deprecated function transformBox --- include/matrix4.h | 49 +++++++++++++---------------------------------- 1 file changed, 13 insertions(+), 36 deletions(-) diff --git a/include/matrix4.h b/include/matrix4.h index 1245546b..eaa4fa31 100644 --- a/include/matrix4.h +++ b/include/matrix4.h @@ -151,7 +151,7 @@ namespace core CMatrix4 operator*(const CMatrix4& other) const; //! Multiply by another matrix. - /** Like calling: (*this) = (*this) * other + /** Like calling: (*this) = (*this) * other */ CMatrix4& operator*=(const CMatrix4& other); @@ -190,10 +190,10 @@ namespace core //! Get the rotation, as set by setRotation() when you already know the scale used to create the matrix /** NOTE: The scale needs to be the correct one used to create this matrix. - You can _not_ use the result of getScale(), but have to save your scale + You can _not_ use the result of getScale(), but have to save your scale variable in another place (like ISceneNode does). NOTE: No scale value can be 0 or the result is undefined. - NOTE: It does not necessarily return the *same* Euler angles as those set by setRotationDegrees(), + NOTE: It does not necessarily return the *same* Euler angles as those set by setRotationDegrees(), but the rotation will be equivalent, i.e. will have the same result when used to rotate a vector or node. NOTE: It will (usually) give wrong results when further transformations have been added in the matrix (like shear). WARNING: There have been troubles with this function over the years and we may still have missed some corner cases. @@ -203,9 +203,9 @@ namespace core //! Returns the rotation, as set by setRotation(). /** NOTE: You will have the same end-rotation as used in setRotation, but it might not use the same axis values. - NOTE: This only works correct if no other matrix operations have been done on the inner 3x3 matrix besides + NOTE: This only works correct if no other matrix operations have been done on the inner 3x3 matrix besides setting rotation (so no scale/shear). Thought it (probably) works as long as scale doesn't flip handedness. - NOTE: It does not necessarily return the *same* Euler angles as those set by setRotationDegrees(), + NOTE: It does not necessarily return the *same* Euler angles as those set by setRotationDegrees(), but the rotation will be equivalent, i.e. will have the same result when used to rotate a vector or node. */ core::vector3d getRotationDegrees() const; @@ -278,13 +278,6 @@ namespace core void transformPlane( const core::plane3d &in, core::plane3d &out) const; //! Transforms a axis aligned bounding box - /** The result box of this operation may not be accurate at all. For - correct results, use transformBoxEx() */ - void transformBox(core::aabbox3d& box) const; - - //! Transforms a axis aligned bounding box - /** The result box of this operation should be accurate, but this operation - is slower than transformBox(). */ void transformBoxEx(core::aabbox3d& box) const; //! Multiplies this matrix by a 1x4 matrix @@ -906,8 +899,8 @@ namespace core //! Returns a rotation which (mostly) works in combination with the given scale - /** - This code was originally written by by Chev (assuming no scaling back then, + /** + This code was originally written by by Chev (assuming no scaling back then, we can be blamed for all problems added by regarding scale) */ template @@ -953,17 +946,17 @@ namespace core template inline core::vector3d CMatrix4::getRotationDegrees() const { - // Note: Using getScale() here make it look like it could do matrix decomposition. - // It can't! It works (or should work) as long as rotation doesn't flip the handedness - // aka scale swapping 1 or 3 axes. (I think we could catch that as well by comparing + // Note: Using getScale() here make it look like it could do matrix decomposition. + // It can't! It works (or should work) as long as rotation doesn't flip the handedness + // aka scale swapping 1 or 3 axes. (I think we could catch that as well by comparing // crossproduct of first 2 axes to direction of third axis, but TODO) - // And maybe it should also offer the solution for the simple calculation + // And maybe it should also offer the solution for the simple calculation // without regarding scaling as Irrlicht did before 1.7 core::vector3d scale(getScale()); // We assume the matrix uses rotations instead of negative scaling 2 axes. - // Otherwise it fails even for some simple cases, like rotating around - // 2 axes by 180° which getScale thinks is a negative scaling. + // Otherwise it fails even for some simple cases, like rotating around + // 2 axes by 180° which getScale thinks is a negative scaling. if (scale.Y<0 && scale.Z<0) { scale.Y =-scale.Y; @@ -1278,22 +1271,6 @@ namespace core transformPlane( out ); } - //! Transforms the edge-points of a bounding box - //! Deprecated as it's usually not what people need (regards only 2 corners, but other corners might be outside the box after transformation) - //! Use transformBoxEx instead. - template - _IRR_DEPRECATED_ inline void CMatrix4::transformBox(core::aabbox3d& box) const - { -#if defined ( USE_MATRIX_TEST ) - if (isIdentity()) - return; -#endif - - transformVect(box.MinEdge); - transformVect(box.MaxEdge); - box.repair(); - } - //! Transforms a axis aligned bounding box more accurately than transformBox() template inline void CMatrix4::transformBoxEx(core::aabbox3d& box) const