mirror of
https://github.com/minetest/minetest.git
synced 2024-09-12 00:26:50 +02:00
builtin: Fix print
crashing on nil "holes".
The engine implementation of `print` packs the varargs into a table and passes the table directly to `table.concat`. If you pass any value not supported by `table.concat` (particularly `nil`), the server crashes. This is unexpected behavior, as `print` is supposed to be able to work with anything. This patch changes the implementation so it first converts all arguments using `tostring`, which fixes the issue and makes the custom `print` function compatible with the stock Lua behavior.
This commit is contained in:
parent
16c7008771
commit
430195381d
@ -12,7 +12,11 @@ if core.print then
|
|||||||
-- Override native print and use
|
-- Override native print and use
|
||||||
-- terminal if that's turned on
|
-- terminal if that's turned on
|
||||||
function print(...)
|
function print(...)
|
||||||
core_print(table.concat({...}, "\t"))
|
local n, t = select("#", ...), { ... }
|
||||||
|
for i = 1, n do
|
||||||
|
t[i] = tostring(t[i])
|
||||||
|
end
|
||||||
|
core_print(table.concat(t, "\t"))
|
||||||
end
|
end
|
||||||
core.print = nil -- don't pollute our namespace
|
core.print = nil -- don't pollute our namespace
|
||||||
end
|
end
|
||||||
|
Loading…
Reference in New Issue
Block a user