From 50d20a854cd6e94efd44dc64a3b28a19727d6b33 Mon Sep 17 00:00:00 2001 From: Lars Mueller Date: Fri, 7 Jun 2024 23:03:15 +0200 Subject: [PATCH] Fix -Wsign-compare warning --- irr/src/CGLTFMeshFileLoader.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/irr/src/CGLTFMeshFileLoader.cpp b/irr/src/CGLTFMeshFileLoader.cpp index 6e7cd3ee6..537911e88 100644 --- a/irr/src/CGLTFMeshFileLoader.cpp +++ b/irr/src/CGLTFMeshFileLoader.cpp @@ -650,8 +650,10 @@ void SelfType::MeshExtractor::copyTCoords( std::optional SelfType::tryParseGLTF(io::IReadFile* file) { auto size = file->getSize(); + if (size < 0) // this can happen if `ftell` fails + return std::nullopt; auto buf = std::make_unique(size + 1); - if (file->read(buf.get(), size) != size) + if (file->read(buf.get(), size) != static_cast(size)) return std::nullopt; // We probably don't need this, but add it just to be sure. buf[size] = '\0';