Mirrorlandia_minetest/minetest
1
0
Fork 1
mirror of https://github.com/minetest/minetest.git synced 2024-12-23 22:52:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make safeWriteToFile safe for thread-concurrent use

Browse Source
This commit is contained in:
sfan5 2024-06-05 22:58:33 +02:00
parent fee6e8e11b
commit 8268c61b9f
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/filesys.cpp
View File

@ -25,6 +25,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include <cstring> #include <cstring>
#include <cerrno> #include <cerrno>
#include <fstream> #include <fstream>
#include <atomic>
#include "log.h" #include "log.h"
#include "config.h" #include "config.h"
#include "porting.h" #include "porting.h"
@ -854,10 +855,12 @@ const char *GetFilenameFromPath(const char *path)
return filename ? filename + 1 : path; return filename ? filename + 1 : path;
} }
// Note: this is not safe if two MT processes try this at the same time (FIXME?)
bool safeWriteToFile(const std::string &path, std::string_view content) bool safeWriteToFile(const std::string &path, std::string_view content)
{ {
// Note: this is not safe if two MT processes try this at the same time (FIXME?) // Prevent two threads from writing to the same temporary file
const std::string tmp_file = path + ".~mt"; static std::atomic<u16> g_file_counter;
const std::string tmp_file = path + ".~mt" + itos(g_file_counter.fetch_add(1));
// Write data to a temporary file // Write data to a temporary file
std::string write_error; std::string write_error;