Mirrorlandia_minetest/minetest
1
0
Fork 1
mirror of https://github.com/minetest/minetest.git synced 2024-07-15 04:09:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Mark Redis database backend as deprecated (#14679)

Browse Source
This commit is contained in:
sfan5 2024-05-26 14:28:30 +02:00 committed by GitHub
parent a86baefda7
commit 83bc362dac
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/database/database-redis.cpp
View File

@ -32,6 +32,9 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include <hiredis.h> #include <hiredis.h>
#include <cassert> #include <cassert>
#if VERSION_MAJOR > 5 || VERSION_MINOR > 9
#define DEPRECATION_PERIOD_OVER
#endif
Database_Redis::Database_Redis(Settings &conf) Database_Redis::Database_Redis(Settings &conf)
{ {
@ -66,6 +69,14 @@ Database_Redis::Database_Redis(Settings &conf)
} }
freeReplyObject(reply); freeReplyObject(reply);
} }
warningstream << "/!\\ You are using the deprecated redis backend. "
#ifdef DEPRECATION_PERIOD_OVER
<< "This backend is only still supported for migrations. /!\\\n"
#else
<< "This backend will become read-only in the next release. /!\\\n"
#endif
<< "Please migrate to SQLite3 or PostgreSQL instead." << std::endl;
} }
Database_Redis::~Database_Redis() Database_Redis::~Database_Redis()
@ -73,16 +84,22 @@ Database_Redis::~Database_Redis()
redisFree(ctx); redisFree(ctx);
} }
void Database_Redis::beginSave() { void Database_Redis::beginSave()
{
#ifdef DEPRECATION_PERIOD_OVER
throw DatabaseException("Redis backend is read-only, see deprecation notice.");
#else
redisReply *reply = static_cast<redisReply *>(redisCommand(ctx, "MULTI")); redisReply *reply = static_cast<redisReply *>(redisCommand(ctx, "MULTI"));
if (!reply) { if (!reply) {
throw DatabaseException(std::string( throw DatabaseException(std::string(
"Redis command 'MULTI' failed: ") + ctx->errstr); "Redis command 'MULTI' failed: ") + ctx->errstr);
} }
freeReplyObject(reply); freeReplyObject(reply);
#endif
} }
void Database_Redis::endSave() { void Database_Redis::endSave()
{
redisReply *reply = static_cast<redisReply *>(redisCommand(ctx, "EXEC")); redisReply *reply = static_cast<redisReply *>(redisCommand(ctx, "EXEC"));
if (!reply) { if (!reply) {
throw DatabaseException(std::string( throw DatabaseException(std::string(