Mirrorlandia_minetest/minetest
1
0
Fork 1
mirror of https://github.com/minetest/minetest.git synced 2024-11-27 10:03:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Occlusion culling: Add comments, minor code improvements

Browse Source 
Remove unnecessary code.
Use '/ 2.0f' because endoff is a float.
This commit is contained in:
paramat 2016-11-08 16:07:56 +00:00
parent c79370023b
commit c05aac3766
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/clientmap.cpp
View File

@ -293,14 +293,19 @@ void ClientMap::updateDrawList(video::IVideoDriver* driver)
float step = BS * 1; float step = BS * 1;
float stepfac = 1.1; float stepfac = 1.1;
float startoff = BS * 1; float startoff = BS * 1;
// - Length of the diagonal of a mapblock. // The occlusion search of 'isOccluded()' must stop short of the target
// point by distance 'endoff' (end offset) to not enter the target mapblock.
// For the 8 mapblock corners 'endoff' must therefore be the maximum diagonal
// of a mapblock, because we must consider all view angles.
// sqrt(1^2 + 1^2 + 1^2) = 1.732
float endoff = -BS * MAP_BLOCKSIZE * 1.732050807569; float endoff = -BS * MAP_BLOCKSIZE * 1.732050807569;
v3s16 spn = cam_pos_nodes + v3s16(0, 0, 0); v3s16 spn = cam_pos_nodes;
s16 bs2 = MAP_BLOCKSIZE / 2 + 1; s16 bs2 = MAP_BLOCKSIZE / 2 + 1;
u32 needed_count = 1; u32 needed_count = 1;
if (occlusion_culling_enabled && if (occlusion_culling_enabled &&
isOccluded(this, spn, cpn + v3s16(0, 0, 0), // For the central point of the mapblock 'endoff' can be halved
step, stepfac, startoff, endoff / 2, needed_count, nodemgr) && isOccluded(this, spn, cpn,
step, stepfac, startoff, endoff / 2.0f, needed_count, nodemgr) &&
isOccluded(this, spn, cpn + v3s16(bs2,bs2,bs2), isOccluded(this, spn, cpn + v3s16(bs2,bs2,bs2),
step, stepfac, startoff, endoff, needed_count, nodemgr) && step, stepfac, startoff, endoff, needed_count, nodemgr) &&
isOccluded(this, spn, cpn + v3s16(bs2,bs2,-bs2), isOccluded(this, spn, cpn + v3s16(bs2,bs2,-bs2),