diff --git a/src/mapnode.cpp b/src/mapnode.cpp index d835daba2..fd28910ff 100644 --- a/src/mapnode.cpp +++ b/src/mapnode.cpp @@ -658,7 +658,7 @@ void MapNode::serializeBulk(std::ostream &os, int version, const MapNode *nodes, u32 nodecount, u8 content_width, u8 params_width, bool compressed) { - if(!ser_ver_supported(version)) + if (!ser_ver_supported(version)) throw VersionMismatchException("ERROR: MapNode format not supported"); sanity_check(content_width == 2); @@ -666,38 +666,33 @@ void MapNode::serializeBulk(std::ostream &os, int version, // Can't do this anymore; we have 16-bit dynamically allocated node IDs // in memory; conversion just won't work in this direction. - if(version < 24) + if (version < 24) throw SerializationError("MapNode::serializeBulk: serialization to " "version < 24 not possible"); - SharedBuffer databuf(nodecount * (content_width + params_width)); + size_t databuf_size = nodecount * (content_width + params_width); + u8 *databuf = new u8[databuf_size]; + + u32 start1 = content_width * nodecount; + u32 start2 = (content_width + 1) * nodecount; // Serialize content - for(u32 i=0; i data, std::ostream &os, int level) +void compressZlib(const u8 *data, size_t data_size, std::ostream &os, int level) { z_stream z; const s32 bufsize = 16384; @@ -68,16 +68,16 @@ void compressZlib(SharedBuffer data, std::ostream &os, int level) ret = deflateInit(&z, level); if(ret != Z_OK) throw SerializationError("compressZlib: deflateInit failed"); - + // Point zlib to our input buffer z.next_in = (Bytef*)&data[0]; - z.avail_in = data.getSize(); + z.avail_in = data_size; // And get all output for(;;) { z.next_out = (Bytef*)output_buffer; z.avail_out = bufsize; - + status = deflate(&z, Z_FINISH); if(status == Z_NEED_DICT || status == Z_DATA_ERROR || status == Z_MEM_ERROR) @@ -98,8 +98,7 @@ void compressZlib(SharedBuffer data, std::ostream &os, int level) void compressZlib(const std::string &data, std::ostream &os, int level) { - SharedBuffer databuf((u8*)data.c_str(), data.size()); - compressZlib(databuf, os, level); + compressZlib((u8*)data.c_str(), data.size(), os, level); } void decompressZlib(std::istream &is, std::ostream &os) @@ -120,9 +119,9 @@ void decompressZlib(std::istream &is, std::ostream &os) ret = inflateInit(&z); if(ret != Z_OK) throw SerializationError("dcompressZlib: inflateInit failed"); - + z.avail_in = 0; - + //dstream<<"initial fail="< data, std::ostream &os, u8 version) +void compress(const SharedBuffer &data, std::ostream &os, u8 version) { if(version >= 11) { - compressZlib(data, os); + compressZlib(*data ,data.getSize(), os); return; } if(data.getSize() == 0) return; - + // Write length (u32) u8 tmp[4]; writeU32(tmp, data.getSize()); os.write((char*)tmp, 4); - + // We will be writing 8-bit pairs of more_count and byte u8 more_count = 0; u8 current_byte = data[0]; @@ -242,7 +241,7 @@ void decompress(std::istream &is, std::ostream &os, u8 version) u8 tmp[4]; is.read((char*)tmp, 4); u32 len = readU32(tmp); - + // We will be reading 8-bit pairs of more_count and byte u32 count = 0; for(;;) @@ -251,7 +250,7 @@ void decompress(std::istream &is, std::ostream &os, u8 version) u8 byte=0; is.read((char*)&more_count, 1); - + is.read((char*)&byte, 1); if(is.eof()) diff --git a/src/serialization.h b/src/serialization.h index c91c3241f..4e01db40a 100644 --- a/src/serialization.h +++ b/src/serialization.h @@ -86,12 +86,12 @@ inline bool ser_ver_supported(s32 v) { Misc. serialization functions */ -void compressZlib(SharedBuffer data, std::ostream &os, int level = -1); +void compressZlib(const u8 *data, size_t data_size, std::ostream &os, int level = -1); void compressZlib(const std::string &data, std::ostream &os, int level = -1); void decompressZlib(std::istream &is, std::ostream &os); // These choose between zlib and a self-made one according to version -void compress(SharedBuffer data, std::ostream &os, u8 version); +void compress(const SharedBuffer &data, std::ostream &os, u8 version); //void compress(const std::string &data, std::ostream &os, u8 version); void decompress(std::istream &is, std::ostream &os, u8 version);