From dd475d8af40c946caba674b617d1464f6c70b86b Mon Sep 17 00:00:00 2001
From: sfan5 <sfan5@live.de>
Date: Sun, 5 May 2024 22:29:50 +0200
Subject: [PATCH] Add benchmarks for server::ActiveObjectMgr

---
 src/benchmark/CMakeLists.txt                |   1 +
 src/benchmark/benchmark_activeobjectmgr.cpp | 111 ++++++++++++++++++++
 src/server/serveractiveobject.h             |   5 -
 3 files changed, 112 insertions(+), 5 deletions(-)
 create mode 100644 src/benchmark/benchmark_activeobjectmgr.cpp

diff --git a/src/benchmark/CMakeLists.txt b/src/benchmark/CMakeLists.txt
index a94f55da5..f79fcf1ef 100644
--- a/src/benchmark/CMakeLists.txt
+++ b/src/benchmark/CMakeLists.txt
@@ -1,5 +1,6 @@
 set (BENCHMARK_SRCS
 	${CMAKE_CURRENT_SOURCE_DIR}/benchmark.cpp
+	${CMAKE_CURRENT_SOURCE_DIR}/benchmark_activeobjectmgr.cpp
 	${CMAKE_CURRENT_SOURCE_DIR}/benchmark_lighting.cpp
 	${CMAKE_CURRENT_SOURCE_DIR}/benchmark_serialize.cpp
 	${CMAKE_CURRENT_SOURCE_DIR}/benchmark_mapblock.cpp
diff --git a/src/benchmark/benchmark_activeobjectmgr.cpp b/src/benchmark/benchmark_activeobjectmgr.cpp
new file mode 100644
index 000000000..a21137a68
--- /dev/null
+++ b/src/benchmark/benchmark_activeobjectmgr.cpp
@@ -0,0 +1,111 @@
+// Minetest
+// SPDX-License-Identifier: LGPL-2.1-or-later
+
+#include "benchmark_setup.h"
+#include "server/activeobjectmgr.h"
+#include "util/numeric.h"
+
+namespace {
+
+class TestObject : public ServerActiveObject {
+public:
+	TestObject(v3f pos) : ServerActiveObject(nullptr, pos)
+	{}
+
+	ActiveObjectType getType() const {
+		return ACTIVEOBJECT_TYPE_TEST;
+	}
+	bool getCollisionBox(aabb3f *toset) const {
+		return false;
+	}
+	bool getSelectionBox(aabb3f *toset) const {
+		return false;
+	}
+	bool collideWithObjects() const {
+		return true;
+	}
+};
+
+constexpr float POS_RANGE = 2001;
+
+inline v3f randpos()
+{
+	return v3f(myrand_range(-POS_RANGE, POS_RANGE),
+		myrand_range(-20, 60),
+		myrand_range(-POS_RANGE, POS_RANGE));
+}
+
+inline void fill(server::ActiveObjectMgr &mgr, size_t n)
+{
+	mgr.clear();
+	for (size_t i = 0; i < n; i++) {
+		auto obj = std::make_unique<TestObject>(randpos());
+		bool ok = mgr.registerObject(std::move(obj));
+		REQUIRE(ok);
+	}
+}
+
+}
+
+template <size_t N>
+void benchGetObjectsInsideRadius(Catch::Benchmark::Chronometer &meter)
+{
+	server::ActiveObjectMgr mgr;
+	size_t x;
+	std::vector<ServerActiveObject*> result;
+
+	auto cb = [&x] (ServerActiveObject *obj) -> bool {
+		x += obj->m_static_exists ? 0 : 1;
+		return false;
+	};
+	fill(mgr, N);
+	meter.measure([&] {
+		x = 0;
+		mgr.getObjectsInsideRadius(randpos(), 30.0f, result, cb);
+		return x;
+	});
+	REQUIRE(result.empty());
+
+	mgr.clear(); // implementation expects this
+}
+
+template <size_t N>
+void benchGetObjectsInArea(Catch::Benchmark::Chronometer &meter)
+{
+	server::ActiveObjectMgr mgr;
+	size_t x;
+	std::vector<ServerActiveObject*> result;
+
+	auto cb = [&x] (ServerActiveObject *obj) -> bool {
+		x += obj->m_static_exists ? 0 : 1;
+		return false;
+	};
+	fill(mgr, N);
+	meter.measure([&] {
+		x = 0;
+		v3f pos = randpos();
+		v3f off(50, 50, 50);
+		off[myrand_range(0, 2)] = 10;
+		mgr.getObjectsInArea({pos, pos + off}, result, cb);
+		return x;
+	});
+	REQUIRE(result.empty());
+
+	mgr.clear(); // implementation expects this
+}
+
+#define BENCH_INSIDE_RADIUS(_count) \
+	BENCHMARK_ADVANCED("inside_radius_" #_count)(Catch::Benchmark::Chronometer meter) \
+	{ benchGetObjectsInsideRadius<_count>(meter); };
+
+#define BENCH_IN_AREA(_count) \
+	BENCHMARK_ADVANCED("in_area_" #_count)(Catch::Benchmark::Chronometer meter) \
+	{ benchGetObjectsInArea<_count>(meter); };
+
+TEST_CASE("ActiveObjectMgr") {
+	BENCH_INSIDE_RADIUS(200)
+	BENCH_INSIDE_RADIUS(1450)
+
+	BENCH_IN_AREA(200)
+	BENCH_IN_AREA(1450)
+}
diff --git a/src/server/serveractiveobject.h b/src/server/serveractiveobject.h
index 4d620b768..2d09e34c1 100644
--- a/src/server/serveractiveobject.h
+++ b/src/server/serveractiveobject.h
@@ -73,11 +73,6 @@ public:
 	void markForRemoval();
 	void markForDeactivation();
 
-	// Create a certain type of ServerActiveObject
-	static ServerActiveObject* create(ActiveObjectType type,
-			ServerEnvironment *env, u16 id, v3f pos,
-			const std::string &data);
-
 	/*
 		Some simple getters/setters
 	*/