Previously, compiling on Ubuntu 20.04 would fail with the system-provided JsonCPP
version (1.7.4). Which would satisfy the documented requirement of "1.0.0+".
* Upgrade client active object mgr tests to Catch2
In addition to invoking Catch2's test runner after Minetest's homemade
runner, this refactors the tests to follow the DRY principle, and gives
them expressive names and clear assertions. Catch2 is already bundled
with Minetest, so there are no added dependencies.
* Increment failed modules count for Catch2 tests
* Respect --test-module option for Catch2 tests
* Improve Catch2 --test-module behavior
This switches infostream to rawstream so that test runner output is
displayed, and returns the correct boolean depending on the results. The
tests are now found by setting the configuration instead of invoking the
command line parser.
* Test uniqueness of all IDS instead of just one
Co-Authored-By: Lars Müller <appgurulars@gmx.de>
* Include Catch2 test run in timing and logging
* Flush std::cout after printing Catch results
* Increment total tests run instead of hardcoding to 1
* Flush stderr before printing to stdout
It's necessary to flush stderr before printing to stdout in adition to
flushing stdout before printing to stderr, to make sure all output is
ordered correctly.
* Make Catch write to rawstream
---------
Co-authored-by: Lars Müller <appgurulars@gmx.de>
Also remove the now useless options (like IRRLICHT_INCLUDE_DIR)
and update download instructions, CI and similar.
Co-authored-by: sfan5 <sfan5@live.de>
Linking to line numbers is brittle, linking to sections/headings is better.
If you still want to link to a line number, you can append ?plain=1 to GitHub's URL
This feature is enabled by default for non-Android release builds. Package
maintainers may use -DENABLE_UPDATE_CHECKER=0 to disable it.
Co-authored-by: rubenwardy <rw@rubenwardy.com>
Co-authored-by: sfan5 <sfan5@live.de>
Supporting these is not reasonable anymore and effectively we didn't
do that anyway, brokenness was only noticed by chance and a PR to restore
support for gcc 5.x is ready now.
