mirror of
https://github.com/minetest/minetest.git
synced 2024-11-24 00:23:46 +01:00
4338f100f8
Thanks to @netinetwalker for spotting the error, proposing a fix, and testing it. Error due to @est31's merging changes to PR #3202 to add more error reporting for invalid reply types, commit: 524a7656e3e5cd671b05c13e2ad69cb84bad0423 "redis: throw error if block request failed" Now we branch out on the valid reply type "not found".
185 lines
5.2 KiB
C++
185 lines
5.2 KiB
C++
/*
|
|
Minetest
|
|
Copyright (C) 2014 celeron55, Perttu Ahola <celeron55@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU Lesser General Public License as published by
|
|
the Free Software Foundation; either version 2.1 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public License along
|
|
with this program; if not, write to the Free Software Foundation, Inc.,
|
|
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#if USE_REDIS
|
|
|
|
#include "database-redis.h"
|
|
|
|
#include "settings.h"
|
|
#include "log.h"
|
|
#include "exceptions.h"
|
|
#include "util/string.h"
|
|
|
|
#include <hiredis.h>
|
|
#include <cassert>
|
|
|
|
|
|
Database_Redis::Database_Redis(Settings &conf)
|
|
{
|
|
std::string tmp;
|
|
try {
|
|
tmp = conf.get("redis_address");
|
|
hash = conf.get("redis_hash");
|
|
} catch (SettingNotFoundException) {
|
|
throw SettingNotFoundException("Set redis_address and "
|
|
"redis_hash in world.mt to use the redis backend");
|
|
}
|
|
const char *addr = tmp.c_str();
|
|
int port = conf.exists("redis_port") ? conf.getU16("redis_port") : 6379;
|
|
ctx = redisConnect(addr, port);
|
|
if (!ctx) {
|
|
throw FileNotGoodException("Cannot allocate redis context");
|
|
} else if (ctx->err) {
|
|
std::string err = std::string("Connection error: ") + ctx->errstr;
|
|
redisFree(ctx);
|
|
throw FileNotGoodException(err);
|
|
}
|
|
}
|
|
|
|
Database_Redis::~Database_Redis()
|
|
{
|
|
redisFree(ctx);
|
|
}
|
|
|
|
void Database_Redis::beginSave() {
|
|
redisReply *reply = static_cast<redisReply *>(redisCommand(ctx, "MULTI"));
|
|
if (!reply) {
|
|
throw FileNotGoodException(std::string(
|
|
"Redis command 'MULTI' failed: ") + ctx->errstr);
|
|
}
|
|
freeReplyObject(reply);
|
|
}
|
|
|
|
void Database_Redis::endSave() {
|
|
redisReply *reply = static_cast<redisReply *>(redisCommand(ctx, "EXEC"));
|
|
if (!reply) {
|
|
throw FileNotGoodException(std::string(
|
|
"Redis command 'EXEC' failed: ") + ctx->errstr);
|
|
}
|
|
freeReplyObject(reply);
|
|
}
|
|
|
|
bool Database_Redis::saveBlock(const v3s16 &pos, const std::string &data)
|
|
{
|
|
std::string tmp = i64tos(getBlockAsInteger(pos));
|
|
|
|
redisReply *reply = static_cast<redisReply *>(redisCommand(ctx, "HSET %s %s %b",
|
|
hash.c_str(), tmp.c_str(), data.c_str(), data.size()));
|
|
if (!reply) {
|
|
errorstream << "WARNING: saveBlock: redis command 'HSET' failed on "
|
|
"block " << PP(pos) << ": " << ctx->errstr << std::endl;
|
|
freeReplyObject(reply);
|
|
return false;
|
|
}
|
|
|
|
if (reply->type == REDIS_REPLY_ERROR) {
|
|
errorstream << "WARNING: saveBlock: saving block " << PP(pos)
|
|
<< " failed: " << reply->str << std::endl;
|
|
freeReplyObject(reply);
|
|
return false;
|
|
}
|
|
|
|
freeReplyObject(reply);
|
|
return true;
|
|
}
|
|
|
|
std::string Database_Redis::loadBlock(const v3s16 &pos)
|
|
{
|
|
std::string tmp = i64tos(getBlockAsInteger(pos));
|
|
redisReply *reply = static_cast<redisReply *>(redisCommand(ctx,
|
|
"HGET %s %s", hash.c_str(), tmp.c_str()));
|
|
|
|
if (!reply) {
|
|
throw FileNotGoodException(std::string(
|
|
"Redis command 'HGET %s %s' failed: ") + ctx->errstr);
|
|
}
|
|
switch (reply->type) {
|
|
case REDIS_REPLY_STRING: {
|
|
std::string str(reply->str, reply->len);
|
|
// std::string copies the memory so this won't cause any problems
|
|
freeReplyObject(reply);
|
|
return str;
|
|
}
|
|
case REDIS_REPLY_ERROR: {
|
|
std::string errstr = reply->str;
|
|
freeReplyObject(reply);
|
|
errorstream << "loadBlock: loading block " << PP(pos)
|
|
<< " failed: " << errstr << std::endl;
|
|
throw FileNotGoodException(std::string(
|
|
"Redis command 'HGET %s %s' errored: ") + errstr);
|
|
}
|
|
case REDIS_REPLY_NIL: {
|
|
// block not found in database
|
|
freeReplyObject(reply);
|
|
return "";
|
|
}
|
|
}
|
|
errorstream << "loadBlock: loading block " << PP(pos)
|
|
<< " returned invalid reply type " << reply->type
|
|
<< ": " << reply->str << std::endl;
|
|
freeReplyObject(reply);
|
|
throw FileNotGoodException(std::string(
|
|
"Redis command 'HGET %s %s' gave invalid reply."));
|
|
}
|
|
|
|
bool Database_Redis::deleteBlock(const v3s16 &pos)
|
|
{
|
|
std::string tmp = i64tos(getBlockAsInteger(pos));
|
|
|
|
redisReply *reply = static_cast<redisReply *>(redisCommand(ctx,
|
|
"HDEL %s %s", hash.c_str(), tmp.c_str()));
|
|
if (!reply) {
|
|
throw FileNotGoodException(std::string(
|
|
"Redis command 'HDEL %s %s' failed: ") + ctx->errstr);
|
|
} else if (reply->type == REDIS_REPLY_ERROR) {
|
|
errorstream << "WARNING: deleteBlock: deleting block " << PP(pos)
|
|
<< " failed: " << reply->str << std::endl;
|
|
freeReplyObject(reply);
|
|
return false;
|
|
}
|
|
|
|
freeReplyObject(reply);
|
|
return true;
|
|
}
|
|
|
|
void Database_Redis::listAllLoadableBlocks(std::vector<v3s16> &dst)
|
|
{
|
|
redisReply *reply = static_cast<redisReply *>(redisCommand(ctx, "HKEYS %s", hash.c_str()));
|
|
if (!reply) {
|
|
throw FileNotGoodException(std::string(
|
|
"Redis command 'HKEYS %s' failed: ") + ctx->errstr);
|
|
}
|
|
switch (reply->type) {
|
|
case REDIS_REPLY_ARRAY:
|
|
for (size_t i = 0; i < reply->elements; i++) {
|
|
assert(reply->element[i]->type == REDIS_REPLY_STRING);
|
|
dst.push_back(getIntegerAsBlock(stoi64(reply->element[i]->str)));
|
|
}
|
|
case REDIS_REPLY_ERROR:
|
|
throw FileNotGoodException(std::string(
|
|
"Failed to get keys from database: ") + reply->str);
|
|
}
|
|
freeReplyObject(reply);
|
|
}
|
|
|
|
#endif // USE_REDIS
|
|
|