mirror of
https://github.com/minetest/minetest.git
synced 2024-11-30 11:33:44 +01:00
03cc93f489
The code 'if [ -z ${something} ]; then ... fi' means "if
${something} is an empty string, yell at the command line
about 'binary operator expected' and ignore the body of the
if statement, if ${something} is not an empty string,
the condition is false so ignore the body of the if
statement" which clearly isn't what the author wanted. Fix
it by adding a few quotes around the offending ${something}.
46 lines
1.0 KiB
Bash
46 lines
1.0 KiB
Bash
#! /bin/bash
|
|
function perform_lint() {
|
|
echo "Performing LINT..."
|
|
if hash clang-format-5.0 2>/dev/null; then
|
|
CLANG_FORMAT=clang-format-5.0
|
|
else
|
|
CLANG_FORMAT=clang-format
|
|
fi
|
|
echo "LINT: Using binary $CLANG_FORMAT"
|
|
CLANG_FORMAT_WHITELIST="util/travis/clang-format-whitelist.txt"
|
|
|
|
files_to_lint="$(find src/ -name '*.cpp' -or -name '*.h')"
|
|
|
|
local errorcount=0
|
|
local fail=0
|
|
for f in ${files_to_lint}; do
|
|
d=$(diff -u "$f" <(${CLANG_FORMAT} "$f") || true)
|
|
|
|
if ! [ -z "$d" ]; then
|
|
whitelisted=$(awk '$1 == "'$f'" { print 1 }' "$CLANG_FORMAT_WHITELIST")
|
|
|
|
# If file is not whitelisted, mark a failure
|
|
if [ -z "${whitelisted}" ]; then
|
|
errorcount=$((errorcount+1))
|
|
|
|
printf "The file %s is not compliant with the coding style" "$f"
|
|
if [ ${errorcount} -gt 50 ]; then
|
|
printf "\nToo many errors encountered previously, this diff is hidden.\n"
|
|
else
|
|
printf ":\n%s\n" "$d"
|
|
fi
|
|
|
|
fail=1
|
|
fi
|
|
fi
|
|
done
|
|
|
|
if [ "$fail" = 1 ]; then
|
|
echo "LINT reports failure."
|
|
exit 1
|
|
fi
|
|
|
|
echo "LINT OK"
|
|
}
|
|
|