Mirrorlandia_minetest/playerfactions
1
0
Fork 0
mirror of https://github.com/mt-mods/playerfactions.git synced 2024-11-29 18:53:49 +01:00
Code Issues Projects Releases Wiki Activity

join: cleanup

Browse Source 
- don't call get_player_factions() unless needed
- use get_player_factions() instead of depricated get_player_faction()
- truth check of password in valid_password() for easier understanding
of code
- remove explicit nil check where not needed
This commit is contained in:
Luke aka SwissalpS 2024-09-15 05:14:11 +02:00
parent 86ba332441
commit d0520d2221
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
init.lua
View File

@ -149,7 +149,7 @@ function factions.hash_password(password)
end end
function factions.valid_password(fname, password) function factions.valid_password(fname, password)
if not facts[fname] then if not facts[fname] or not password then
return false return false
end end
return factions.hash_password(password) == facts[fname].password256 return factions.hash_password(password) == facts[fname].password256
@ -328,11 +328,11 @@ local function handle_command(name, param)
elseif action == "join" then elseif action == "join" then
local faction_name = params[2] local faction_name = params[2]
local password = params[3] local password = params[3]
if factions.get_player_faction(name) ~= nil and factions.mode_unique_faction then if factions.mode_unique_faction and factions.get_player_factions(name) then
return false, S("You are already in a faction.") return false, S("You are already in a faction.")
elseif not faction_name then elseif not faction_name then
return false, S("Missing faction name.") return false, S("Missing faction name.")
elseif facts[faction_name] == nil then elseif not facts[faction_name] then
return false, S("Faction @1 doesn't exist.", faction_name) return false, S("Faction @1 doesn't exist.", faction_name)
elseif not factions.valid_password(faction_name, password) then elseif not factions.valid_password(faction_name, password) then
return false, S("Permission denied: Wrong password.") return false, S("Permission denied: Wrong password.")