From fb32942625b8e9d385aaa3878159ffd562b61c21 Mon Sep 17 00:00:00 2001
From: y <y@y>
Date: Sun, 14 Jul 2019 00:30:18 +0100
Subject: [PATCH] prevent defect dummies when metadata is messed up

---
 tubelib/defect.lua | 31 ++++++++++++++++++++++---------
 1 file changed, 22 insertions(+), 9 deletions(-)

diff --git a/tubelib/defect.lua b/tubelib/defect.lua
index d0e5981..45e9bc2 100644
--- a/tubelib/defect.lua
+++ b/tubelib/defect.lua
@@ -13,6 +13,15 @@ minetest.register_node("tubelib:defect_dummy", {
 	is_ground_content = false,
 })
 
+local reported_machines = {}
+local function report(pos)
+	reported_machines[minetest.pos_to_string(pos)] = true
+end
+local function already_reported(pos)
+	local key = minetest.pos_to_string(pos)
+	return reported_machines[key]
+end
+
 
 function tubelib.data_not_corrupted(pos)	
 	if minetest.pos_to_string(pos) ~= minetest.get_meta(pos):get_string("my_pos") then
@@ -29,20 +38,24 @@ function tubelib.data_not_corrupted(pos)
 			number = meta:get_string("own_number")
 		end
 		if number == "" then
-			tubelib.remove_node(pos)
-			minetest.set_node(pos, {name = "tubelib:defect_dummy"})
-			meta:from_table(nil)
-			return false
+			if not already_reported(pos) then
+				minetest.log('error', ('[tubelib] machine @ %s has no number'):format(minetest.pos_to_string(pos)))
+				report(pos)
+			end
 		end
 		-- node moved?
 		local info = tubelib.get_node_info(number)
 		if not info or not vector.equals(info.pos, pos) then
-			tubelib.remove_node(pos)
-			minetest.set_node(pos, {name = "tubelib:defect_dummy"})
-			meta:from_table(nil)
-			return false
+			if not already_reported(pos) then
+				if not info then
+					minetest.log('error', ('[tubelib] machine @ %s has no info'):format(minetest.pos_to_string(pos)))
+				else
+					minetest.log('error', ('[tubelib] machine @ %s thinks it is at %s'):format(minetest.pos_to_string(pos), minetest.pos_to_string(info.pos)))
+				end
+				report(pos)
+			end
 		end
 		minetest.get_meta(pos):get_string("my_pos", minetest.pos_to_string(pos))
 	end
 	return true
-end
\ No newline at end of file
+end