From ef23033b2ca70cb98267a4468eabcbebf6902b3c Mon Sep 17 00:00:00 2001
From: Alain Bryden <2285037+alainbryden@users.noreply.github.com>
Date: Thu, 25 Nov 2021 23:06:13 -0400
Subject: [PATCH] #1773 - Fix duplicate file extensions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

For some time now, filenames have included the extension, so there's no need to append ".js" either on a single-file download or zip download.

While I was in the area, I also fixed .txt files in a folder - they had the same bug as scripts used to (appear in the zip as an underscore). I consolidated the code since it was the same for script files and text files.

I also added the ability to download *.js and *.ns (previously only supported *, *.script, and *.txt)

I also made the wildcard matching just a bit more flexible, so if someone really wanted to, they could go "download *blah.js" and get all scripts ending with that pattern ¯\_(ツ)_/¯
---
 src/Script/Script.ts              |  2 +-
 src/Terminal/commands/download.ts | 56 ++++++++++++-------------------
 2 files changed, 22 insertions(+), 36 deletions(-)

diff --git a/src/Script/Script.ts b/src/Script/Script.ts
index 9e201af88..62d71ede2 100644
--- a/src/Script/Script.ts
+++ b/src/Script/Script.ts
@@ -56,7 +56,7 @@ export class Script {
    * Download the script as a file
    */
   download(): void {
-    const filename = this.filename + ".js";
+    const filename = this.filename;
     const file = new Blob([this.code], { type: "text/plain" });
     const navigator = window.navigator as any;
     if (navigator.msSaveOrOpenBlob) {
diff --git a/src/Terminal/commands/download.ts b/src/Terminal/commands/download.ts
index b55f91165..cd40319ab 100644
--- a/src/Terminal/commands/download.ts
+++ b/src/Terminal/commands/download.ts
@@ -19,43 +19,29 @@ export function download(
       return;
     }
     const fn = args[0] + "";
-    if (fn === "*" || fn === "*.script" || fn === "*.txt") {
-      // Download all scripts as a zip
+    // If the parameter starts with *, download all files that match the wildcard pattern
+    if (fn.startsWith("*")) {
+      const matchEnding = fn.length == 1 || fn === "*.*" ? null : fn.slice(1); // Treat *.* the same as *
       const zip = new JSZip();
-      if (fn === "*" || fn === "*.script") {
-        for (let i = 0; i < server.scripts.length; ++i) {
-          const file = new Blob([server.scripts[i].code], {
-            type: "text/plain",
-          });
-          let name = server.scripts[i].filename;
-          if (name.startsWith("/")) {
-            name = name.slice(1);
-          }
-          zip.file(name + ".js", file);
+      // Helper function to zip any file contents whose name matches the pattern
+      let zipFiles = (fileNames: string[], fileContents: string[]) => {
+        for (let i = 0; i < fileContents.length; ++i) {
+          let name = fileNames[i];
+          if (name.startsWith("/")) name = name.slice(1);
+          if (!matchEnding || name.endsWith(matchEnding))
+            zip.file(name, new Blob([fileContents[i]], { type: "text/plain" }));
         }
-      }
-      if (fn === "*" || fn === "*.txt") {
-        for (let i = 0; i < server.textFiles.length; ++i) {
-          const file = new Blob([server.textFiles[i].text], {
-            type: "text/plain",
-          });
-          zip.file(server.textFiles[i].fn, file);
-        }
-      }
-
-      let zipFn = "";
-      switch (fn) {
-        case "*.script":
-          zipFn = "bitburnerScripts.zip";
-          break;
-        case "*.txt":
-          zipFn = "bitburnerTexts.zip";
-          break;
-        default:
-          zipFn = "bitburnerFiles.zip";
-          break;
-      }
-
+      };
+      // In the case of script files, we pull from the server.scripts array
+      if (!matchEnding || isScriptFilename(matchEnding))
+        zipFiles(server.scripts.map(s => s.filename), server.scripts.map(s => s.code));
+      // In the case of text files, we pull from the server.scripts array
+      if (!matchEnding || matchEnding.endsWith(".txt"))
+        zipFiles(server.textFiles.map(s => s.fn), server.textFiles.map(s => s.text));
+      // Return an error if no files matched, rather than an empty zip folder
+      if (Object.keys(zip.files).length == 0)
+        return terminal.error(`No files match the pattern ${fn}`);
+      const zipFn = `bitburner${isScriptFilename(fn) ? "Scripts" : fn === "*.txt" ? "Texts" : "Files"}.zip`;
       zip.generateAsync({ type: "blob" }).then((content: any) => FileSaver.saveAs(content, zipFn));
       return;
     } else if (isScriptFilename(fn)) {