Personal_mirrors/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2024-12-18 04:05:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

API: Allow passing 0 SkillPoints to skillMaxUpgradeCount (#1844)

Browse Source
This commit is contained in:
catloversg 2024-12-12 18:07:31 +07:00 committed by GitHub
parent 7c732689dd
commit 37ddb43b82
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
markdown/bitburner.bladeburnerformulas.skillmaxupgradecount.md
View File

@ -22,7 +22,7 @@ skillMaxUpgradeCount(
| --- | --- | --- |
| name | [BladeburnerSkillName](./bitburner.bladeburnerskillname.md) \| \`${[BladeburnerSkillName](./bitburner.bladeburnerskillname.md)<!-- -->}\` | Skill name. It's case-sensitive and must be an exact match. |
| level | number | Skill level. It must be a non-negative number. |
| skillPoints | number | Number of skill points to upgrade the skill. It must be a positive number. |
| skillPoints | number | Number of skill points to upgrade the skill. It must be a non-negative number. |
**Returns:**

15
src/NetscriptFunctions/Formulas.ts
View File

@ -52,6 +52,7 @@ import { getEnumHelper } from "../utils/EnumHelper";
import { CompanyPositions } from "../Company/CompanyPositions";
import { findCrime } from "../Crime/CrimeHelpers";
import { Skills } from "../Bladeburner/data/Skills";
import type { PositiveNumber } from "../types";
export function NetscriptFormulas(): InternalAPI<IFormulas> {
const checkFormulasAccess = function (ctx: NetscriptContext): void {
@ -433,15 +434,21 @@ export function NetscriptFormulas(): InternalAPI<IFormulas> {
checkFormulasAccess(ctx);
const name = getEnumHelper("BladeburnerSkillName").nsGetMember(ctx, _name, "name");
const level = helpers.number(ctx, "level", _level);
if (level < 0) {
throw new Error(`Level must be a non-negative number.`);
if (!Number.isFinite(level) || level < 0) {
throw new Error(`Level must be a finite, non-negative number. Its value is ${level}.`);
}
const skillPoints = helpers.number(ctx, "skillPoints", _skillPoints);
if (!Number.isFinite(skillPoints) || skillPoints < 0) {
throw new Error(`SkillPoints must be a finite, non-negative number. Its value is ${skillPoints}.`);
}
const skillPoints = helpers.positiveNumber(ctx, "skillPoints", _skillPoints);
const skill = Skills[name];
if (level >= skill.maxLvl) {
return 0;
}
return skill.calculateMaxUpgradeCount(level, skillPoints);
if (skillPoints === 0) {
return 0;
}
return skill.calculateMaxUpgradeCount(level, skillPoints as PositiveNumber);
},
},
};

2
src/ScriptEditor/NetscriptDefinitions.d.ts vendored
View File

@ -5419,7 +5419,7 @@ interface BladeburnerFormulas {
*
* @param name - Skill name. It's case-sensitive and must be an exact match.
* @param level - Skill level. It must be a non-negative number.
* @param skillPoints - Number of skill points to upgrade the skill. It must be a positive number.
* @param skillPoints - Number of skill points to upgrade the skill. It must be a non-negative number.
* @returns Number of times that you can upgrade the skill.
*/
skillMaxUpgradeCount(