From 538a440b7e47ed28873f67ee2db01f91bd49d791 Mon Sep 17 00:00:00 2001
From: TheMas3212 <mas3212@gmail.com>
Date: Wed, 5 Jan 2022 21:36:09 +1100
Subject: [PATCH] Fixes #1860 donate to gang faction possible via singularity
 also fixes bug i found while testing this where its possible to donate to a
 faction you arent a member of

---
 src/NetscriptFunctions/Singularity.ts | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/NetscriptFunctions/Singularity.ts b/src/NetscriptFunctions/Singularity.ts
index e903c7dc6..9e03e6efa 100644
--- a/src/NetscriptFunctions/Singularity.ts
+++ b/src/NetscriptFunctions/Singularity.ts
@@ -1175,7 +1175,20 @@ export function NetscriptSingularity(
       helper.updateDynamicRam("donateToFaction", getRamCost(player, "donateToFaction"));
       helper.checkSingularityAccess("donateToFaction");
       const faction = getFaction("donateToFaction", name);
-
+      if (!player.factions.includes(faction.name)) {
+        workerScript.log(
+          "donateToFaction",
+          () => `You can't donate to '${name}' because you aren't a member`,
+        );
+        return false;
+      }
+      if (faction.name === player.getGangFaction().name) {
+        workerScript.log(
+          "donateToFaction",
+          () => `You can't donate to '${name}' because youre managing a gang for it`,
+        );
+        return false;
+      }
       if (typeof amt !== "number" || amt <= 0) {
         workerScript.log("donateToFaction", () => `Invalid donation amount: '${amt}'.`);
         return false;