Personal_mirrors/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2024-11-22 23:53:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Prevent external files to be opened by electron

Browse Source
This commit is contained in:
Martin Fournier 2022-01-11 10:52:14 -05:00
parent f742782e4a
commit 63413a646a
1 changed files with 49 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
electron/gameWindow.js
View File

@ -6,6 +6,9 @@ const achievements = require("./achievements");
const menu = require("./menu"); const menu = require("./menu");
const api = require("./api-server"); const api = require("./api-server");
const cp = require("child_process"); const cp = require("child_process");
const path = require("path");
const fs = require("fs");
const { fileURLToPath } = require("url");
const debug = process.argv.includes("--debug"); const debug = process.argv.includes("--debug");
@ -24,15 +27,54 @@ async function createWindow(killall) {
window.show(); window.show();
if (debug) window.webContents.openDevTools(); if (debug) window.webContents.openDevTools();
window.webContents.on("new-window", function (e, url) { window.webContents.on("new-window", async function (e, url) {
if (process.platform === "win32") { // Let's make sure sure we have a proper url
cp.spawn("explorer", [url], { detached: true, stdio: "ignore" }); let parsedUrl
} else { try {
// make sure local urls stay in electron perimeter parsedUrl = new URL(url);
if (url.substr(0, "file://".length) === "file://") { } catch (_) {
return; // This is an invalid url, let's just do nothing
log.warn(`Invalid url found: ${url}`)
e.preventDefault();
return;
}
// make sure local urls stay in electron perimeter
if (url.substr(0, "file://".length) === "file://") {
const requestedPath = fileURLToPath(url);
const appPath = path.parse(app.getAppPath());
const filePath = path.parse(requestedPath);
const isChild = filePath.dir.startsWith(appPath.dir);
// eslint-disable-next-line no-sync
const fileExists = fs.existsSync(requestedPath);
if (!isChild) {
// If we're not relative to our app's path let's abort
log.warn(`Requested path ${filePath.dir}${path.sep}${filePath.base} is not relative to the app: ${appPath.dir}${path.sep}${appPath.base}`)
e.preventDefault();
} else if (!fileExists) {
// If the file does not exist let's abort
log.warn(`Requested path ${filePath.dir}${path.sep}${filePath.base} does not exist`)
e.preventDefault();
} }
return;
}
if (process.platform === "win32") {
// If we have parameters in the URL, explorer.exe won't register the URL and will open the file explorer instead.
let urlToOpen = parsedUrl.toString();
if (parsedUrl.search) {
log.log(`Cannot open a path with parameters: ${parsedUrl.search}`);
urlToOpen = urlToOpen.replace(parsedUrl.search, '');
// It would be possible to launch an URL with parameter using this, but it would mess up the process again...
// const escapedUri = parsedUrl.href.replace('&', '^&');
// cp.spawn("cmd.exe", ["/c", "start", escapedUri], { detached: true, stdio: "ignore" });
}
cp.spawn("explorer", [urlToOpen], { detached: true, stdio: "ignore" });
} else {
// and open every other protocols on the browser // and open every other protocols on the browser
utils.openExternal(url); utils.openExternal(url);
} }