[refactor] Moved 'removeElementById' to its own TS file

src/Bladeburner.js

@@ -14,7 +14,7 @@ import {dialogBoxCreate}                            from "../utils/DialogBox";
 import {addOffset, clearObject,
         removeChildrenFromElement,
         appendLineBreaks,
-        removeElementById, removeElement}           from "../utils/HelperFunctions";
+        removeElement}                              from "../utils/HelperFunctions";
 import {Reviver, Generic_toJSON,
         Generic_fromJSON}                           from "../utils/JSONReviver";
 import numeral                                      from "numeral/min/numeral.min";
@@ -23,6 +23,7 @@ import {createPopup}                                from "../utils/uiHelpers/cre
 import {exceptionAlert}                             from "../utils/helpers/exceptionAlert";
 import {formatNumber}                               from "../utils/StringHelperFunctions";
 import {getRandomInt}                               from "../utils/helpers/getRandomInt";
+import {removeElementById}                          from "../utils/uiHelpers/removeElementById";
 
 
 var CityNames = ["Aevum", "Chongqing", "Sector-12", "New Tokyo", "Ishima", "Volhaven"];

src/CompanyManagement.js

@@ -7,9 +7,7 @@ import {Player}                                         from "./Player";
 
 import Decimal                                          from "decimal.js";
 import {dialogBoxCreate}                                from "../utils/DialogBox";
-import {removeElementById,
+import {removeChildrenFromElement,
-        createAccordionElement,
-        removeChildrenFromElement,
         clearSelector}                                  from "../utils/HelperFunctions";
 import {Reviver, Generic_toJSON,
         Generic_fromJSON}                               from "../utils/JSONReviver";
@@ -19,6 +17,7 @@ import {createPopup}                                    from "../utils/uiHelpers
 import {formatNumber, generateRandomString}             from "../utils/StringHelperFunctions";
 import {getRandomInt}                                   from "../utils/helpers/getRandomInt";
 import {isString}                                       from "../utils/helpers/isString";
+import {removeElementById}                              from "../utils/uiHelpers/removeElementById";
 import {yesNoBoxCreate, yesNoTxtInpBoxCreate,
         yesNoBoxGetYesButton, yesNoBoxGetNoButton,
         yesNoTxtInpBoxGetYesButton, yesNoTxtInpBoxGetNoButton,

src/Gang.js

@@ -8,12 +8,13 @@ import {Reviver, Generic_toJSON,
         Generic_fromJSON}                       from "../utils/JSONReviver";
 import {removeChildrenFromElement,
         createAccordionElement,
-        removeElementById, removeElement}       from "../utils/HelperFunctions";
+        removeElement}                          from "../utils/HelperFunctions";
 import {createElement}                          from "../utils/uiHelpers/createElement";
 import {createPopup}                            from "../utils/uiHelpers/createPopup";
 import  numeral                                 from "numeral/min/numeral.min";
 import {formatNumber}                           from "../utils/StringHelperFunctions";
 import {getRandomInt}                           from "../utils/helpers/getRandomInt";
+import {removeElementById}                      from "../utils/uiHelpers/removeElementById";
 import {yesNoBoxCreate, yesNoTxtInpBoxCreate,
         yesNoBoxGetYesButton, yesNoBoxGetNoButton,
         yesNoTxtInpBoxGetYesButton, yesNoTxtInpBoxGetNoButton,

src/Prestige.js

@@ -30,7 +30,7 @@ import {initStockMarket, initSymbolToStockMap,
 import {Terminal, postNetburnerText}            from "./Terminal";
 import Decimal                                  from "decimal.js";
 import {dialogBoxCreate}                        from "../utils/DialogBox";
-import {removeElementById}                      from "../utils/HelperFunctions";
+import {removeElementById}                      from "../utils/uiHelpers/removeElementById";
 import {createElement}                          from "../utils/uiHelpers/createElement";
 import {createPopup}                            from "../utils/uiHelpers/createPopup";
 import {exceptionAlert}                         from "../utils/helpers/exceptionAlert";

src/SaveObject.js

@@ -19,12 +19,13 @@ import {loadSpecialServerIps, SpecialServerIps} from "./SpecialServerIps";
 import {loadStockMarket, StockMarket}           from "./StockMarket";
 import {dialogBoxCreate}                        from "../utils/DialogBox";
 import {gameOptionsBoxClose}                    from "../utils/GameOptions";
-import {clearEventListeners, removeElementById} from "../utils/HelperFunctions";
+import {clearEventListeners}                    from "../utils/HelperFunctions";
 import {Reviver, Generic_toJSON,
         Generic_fromJSON}                       from "../utils/JSONReviver";
 import {createElement}                          from "../utils/uiHelpers/createElement";
 import {createPopup}                            from "../utils/uiHelpers/createPopup";
 import {formatNumber}                           from "../utils/StringHelperFunctions";
+import {removeElementById}                      from "../utils/uiHelpers/removeElementById";
 
 import Decimal                                  from "decimal.js";
 

src/StockMarket.js

@@ -7,13 +7,13 @@ import {Player}                                 from "./Player";
 
 import {dialogBoxCreate}                        from "../utils/DialogBox";
 import {clearEventListeners,
-        removeElementById,
         clearEventListenersEl}                  from "../utils/HelperFunctions";
 import {Reviver, Generic_toJSON,
         Generic_fromJSON}                       from "../utils/JSONReviver";
 import numeral                                  from "numeral/min/numeral.min";
 import {formatNumber}                           from "../utils/StringHelperFunctions";
 import {getRandomInt}                           from "../utils/helpers/getRandomInt";
+import {removeElementById}                      from "../utils/uiHelpers/removeElementById";
 import {yesNoBoxCreate, yesNoTxtInpBoxCreate,
         yesNoBoxGetYesButton, yesNoBoxGetNoButton,
         yesNoTxtInpBoxGetYesButton, yesNoTxtInpBoxGetNoButton,

utils/HelperFunctions.js

@@ -48,14 +48,6 @@ function clearEventListenersEl(el) {
     return newElem;
 }
 
-//Given its id, this function removes an element AND its children
-function removeElementById(id) {
-    var elem = document.getElementById(id);
-    if (elem == null) {return;}
-    while(elem.firstChild) {elem.removeChild(elem.firstChild);}
-    elem.parentNode.removeChild(elem);
-}
-
 function removeElement(elem) {
     if (elem == null || !(elem instanceof Element)) {return;}
     while(elem.firstChild) {elem.removeChild(elem.firstChild);}
@@ -147,7 +139,6 @@ export {sizeOfObject,
         printArray,
         powerOfTwo,
         clearEventListenersEl,
-        removeElementById,
         removeElement,
         createAccordionElement,
         appendLineBreaks,

utils/uiHelpers/removeElementById.ts

@@ -0,0 +1,21 @@
+import { getElementById } from "./getElementById";
+
+//
+/**
+ * Given its id, this function removes an element AND its children
+ * @param id The HTML identifier to search for and remove.
+ */
+export function removeElementById(id: string) {
+    try {
+        const elem: HTMLElement = getElementById(id);
+        while (elem.firstChild) {
+            elem.removeChild(elem.firstChild);
+        }
+
+        if (elem.parentNode) {
+            elem.parentNode.removeChild(elem);
+        }
+    } catch (e) {
+        // Probably should log this as we're trying to remove elements that don't exist.
+    }
+}