From e05617d9d3104de63f34c1c41a0a25b8e466f53b Mon Sep 17 00:00:00 2001
From: borisflagell <clement.delrue@gmail.com>
Date: Wed, 20 Apr 2022 23:03:25 +0200
Subject: [PATCH] UI FIX #3415

fixes #3415
---
 src/Faction/ui/FactionRoot.tsx                | 32 +++++++++++++++----
 src/PersonObjects/IPlayer.ts                  |  1 +
 src/PersonObjects/Player/PlayerObject.ts      |  2 ++
 .../Player/PlayerObjectGangMethods.ts         |  7 ++++
 4 files changed, 35 insertions(+), 7 deletions(-)

diff --git a/src/Faction/ui/FactionRoot.tsx b/src/Faction/ui/FactionRoot.tsx
index 151d58687..836a9ae51 100644
--- a/src/Faction/ui/FactionRoot.tsx
+++ b/src/Faction/ui/FactionRoot.tsx
@@ -18,8 +18,7 @@ import { Faction } from "../Faction";
 import { use } from "../../ui/Context";
 import { CreateGangModal } from "./CreateGangModal";
 
-import Typography from "@mui/material/Typography";
-import Button from "@mui/material/Button";
+import { Box, Paper, Typography, Button, Tooltip } from "@mui/material";
 import { CovenantPurchasesRoot } from "../../PersonObjects/Sleeve/ui/CovenantPurchasesRoot";
 import { FactionNames } from "../data/FactionNames";
 import { GangConstants } from "../../Gang/data/Constants";
@@ -105,12 +104,17 @@ function MainPage({ faction, rerender, onAugmentations }: IMainProps): React.Rea
 
   const canPurchaseSleeves = faction.name === FactionNames.TheCovenant && player.bitNodeN === 10;
 
-  let canAccessGang = player.canAccessGang() && GangConstants.Names.includes(faction.name);
+  // Note : For future-proofing sake, an assumption is made that player is intended to retain access to his gang if his karma were to somehow increases. 
+  let isManageGangVisible = GangConstants.Names.includes(faction.name) && player.isAwareOfGang();
+  // karma threshold is only checked at that point, via canAccessGang(). No further check is made.
+  let isManageGangClickable = player.canAccessGang();
   if (player.inGang()) {
     if (player.getGangName() !== faction.name) {
-      canAccessGang = false;
+      isManageGangVisible = false;
     } else if (player.getGangName() === faction.name) {
-      canAccessGang = true;
+      isManageGangVisible = true;
+      // The following line will enable the button, without checking for karma threshold.
+      isManageGangClickable = true;
     }
   }
 
@@ -121,9 +125,23 @@ function MainPage({ faction, rerender, onAugmentations }: IMainProps): React.Rea
         {faction.name}
       </Typography>
       <Info faction={faction} factionInfo={factionInfo} />
-      {canAccessGang && (
+      {isManageGangVisible && (
         <>
-          <Option buttonText={"Manage Gang"} infoText={gangInfo} onClick={manageGang} />
+          <Box>
+              <Paper sx={{ my: 1, p: 1 }}>
+                <Tooltip
+                  title={
+                  !isManageGangClickable ? <Typography>Unlocked when reaching -54000 karma</Typography> : ""
+                  }
+                >
+                  <span>
+                    <Button onClick={manageGang} disabled={!isManageGangClickable}>{"Manage Gang"}</Button>
+                    <Typography>{gangInfo}</Typography>
+                  </span>
+              </Tooltip>
+              </Paper>
+          </Box>
+  
           <CreateGangModal facName={faction.name} open={gangOpen} onClose={() => setGangOpen(false)} />
         </>
       )}
diff --git a/src/PersonObjects/IPlayer.ts b/src/PersonObjects/IPlayer.ts
index ca1f2940a..1341e8c33 100644
--- a/src/PersonObjects/IPlayer.ts
+++ b/src/PersonObjects/IPlayer.ts
@@ -208,6 +208,7 @@ export interface IPlayer {
   hasProgram(program: string): boolean;
   inBladeburner(): boolean;
   inGang(): boolean;
+  isAwareOfGang(): boolean;
   isQualified(company: Company, position: CompanyPosition): boolean;
   loseMoney(money: number, source: string): void;
   process(router: IRouter, numCycles?: number): void;
diff --git a/src/PersonObjects/Player/PlayerObject.ts b/src/PersonObjects/Player/PlayerObject.ts
index 72d15e3c1..b61c3b72c 100644
--- a/src/PersonObjects/Player/PlayerObject.ts
+++ b/src/PersonObjects/Player/PlayerObject.ts
@@ -218,6 +218,7 @@ export class PlayerObject implements IPlayer {
   hasProgram: (program: string) => boolean;
   inBladeburner: () => boolean;
   inGang: () => boolean;
+  isAwareOfGang: () => boolean;
   isQualified: (company: Company, position: CompanyPosition) => boolean;
   loseMoney: (money: number, source: string) => void;
   reapplyAllAugmentations: (resetMultipliers?: boolean) => void;
@@ -604,6 +605,7 @@ export class PlayerObject implements IPlayer {
     this.hasCorporation = corporationMethods.hasCorporation;
     this.startCorporation = corporationMethods.startCorporation;
     this.canAccessGang = gangMethods.canAccessGang;
+    this.isAwareOfGang = gangMethods.isAwareOfGang;
     this.getGangFaction = gangMethods.getGangFaction;
     this.getGangName = gangMethods.getGangName;
     this.hasGangWith = gangMethods.hasGangWith;
diff --git a/src/PersonObjects/Player/PlayerObjectGangMethods.ts b/src/PersonObjects/Player/PlayerObjectGangMethods.ts
index b9c781fb2..5d070b62e 100644
--- a/src/PersonObjects/Player/PlayerObjectGangMethods.ts
+++ b/src/PersonObjects/Player/PlayerObjectGangMethods.ts
@@ -17,6 +17,13 @@ export function canAccessGang(this: IPlayer): boolean {
   return this.karma <= GangKarmaRequirement;
 }
 
+export function isAwareOfGang(this: IPlayer): boolean {
+  if (this.bitNodeN === 2 || this.sourceFileLvl(2) >= 1) {
+    return true;
+  }
+  return false;
+}
+
 export function getGangFaction(this: IPlayer): Faction {
   const gang = this.gang;
   if (gang === null) {