BUGFIX: Wrong success range of Bladeburner general action (#1552)

This commit is contained in:
catloversg 2024-08-09 07:37:22 +07:00 committed by GitHub
parent 75cacc36bc
commit ed01fb8e9e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions

@ -4,6 +4,7 @@ import type { ActionIdentifier } from "../Types";
import { BladeActionType, BladeGeneralActionName } from "@enums";
import { ActionClass, ActionParams } from "./Action";
import { clampNumber } from "../../utils/helpers/clampNumber";
type GeneralActionParams = ActionParams & {
name: BladeGeneralActionName;
@ -28,8 +29,9 @@ export class GeneralAction extends ActionClass {
getSuccessChance(__bladeburner: Bladeburner, __person: Person): number {
return 1;
}
getSuccessRange(bladeburner: Bladeburner, person: Person): [minChance: number, maxChance: number] {
const chance = this.getSuccessChance(bladeburner, person);
const chance = clampNumber(this.getSuccessChance(bladeburner, person), 0, 1);
return [chance, chance];
}
}

@ -129,7 +129,6 @@ export function NetscriptBladeburner(): InternalAPI<INetscriptBladeburner> {
checkSleeveNumber(ctx, sleeveNumber);
switch (action.type) {
case BladeActionType.general:
return [1, 1];
case BladeActionType.contract: {
const sleevePerson = Player.sleeves[sleeveNumber];
return action.getSuccessRange(bladeburner, sleevePerson);