BRNSystems/irrlicht
1
0
Fork 0
forked from Mirrorlandia_minetest/irrlicht
Code Pull Requests Activity
538e3ab353
irrlicht/tests
History
cutealien e57a713377 Fix some bitfield sizes in SMaterial 
Bitfields for PolygonOffsetDirection, ZWriteEnable and BlendOperation were chosen too small.
As we have pre c++11 code and therefore didn't use unsigned qualifiers for enums they were generally signed (up to compiler in theory, but I think they all choose signed).
Which means the bitfield also had a sign. 
So for example setting PolygonOffsetDirection to EPO_FRONT set it to -1 instead of 1.
Which then would fail with comparison checks (PolygonOffsetDirection == EPO_FRONT would be false).
We kind of got lucky that we usually not checked for the last enum inside Irrlicht, so it worked to due being the "else" case.
Or in the ZWriteEnable case the last one was identical to the default return value so it also worked accidentally.
But obviously still wrong and user code could be messed up.

While at it I also re-ordered SMaterial variable so most bitfield variables are close together again to give compiler at least a chance to use packing. Thought at least in my quick debug compile test it didn't seem to use any packing (but maybe on other compilers).

git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@6440 dfc29bdd-3216-0410-991c-e03cc46cb475
2022-11-17 16:42:39 +00:00
..
empty/empty Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
media Add option to allow nodes to ignore the scale/rotation parts of their parents transformation. 2022-09-29 16:34:37 +00:00
2dmaterial.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
anti-aliasing.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
archiveReader.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
b3dAnimation.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
billboards.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
burningsVideo.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
collisionResponseAnimator.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
color.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
coreutil.cpp API BREAKER: Replacing defines in irrTypes.h which are conflicting with c++ reserved identifier rules. 2021-08-27 12:55:10 +00:00
createImage.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
cursorSetVisible.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
disambiguateTextures.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
draw2DImage.cpp burning v0.53 2022-04-30 22:57:17 +00:00
drawPixel.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
drawRectOutline.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
drawVertexPrimitive.cpp burning v0.53 2022-04-30 22:57:17 +00:00
enumerateImageManipulators.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
exports.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
fast_atof.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
filesystem.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
flyCircleAnimator.cpp Burningsvideo 0.52 2020-11-10 18:49:39 +00:00
guiDisabledMenu.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
ioScene.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
irrArray.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
irrCoreEquals.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
irrList.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
irrMap.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
irrString.cpp Update irrString test due to split changes in r6007 2019-12-16 16:51:30 +00:00
lightMaps.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
lights.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
line2d.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
loadTextures.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
main.cpp Fix some problems with CMatrix4::getRotationDegrees 2022-10-15 15:46:03 +00:00
makeColorKeyTexture.cpp Replace more getSize() with getOriginalSize() calls in tests. 2022-03-30 21:52:26 +00:00
Makefile Stop linking to libs which the tests Makefile does not seem to need 2022-03-28 22:11:26 +00:00
material.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
matrixOps.cpp Fix some problems with CMatrix4::getRotationDegrees 2022-10-15 15:46:03 +00:00
md2Animation.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
meshLoaders.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
meshTransform.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
mrt.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
orthoCam.cpp Slow down switching drivers in orthoCam test. 2022-03-28 19:52:00 +00:00
planeMatrix.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
projectionMatrix.cpp Material.ZWriteEnable is now of type E_ZWRITE instead of bool and ZWriteFineControl get removed (or merged into ZWriteEnable). 2020-01-02 15:34:52 +00:00
removeCustomAnimator.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
renderTargetTexture.cpp Replace more getSize() with getOriginalSize() calls in tests. 2022-03-30 21:52:26 +00:00
sceneCollisionManager.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
sceneNodeAnimator.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
screenshot.cpp Print out colorformat when screenshot test fails 2022-03-30 16:54:46 +00:00
serializeAttributes.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
skinnedMesh.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
softwareDevice.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
stencilshadow.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
terrainSceneNode.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
testaabbox.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
testDimension2d.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
testGeometryCreator.cpp Relax test a bit. Minor example cleanup. 2022-01-22 16:42:12 +00:00
testLine2d.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
testQuaternion.cpp Use f64 version of reciprocal_squareroot in quaternion::normalize for more precision. 2020-01-03 17:09:39 +00:00
tests_vc10.sln Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
tests_vc10.vcxproj Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
tests_vc11.sln Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
tests_vc11.vcxproj Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
tests_vc12.sln Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
tests_vc12.vcxproj Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
tests_vc14.sln Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
tests_vc14.vcxproj Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
tests_vc16.sln vs2019 projectfiles 2022-05-03 20:48:57 +00:00
tests_vc16.vcxproj vs2019 projectfiles 2022-05-03 20:48:57 +00:00
tests-last-passed-at.txt Fix some bitfield sizes in SMaterial 2022-11-17 16:42:39 +00:00
tests-readme.txt Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
tests.cbp Slow down switching drivers in orthoCam test. 2022-03-28 19:52:00 +00:00
tests.workspace Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
testS3DVertex.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
testUtils.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
testUtils.h Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
testVector2d.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
testVector3d.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
testXML.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
textureFeatures.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
textureRenderStates.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
timer.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
transparentMaterials.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
triangle3d.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
triangleSelector.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
userClipPlane.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
vectorPositionDimension2d.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
videoDriver.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
viewPort.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00
writeImageToFile.cpp Avoid warning and make local variable lower-case. 2019-12-12 16:32:41 +00:00