Fix luacheck findings, force failure when make vl_scheduler's init.lua and queue.lua don't check properly

.luacheckrc

@@ -40,10 +40,11 @@ read_globals = {
 		fields = {
 			"hypot",
 			"sign",
-			"factorial"
+			"factorial",
+			"round"
 		}
 	},
-	------
+
 	--MODS
 	------
 

mods/CORE/vl_scheduler/init.lua

@@ -91,7 +91,7 @@ local function serialize_task(task, time)
 		name = task.name,
 		args = task.args,
 		time = 0,
-		priority = i,
+		priority = task.priority,
 	}
 end
 function vl_scheduler.save()
@@ -105,7 +105,7 @@ function vl_scheduler.save()
 		local iter = run_queue[i]
 		while iter do
 			if iter.name then
-				storage:set_string("task_"..sequence.."_"..task_count, serialize_task(task, 0))
+				storage:set_string("task_"..sequence.."_"..task_count, serialize_task(iter, 0))
 				task_count = task_count + 1
 			end
 			iter = iter.next
@@ -135,7 +135,6 @@ function vl_scheduler.load()
 	local keys = storage:get_keys()
 	for _,key in ipairs(keys) do
 		if key:sub(0,11) == "task_count_" and key ~= "task_count_"..sequence then
-			local old_sequence = tonumber(key:sub(12))
 			local task_count = storage:get_int(key)
 
 			-- Delete all the old task data

mods/CORE/vl_scheduler/queue.lua

@@ -7,7 +7,7 @@
 ---@field last amt_queue.Item?
 
 local one_over_log2 = 1.0 / math.log(2)
-function bit.lsb(v)
+local function bit_lsb(v)
 	local k = bit.band(v, bit.bnot(v-1))
 	return math.log(k) * one_over_log2
 end
@@ -143,9 +143,9 @@ amt_queue.items = items
 function amt_queue.advance_to_next(self)
 	if self.mask == 0 then return end
 
-	local level = bit.lsb(self.mask) + 1
+	local level = bit_lsb(self.mask) + 1
 	local level_table = self[level] or dummy
-	level_table.rotate = bit.lsb(level_table.mask)
+	level_table.rotate = bit_lsb(level_table.mask)
 
 	for i = (level-1),1,-1 do
 		level_table = self[i]
@@ -156,7 +156,7 @@ function amt_queue.advance_to_next(self)
 		end
 		local new_level_table = pop_from_level(self, i+1)
 		if new_level_table then
-			new_level_table.rotate = bit.lsb(new_level_table.mask)
+			new_level_table.rotate = bit_lsb(new_level_table.mask)
 		end
 		self[i] = new_level_table
 	end

tests/luacheck/check.lst

@@ -17,7 +17,9 @@
 ./mods/CORE/tga_encoder/colormap_generator.lua
 ./mods/CORE/tga_encoder/donut.lua
 ./mods/CORE/tga_encoder/examples.lua
-./mods/CORE/tga_encoder/logo.lua
+./mods/CORE/tga_encoder/logo.luaa
+./mods/CORE/vl_scheduler/init.lua
+./mods/CORE/vl_scheduler/queue.lua
 ./mods/CORE/vl_trusted/init.lua
 ./mods/ENTITIES/mcl_burning/init.lua
 ./mods/ENTITIES/mcl_dripping/init.lua