MineClone2/mods/ITEMS
𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 a620d24ec8 Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914)
Fixes: #3913 #3915

~~You can reproduce the crash by placing a fish bucket on top snow above an unknown node.

I also noticed that the code always uses pointed_thing.above so I fixed that and also added a function to mcl_utils to figure out where a node should be placed (either above or below). Looks like the rest of the code could also use improvement but at least it does not crash now.~~

Cora fixed a bunch of related crashes in Mineclona so I am replacing my commit and cherry picking all her commits here.
https://codeberg.org/mineclonia/mineclonia/pulls/549

Here is the list of fixes from that PR:
- Crash when placing snow layer on unknown nodes
- Crash when snow layers on unknown nodes are flooded
- Crash when placing fishbucket on snow on top of unknown nodes
- Crash when placing chorus flower and stem on unknown
- Crash when placing mob spawners on unknown
- The fishbucket on place to actually replace buildable_to

Co-authored-by: cora <coradelamouche@gmx.ch>
Reviewed-on: https://git.minetest.land/MineClone2/MineClone2/pulls/3914
Reviewed-by: ancientmarinerdev <ancientmariner_dev@proton.me>
Co-authored-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
Co-committed-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
2023-09-29 18:47:07 +00:00
..
mcl_amethyst Update russian translation 2023-08-31 14:16:42 +08:00
mcl_anvils Update Russian translation. Fix 1. 2023-09-02 15:51:49 +08:00
mcl_armor Update russian translation 2023-08-31 14:16:42 +08:00
mcl_armor_stand Update russian translation 2023-08-31 14:16:42 +08:00
mcl_bamboo Extra checks placed in. 2023-09-26 18:35:12 +00:00
mcl_banners Merge pull request 'Update Russian translation' (#3896) from Nanashi_Mumei/MineClone2:master into master 2023-09-02 08:25:43 +00:00
mcl_barrels Merge pull request 'Update Russian translation' (#3896) from Nanashi_Mumei/MineClone2:master into master 2023-09-02 08:25:43 +00:00
mcl_beacons Russian translation (#3842) 2023-07-22 20:17:33 +00:00
mcl_beds Update russian translation 2023-08-31 14:16:42 +08:00
mcl_beehives Update russian translation 2023-08-31 14:16:42 +08:00
mcl_bells Update russian translation 2023-08-31 14:16:42 +08:00
mcl_blackstone Update russian translation 2023-08-31 14:16:42 +08:00
mcl_blast_furnace Update russian translation 2023-08-31 14:16:42 +08:00
mcl_books Update russian translation 2023-08-31 14:16:42 +08:00
mcl_bows Update ignition, smothering, and campfire inventory drops 2023-09-04 22:05:38 +00:00
mcl_brewing Update russian translation 2023-08-31 14:16:42 +08:00
mcl_buckets Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914) 2023-09-29 18:47:07 +00:00
mcl_cake Update russian translation 2023-08-31 14:16:42 +08:00
mcl_campfires Update Credits. 2023-09-26 18:59:51 +00:00
mcl_cartography_table Update russian translation 2023-08-31 14:16:42 +08:00
mcl_cauldrons Update russian translation 2023-08-31 14:16:42 +08:00
mcl_cherry_blossom Update russian translation 2023-08-31 14:16:42 +08:00
mcl_chests Update russian translation 2023-08-31 14:16:42 +08:00
mcl_clock Update russian translation 2023-08-31 14:16:42 +08:00
mcl_cocoas Update russian translation 2023-08-31 14:16:42 +08:00
mcl_colorblocks Update russian translation 2023-08-31 14:16:42 +08:00
mcl_compass Update Russian translation. Fix 1. 2023-09-02 15:51:49 +08:00
mcl_composters Update Russian translation. Fix 1. 2023-09-02 15:51:49 +08:00
mcl_copper Merge pull request 'Update Russian translation' (#3896) from Nanashi_Mumei/MineClone2:master into master 2023-09-02 08:25:43 +00:00
mcl_core Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914) 2023-09-29 18:47:07 +00:00
mcl_crafting_table Update russian translation 2023-08-31 14:16:42 +08:00
mcl_crimson Merge pull request 'Update Russian translation' (#3896) from Nanashi_Mumei/MineClone2:master into master 2023-09-02 08:25:43 +00:00
mcl_deepslate Update Russian translation. Fix 1. 2023-09-02 15:51:49 +08:00
mcl_doors Update russian translation 2023-08-31 14:16:42 +08:00
mcl_dye Update russian translation 2023-08-31 14:16:42 +08:00
mcl_enchanting Update russian translation 2023-08-31 14:16:42 +08:00
mcl_end Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914) 2023-09-29 18:47:07 +00:00
mcl_farming Update russian translation 2023-08-31 14:16:42 +08:00
mcl_fences Update russian translation 2023-08-31 14:16:42 +08:00
mcl_fire Update ignition, smothering, and campfire inventory drops 2023-09-04 22:05:38 +00:00
mcl_fireworks Update russian translation 2023-08-31 14:16:42 +08:00
mcl_fishing Made food entities local to evcery campfire, and made one food entity that works for all foods 2023-09-04 22:05:38 +00:00
mcl_fletching_table Update russian translation 2023-08-31 14:16:42 +08:00
mcl_flowerpots Update russian translation 2023-08-31 14:16:42 +08:00
mcl_flowers Update russian translation 2023-08-31 14:16:42 +08:00
mcl_furnaces Update russian translation 2023-08-31 14:16:42 +08:00
mcl_grindstone Update russian translation 2023-08-31 14:16:42 +08:00
mcl_hamburger Update russian translation 2023-08-31 14:16:42 +08:00
mcl_heads Update russian translation 2023-08-31 14:16:42 +08:00
mcl_honey Update russian translation 2023-08-31 14:16:42 +08:00
mcl_hoppers Update russian translation 2023-08-31 14:16:42 +08:00
mcl_itemframes Update russian translation 2023-08-31 14:16:42 +08:00
mcl_jukebox Update russian translation 2023-08-31 14:16:42 +08:00
mcl_lanterns Update russian translation 2023-08-31 14:16:42 +08:00
mcl_lectern Update russian translation 2023-08-31 14:16:42 +08:00
mcl_lightning_rods Update russian translation 2023-08-31 14:16:42 +08:00
mcl_loom Update russian translation 2023-08-31 14:16:42 +08:00
mcl_mangrove Update russian translation 2023-08-31 14:16:42 +08:00
mcl_maps Update russian translation 2023-08-31 14:16:42 +08:00
mcl_mobitems Made food entities local to evcery campfire, and made one food entity that works for all foods 2023-09-04 22:05:38 +00:00
mcl_mobspawners Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914) 2023-09-29 18:47:07 +00:00
mcl_monster_eggs Update Russian translation. Fix 1. 2023-09-02 15:51:49 +08:00
mcl_mud Update russian translation 2023-08-31 14:16:42 +08:00
mcl_mushrooms Update russian translation 2023-08-31 14:16:42 +08:00
mcl_nether Update russian translation 2023-08-31 14:16:42 +08:00
mcl_ocean Update russian translation 2023-08-31 14:16:42 +08:00
mcl_portals Update russian translation 2023-08-31 14:16:42 +08:00
mcl_potions Update campfire rightclick and smothering 2023-09-04 22:05:38 +00:00
mcl_raw_ores Update russian translation 2023-08-31 14:16:42 +08:00
mcl_sculk Update russian translation 2023-08-31 14:16:42 +08:00
mcl_shields Update russian translation 2023-08-31 14:16:42 +08:00
mcl_signs Update russian translation 2023-08-31 14:16:42 +08:00
mcl_smithing_table Update russian translation 2023-08-31 14:16:42 +08:00
mcl_smoker Update russian translation 2023-08-31 14:16:42 +08:00
mcl_sponges Update russian translation 2023-08-31 14:16:42 +08:00
mcl_spyglass Move textures all into one centralized directory. 2023-01-30 22:55:53 -05:00
mcl_stairs Update russian translation 2023-08-31 14:16:42 +08:00
mcl_starting_inventory Remove title 2023-03-21 22:20:26 +00:00
mcl_stonecutter Update russian translation 2023-08-31 14:16:42 +08:00
mcl_sus_stew Update russian translation 2023-08-31 14:16:42 +08:00
mcl_throwing Update russian translation 2023-08-31 14:16:42 +08:00
mcl_tnt Update russian translation 2023-08-31 14:16:42 +08:00
mcl_tools Update ignition, smothering, and campfire inventory drops 2023-09-04 22:05:38 +00:00
mcl_torches Update russian translation 2023-08-31 14:16:42 +08:00
mcl_totems Update russian translation 2023-08-31 14:16:42 +08:00
mcl_walls Update russian translation 2023-08-31 14:16:42 +08:00
mcl_wool Update russian translation 2023-08-31 14:16:42 +08:00
mclx_core Update russian translation 2023-08-31 14:16:42 +08:00
mclx_fences Update russian translation 2023-08-31 14:16:42 +08:00
mclx_stairs Update russian translation 2023-08-31 14:16:42 +08:00
REDSTONE Campfires are unaffected by pistons 2023-09-04 22:05:38 +00:00
screwdriver (french) translation enhancements (#3643) 2023-05-11 22:39:49 +00:00
xpanes Update russian translation 2023-08-31 14:16:42 +08:00
modpack.conf Add a couple of modpack.conf files 2019-01-07 00:52:05 +01:00