2020-07-12 17:34:25 +02:00
|
|
|
# ContentDB
|
2021-01-29 18:17:51 +01:00
|
|
|
# Copyright (C) 2018-21 rubenwardy
|
2018-05-17 16:18:20 +02:00
|
|
|
#
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
2021-01-30 17:59:42 +01:00
|
|
|
# it under the terms of the GNU Affero General Public License as published by
|
2018-05-17 16:18:20 +02:00
|
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
|
|
# (at your option) any later version.
|
|
|
|
#
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
2021-01-30 17:59:42 +01:00
|
|
|
# GNU Affero General Public License for more details.
|
2018-05-17 16:18:20 +02:00
|
|
|
#
|
2021-01-30 17:59:42 +01:00
|
|
|
# You should have received a copy of the GNU Affero General Public License
|
2018-05-17 16:18:20 +02:00
|
|
|
# along with this program. If not, see <https://www.gnu.org/licenses/>.
|
2021-02-03 00:58:59 +01:00
|
|
|
import json
|
2021-02-01 23:42:58 +01:00
|
|
|
import os, shutil, gitdb
|
|
|
|
from zipfile import ZipFile
|
2018-06-05 20:47:02 +02:00
|
|
|
from git import GitCommandError
|
2020-01-19 01:28:26 +01:00
|
|
|
from git_archive_all import GitArchiver
|
2020-12-15 20:05:29 +01:00
|
|
|
from kombu import uuid
|
|
|
|
|
2018-05-11 13:57:16 +02:00
|
|
|
from app.models import *
|
2018-05-14 02:20:02 +02:00
|
|
|
from app.tasks import celery, TaskError
|
2021-02-03 00:58:59 +01:00
|
|
|
from app.utils import randomString, post_bot_message, addSystemNotification, addSystemAuditLog, get_system_user
|
2021-02-01 23:42:58 +01:00
|
|
|
from app.utils.git import clone_repo, get_latest_tag, get_latest_commit, get_temp_dir
|
2020-01-19 02:22:33 +01:00
|
|
|
from .minetestcheck import build_tree, MinetestCheckError, ContentType
|
2021-02-03 00:58:59 +01:00
|
|
|
from ..logic.LogicError import LogicError
|
2021-02-28 03:36:31 +01:00
|
|
|
from ..logic.packages import do_edit_package, ALIASES
|
2022-01-26 03:51:40 +01:00
|
|
|
from ..utils.image import get_image_size
|
2018-05-12 19:50:09 +02:00
|
|
|
|
2020-08-18 17:12:27 +02:00
|
|
|
|
2018-06-05 23:34:57 +02:00
|
|
|
@celery.task()
|
|
|
|
def getMeta(urlstr, author):
|
2021-03-02 17:42:38 +01:00
|
|
|
with clone_repo(urlstr, recursive=True) as repo:
|
2020-12-03 22:07:42 +01:00
|
|
|
try:
|
|
|
|
tree = build_tree(repo.working_tree_dir, author=author, repo=urlstr)
|
|
|
|
except MinetestCheckError as err:
|
|
|
|
raise TaskError(str(err))
|
2020-01-19 02:22:33 +01:00
|
|
|
|
2021-02-28 03:36:31 +01:00
|
|
|
result = {"name": tree.name, "type": tree.type.name}
|
2018-05-27 23:03:54 +02:00
|
|
|
|
2020-12-03 22:07:42 +01:00
|
|
|
for key in ["title", "repo", "issueTracker", "forumId", "description", "short_description"]:
|
|
|
|
result[key] = tree.get(key)
|
2018-05-27 23:03:54 +02:00
|
|
|
|
2021-02-28 03:36:31 +01:00
|
|
|
result["forums"] = result.get("forumId")
|
|
|
|
|
|
|
|
readme_path = tree.getReadMePath()
|
|
|
|
if readme_path:
|
|
|
|
with open(readme_path, "r") as f:
|
|
|
|
result["long_description"] = f.read()
|
|
|
|
|
|
|
|
try:
|
|
|
|
with open(os.path.join(tree.baseDir, ".cdb.json"), "r") as f:
|
|
|
|
data = json.loads(f.read())
|
|
|
|
for key, value in data.items():
|
|
|
|
result[key] = value
|
|
|
|
except LogicError as e:
|
|
|
|
raise TaskError(e.message)
|
|
|
|
except IOError:
|
|
|
|
pass
|
|
|
|
|
|
|
|
for alias, to in ALIASES.items():
|
|
|
|
if alias in result:
|
|
|
|
result[to] = result[alias]
|
2018-05-12 18:28:04 +02:00
|
|
|
|
2020-12-03 22:07:42 +01:00
|
|
|
for key, value in result.items():
|
|
|
|
if isinstance(value, set):
|
|
|
|
result[key] = list(value)
|
2018-05-27 23:03:54 +02:00
|
|
|
|
2020-12-03 22:07:42 +01:00
|
|
|
return result
|
2018-05-11 16:04:17 +02:00
|
|
|
|
2018-05-15 20:35:59 +02:00
|
|
|
|
2021-07-20 00:49:29 +02:00
|
|
|
def postReleaseCheckUpdate(self, release: PackageRelease, path):
|
2020-08-18 17:12:27 +02:00
|
|
|
try:
|
2020-12-04 03:23:04 +01:00
|
|
|
tree = build_tree(path, expected_type=ContentType[release.package.type.name],
|
|
|
|
author=release.package.author.username, name=release.package.name)
|
2020-08-18 17:12:27 +02:00
|
|
|
|
2021-08-08 21:43:52 +02:00
|
|
|
if tree.name is not None and release.package.name != tree.name and tree.type == ContentType.MOD:
|
2021-07-25 01:09:19 +02:00
|
|
|
raise MinetestCheckError(f"Expected {tree.relative} to have technical name {release.package.name}, instead has name {tree.name}")
|
|
|
|
|
2020-08-18 17:12:27 +02:00
|
|
|
cache = {}
|
|
|
|
def getMetaPackages(names):
|
|
|
|
return [ MetaPackage.GetOrCreate(x, cache) for x in names ]
|
|
|
|
|
|
|
|
provides = tree.getModNames()
|
|
|
|
|
|
|
|
package = release.package
|
|
|
|
package.provides.clear()
|
|
|
|
package.provides.extend(getMetaPackages(tree.getModNames()))
|
|
|
|
|
|
|
|
# Delete all meta package dependencies
|
|
|
|
package.dependencies.filter(Dependency.meta_package != None).delete()
|
|
|
|
|
|
|
|
# Get raw dependencies
|
|
|
|
depends = tree.fold("meta", "depends")
|
|
|
|
optional_depends = tree.fold("meta", "optional_depends")
|
|
|
|
|
|
|
|
# Filter out provides
|
|
|
|
for mod in provides:
|
|
|
|
depends.discard(mod)
|
|
|
|
optional_depends.discard(mod)
|
|
|
|
|
2021-07-18 18:59:35 +02:00
|
|
|
# Raise error on unresolved game dependencies
|
|
|
|
if package.type == PackageType.GAME and len(depends) > 0:
|
|
|
|
deps = ", ".join(depends)
|
|
|
|
raise MinetestCheckError("Game has unresolved hard dependencies: " + deps)
|
|
|
|
|
2020-08-18 18:08:17 +02:00
|
|
|
# Add dependencies
|
2020-08-18 17:12:27 +02:00
|
|
|
for meta in getMetaPackages(depends):
|
|
|
|
db.session.add(Dependency(package, meta=meta, optional=False))
|
|
|
|
|
|
|
|
for meta in getMetaPackages(optional_depends):
|
|
|
|
db.session.add(Dependency(package, meta=meta, optional=True))
|
|
|
|
|
|
|
|
# Update min/max
|
|
|
|
if tree.meta.get("min_minetest_version"):
|
|
|
|
release.min_rel = MinetestRelease.get(tree.meta["min_minetest_version"], None)
|
|
|
|
|
|
|
|
if tree.meta.get("max_minetest_version"):
|
|
|
|
release.max_rel = MinetestRelease.get(tree.meta["max_minetest_version"], None)
|
|
|
|
|
2021-02-03 00:58:59 +01:00
|
|
|
try:
|
2021-07-22 15:04:08 +02:00
|
|
|
with open(os.path.join(tree.baseDir, ".cdb.json"), "r") as f:
|
|
|
|
data = json.loads(f.read())
|
2021-07-24 01:43:55 +02:00
|
|
|
do_edit_package(package.author, package, False, False, data, "Post release hook")
|
2021-02-03 00:58:59 +01:00
|
|
|
except LogicError as e:
|
|
|
|
raise TaskError(e.message)
|
2021-07-22 15:04:08 +02:00
|
|
|
except IOError:
|
|
|
|
pass
|
2021-02-03 00:58:59 +01:00
|
|
|
|
2020-08-18 17:12:27 +02:00
|
|
|
return tree
|
|
|
|
|
|
|
|
except MinetestCheckError as err:
|
2020-08-19 14:06:21 +02:00
|
|
|
db.session.rollback()
|
|
|
|
|
2021-07-20 00:49:29 +02:00
|
|
|
msg = f"{err}\n\nTask ID: {self.request.id}\n\nRelease: [View Release]({release.getEditURL()})"
|
|
|
|
post_bot_message(release.package, f"Release {release.title} validation failed", msg)
|
|
|
|
|
2020-08-18 17:12:27 +02:00
|
|
|
if "Fails validation" not in release.title:
|
|
|
|
release.title += " (Fails validation)"
|
|
|
|
|
|
|
|
release.task_id = self.request.id
|
|
|
|
release.approved = False
|
|
|
|
db.session.commit()
|
|
|
|
|
|
|
|
raise TaskError(str(err))
|
|
|
|
|
|
|
|
|
|
|
|
@celery.task(bind=True)
|
|
|
|
def checkZipRelease(self, id, path):
|
|
|
|
release = PackageRelease.query.get(id)
|
|
|
|
if release is None:
|
|
|
|
raise TaskError("No such release!")
|
|
|
|
elif release.package is None:
|
|
|
|
raise TaskError("No package attached to release")
|
|
|
|
|
2020-12-14 22:05:56 +01:00
|
|
|
with get_temp_dir() as temp:
|
2020-08-18 17:12:27 +02:00
|
|
|
with ZipFile(path, 'r') as zip_ref:
|
|
|
|
zip_ref.extractall(temp)
|
|
|
|
|
|
|
|
postReleaseCheckUpdate(self, release, temp)
|
2020-01-19 02:37:15 +01:00
|
|
|
|
|
|
|
release.task_id = None
|
|
|
|
release.approve(release.package.author)
|
|
|
|
db.session.commit()
|
|
|
|
|
2018-06-06 00:13:39 +02:00
|
|
|
|
2020-08-18 17:12:27 +02:00
|
|
|
@celery.task(bind=True)
|
|
|
|
def makeVCSRelease(self, id, branch):
|
2018-06-06 00:13:39 +02:00
|
|
|
release = PackageRelease.query.get(id)
|
|
|
|
if release is None:
|
|
|
|
raise TaskError("No such release!")
|
|
|
|
elif release.package is None:
|
|
|
|
raise TaskError("No package attached to release")
|
|
|
|
|
2021-03-02 17:42:38 +01:00
|
|
|
with clone_repo(release.package.repo, ref=branch, recursive=True) as repo:
|
2020-12-03 22:07:42 +01:00
|
|
|
postReleaseCheckUpdate(self, release, repo.working_tree_dir)
|
2020-01-19 02:22:33 +01:00
|
|
|
|
2020-01-19 01:28:26 +01:00
|
|
|
filename = randomString(10) + ".zip"
|
|
|
|
destPath = os.path.join(app.config["UPLOAD_DIR"], filename)
|
|
|
|
|
|
|
|
assert(not os.path.isfile(destPath))
|
2020-12-29 21:42:43 +01:00
|
|
|
archiver = GitArchiver(prefix=release.package.name, force_sub=True, main_repo_abspath=repo.working_tree_dir)
|
2020-01-19 01:28:26 +01:00
|
|
|
archiver.create(destPath)
|
|
|
|
assert(os.path.isfile(destPath))
|
|
|
|
|
|
|
|
release.url = "/uploads/" + filename
|
|
|
|
release.task_id = None
|
|
|
|
release.commit_hash = repo.head.object.hexsha
|
|
|
|
release.approve(release.package.author)
|
|
|
|
db.session.commit()
|
|
|
|
|
|
|
|
return release.url
|
2018-06-06 00:13:39 +02:00
|
|
|
|
2020-07-12 03:22:35 +02:00
|
|
|
|
2018-05-15 20:35:59 +02:00
|
|
|
@celery.task()
|
|
|
|
def importRepoScreenshot(id):
|
|
|
|
package = Package.query.get(id)
|
2020-09-16 18:51:03 +02:00
|
|
|
if package is None or package.state == PackageState.DELETED:
|
2018-05-15 20:35:59 +02:00
|
|
|
raise Exception("Unexpected none package")
|
|
|
|
|
2018-06-06 00:13:39 +02:00
|
|
|
try:
|
2020-12-14 22:05:56 +01:00
|
|
|
with clone_repo(package.repo) as repo:
|
2020-12-03 22:07:42 +01:00
|
|
|
for ext in ["png", "jpg", "jpeg"]:
|
|
|
|
sourcePath = repo.working_tree_dir + "/screenshot." + ext
|
|
|
|
if os.path.isfile(sourcePath):
|
|
|
|
filename = randomString(10) + "." + ext
|
|
|
|
destPath = os.path.join(app.config["UPLOAD_DIR"], filename)
|
|
|
|
shutil.copyfile(sourcePath, destPath)
|
|
|
|
|
|
|
|
ss = PackageScreenshot()
|
|
|
|
ss.approved = True
|
|
|
|
ss.package = package
|
|
|
|
ss.title = "screenshot.png"
|
|
|
|
ss.url = "/uploads/" + filename
|
2022-01-26 03:51:40 +01:00
|
|
|
ss.width, ss.height = get_image_size(destPath)
|
|
|
|
if ss.is_too_small():
|
|
|
|
return None
|
|
|
|
|
2020-12-03 22:07:42 +01:00
|
|
|
db.session.add(ss)
|
|
|
|
db.session.commit()
|
|
|
|
|
|
|
|
return "/uploads/" + filename
|
|
|
|
|
2018-06-06 00:13:39 +02:00
|
|
|
except TaskError as e:
|
|
|
|
# ignore download errors
|
|
|
|
print(e)
|
2020-12-03 22:07:42 +01:00
|
|
|
pass
|
2018-06-05 23:34:57 +02:00
|
|
|
|
|
|
|
print("screenshot.png does not exist")
|
2018-05-15 20:35:59 +02:00
|
|
|
return None
|
2020-07-14 01:28:56 +02:00
|
|
|
|
|
|
|
|
2021-01-29 23:20:44 +01:00
|
|
|
def check_update_config_impl(package):
|
|
|
|
config = package.update_config
|
|
|
|
|
|
|
|
if config.trigger == PackageUpdateTrigger.COMMIT:
|
|
|
|
tag = None
|
2021-02-01 23:42:58 +01:00
|
|
|
commit = get_latest_commit(package.repo, package.update_config.ref)
|
2021-01-29 23:20:44 +01:00
|
|
|
elif config.trigger == PackageUpdateTrigger.TAG:
|
|
|
|
tag, commit = get_latest_tag(package.repo)
|
|
|
|
else:
|
|
|
|
raise TaskError("Unknown update trigger")
|
|
|
|
|
2021-02-01 12:34:55 +01:00
|
|
|
if commit is None:
|
|
|
|
return
|
|
|
|
|
2021-01-29 23:20:44 +01:00
|
|
|
if config.last_commit == commit:
|
|
|
|
if tag and config.last_tag != tag:
|
|
|
|
config.last_tag = tag
|
|
|
|
db.session.commit()
|
|
|
|
return
|
|
|
|
|
|
|
|
if not config.last_commit:
|
|
|
|
config.last_commit = commit
|
|
|
|
config.last_tag = tag
|
|
|
|
db.session.commit()
|
|
|
|
return
|
|
|
|
|
2021-01-31 00:51:09 +01:00
|
|
|
if package.releases.filter_by(commit_hash=commit).count() > 0:
|
2021-01-30 20:56:27 +01:00
|
|
|
return
|
|
|
|
|
2021-01-29 23:20:44 +01:00
|
|
|
if config.make_release:
|
|
|
|
rel = PackageRelease()
|
|
|
|
rel.package = package
|
2021-01-30 02:20:38 +01:00
|
|
|
rel.title = tag if tag else datetime.datetime.utcnow().strftime("%Y-%m-%d")
|
2021-01-29 23:20:44 +01:00
|
|
|
rel.url = ""
|
|
|
|
rel.task_id = uuid()
|
|
|
|
db.session.add(rel)
|
2021-01-30 18:10:38 +01:00
|
|
|
|
2021-01-30 19:25:00 +01:00
|
|
|
msg = "Created release {} (Git Update Detection)".format(rel.title)
|
2021-07-24 05:30:14 +02:00
|
|
|
addSystemAuditLog(AuditSeverity.NORMAL, msg, package.getURL("packages.view"), package)
|
2021-01-30 18:10:38 +01:00
|
|
|
|
2021-01-29 23:20:44 +01:00
|
|
|
db.session.commit()
|
|
|
|
|
|
|
|
makeVCSRelease.apply_async((rel.id, commit), task_id=rel.task_id)
|
|
|
|
|
|
|
|
elif config.outdated_at is None:
|
|
|
|
config.set_outdated()
|
|
|
|
|
|
|
|
if config.trigger == PackageUpdateTrigger.COMMIT:
|
|
|
|
msg_last = ""
|
|
|
|
if config.last_commit:
|
|
|
|
msg_last = " The last commit was {}".format(config.last_commit[0:5])
|
|
|
|
|
|
|
|
msg = "New commit {} found on the Git repo, is the package outdated?{}" \
|
|
|
|
.format(commit[0:5], msg_last)
|
|
|
|
else:
|
|
|
|
msg_last = ""
|
|
|
|
if config.last_tag:
|
|
|
|
msg_last = " The last tag was {}".format(config.last_tag)
|
|
|
|
|
|
|
|
msg = "New tag {} found on the Git repo.{}" \
|
|
|
|
.format(tag, msg_last)
|
|
|
|
|
|
|
|
for user in package.maintainers:
|
|
|
|
addSystemNotification(user, NotificationType.BOT,
|
|
|
|
msg, url_for("todo.view_user", username=user.username, _external=False), package)
|
|
|
|
|
|
|
|
config.last_commit = commit
|
|
|
|
config.last_tag = tag
|
|
|
|
db.session.commit()
|
|
|
|
|
|
|
|
|
2020-12-15 23:20:40 +01:00
|
|
|
@celery.task(bind=True)
|
|
|
|
def check_update_config(self, package_id):
|
2020-12-15 20:05:29 +01:00
|
|
|
package: Package = Package.query.get(package_id)
|
|
|
|
if package is None:
|
|
|
|
raise TaskError("No such package!")
|
|
|
|
elif package.update_config is None:
|
|
|
|
raise TaskError("No update config attached to package")
|
|
|
|
|
2020-12-15 23:20:40 +01:00
|
|
|
err = None
|
|
|
|
try:
|
2021-01-29 23:20:44 +01:00
|
|
|
check_update_config_impl(package)
|
2020-12-15 23:20:40 +01:00
|
|
|
except GitCommandError as e:
|
|
|
|
# This is needed to stop the backtrace being weird
|
|
|
|
err = e.stderr
|
|
|
|
except gitdb.exc.BadName as e:
|
|
|
|
err = "Unable to find the reference " + (package.update_config.ref or "?") + "\n" + e.stderr
|
2021-01-29 23:20:44 +01:00
|
|
|
except TaskError as e:
|
|
|
|
err = e.value
|
2020-12-15 23:20:40 +01:00
|
|
|
|
|
|
|
if err:
|
|
|
|
err = err.replace("stderr: ", "") \
|
|
|
|
.replace("Cloning into '/tmp/", "Cloning into '") \
|
|
|
|
.strip()
|
|
|
|
|
2020-12-15 23:40:49 +01:00
|
|
|
msg = "Error: {}.\n\nTask ID: {}\n\n[Change update configuration]({})" \
|
2021-07-24 05:30:14 +02:00
|
|
|
.format(err, self.request.id, package.getURL("packages.update_config"))
|
2020-12-15 23:40:49 +01:00
|
|
|
|
2020-12-15 23:51:57 +01:00
|
|
|
post_bot_message(package, "Failed to check git repository", msg)
|
2020-12-15 23:20:40 +01:00
|
|
|
|
|
|
|
db.session.commit()
|
|
|
|
return
|
|
|
|
|
2020-12-15 20:05:29 +01:00
|
|
|
|
|
|
|
@celery.task
|
|
|
|
def check_for_updates():
|
|
|
|
for update_config in PackageUpdateConfig.query.all():
|
|
|
|
update_config: PackageUpdateConfig
|
|
|
|
|
2020-12-15 23:41:38 +01:00
|
|
|
if not update_config.package.approved:
|
|
|
|
continue
|
|
|
|
|
2020-12-15 20:05:29 +01:00
|
|
|
if update_config.package.repo is None:
|
|
|
|
db.session.delete(update_config)
|
|
|
|
continue
|
|
|
|
|
|
|
|
check_update_config.delay(update_config.package_id)
|
|
|
|
|
|
|
|
db.session.commit()
|