Mirrorlandia_minetest/hopper
1
0
Fork 0
mirror of https://github.com/minetest-mods/hopper.git synced 2024-12-22 13:22:28 +01:00
Code Issues Projects Releases Wiki Activity

Refactor the hopper place function

Browse Source
This commit is contained in:
Ajrat Makhmutov 2024-05-30 00:48:26 +03:00 committed by SmallJoker
parent c691f370b4
commit d0c8e18c5a
1 changed files with 24 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
nodes/hoppers.lua
View File

@ -18,33 +18,39 @@ local function get_hopper_formspec(pos)
return formspec return formspec
end end
-- unfortunately param2 overrides are needed for side hoppers even in the non-single-craftable-item case
-- because they are literally *side* hoppers - their spouts point to the side rather than to the front, so
-- the default item_place_node orientation code will not orient them pointing toward the selected surface.
local hopper_on_place = function(itemstack, placer, pointed_thing, node_name) local hopper_on_place = function(itemstack, placer, pointed_thing, node_name)
local pos = pointed_thing.under
local pos2 = pointed_thing.above
local x = pos.x - pos2.x
local z = pos.z - pos2.z
local returned_stack, success local returned_stack, success
-- unfortunately param2 overrides are needed for side hoppers even in the non-single-craftable-item case
-- because they are literally *side* hoppers - their spouts point to the side rather than to the front, so if not (hopper.config.single_craftable_item or node_name == "hopper:hopper_side") then
-- the default item_place_node orientation code will not orient them pointing toward the selected surface. returned_stack, success = minetest.item_place_node(itemstack, placer, pointed_thing)
if x == -1 and (hopper.config.single_craftable_item or node_name == "hopper:hopper_side") then return returned_stack
returned_stack, success = minetest.item_place_node(ItemStack("hopper:hopper_side"), placer, pointed_thing, 0) end
elseif x == 1 and (hopper.config.single_craftable_item or node_name == "hopper:hopper_side") then
returned_stack, success = minetest.item_place_node(ItemStack("hopper:hopper_side"), placer, pointed_thing, 2) local pointed_pos = pointed_thing.under
elseif z == -1 and (hopper.config.single_craftable_item or node_name == "hopper:hopper_side") then local hopper_pos = pointed_thing.above
returned_stack, success = minetest.item_place_node(ItemStack("hopper:hopper_side"), placer, pointed_thing, 3)
elseif z == 1 and (hopper.config.single_craftable_item or node_name == "hopper:hopper_side") then local param2_by_offset = {
returned_stack, success = minetest.item_place_node(ItemStack("hopper:hopper_side"), placer, pointed_thing, 1) [vector.new(-1, 0, 0):to_string()] = 0,
[vector.new( 0, 0, 1):to_string()] = 1,
[vector.new( 1, 0, 0):to_string()] = 2,
[vector.new( 0, 0,-1):to_string()] = 3,
}
local param2 = param2_by_offset[(pointed_pos - hopper_pos):to_string()]
if param2 then
returned_stack, success = minetest.item_place_node(ItemStack("hopper:hopper_side"), placer, pointed_thing, param2)
else else
if hopper.config.single_craftable_item then if hopper.config.single_craftable_item then
node_name = "hopper:hopper" -- For cases where single_craftable_item was set on an existing world and there are still side hoppers in player inventories node_name = "hopper:hopper" -- For cases where single_craftable_item was set on an existing world and there are still side hoppers in player inventories
end end
returned_stack, success = minetest.item_place_node(ItemStack(node_name), placer, pointed_thing) returned_stack, success = minetest.item_place_node(ItemStack(node_name), placer, pointed_thing)
end end
if success then if success then
local meta = minetest.get_meta(pos2) local meta = minetest.get_meta(hopper_pos)
meta:set_string("placer", placer:get_player_name()) meta:set_string("placer", placer:get_player_name())
if not minetest.settings:get_bool("creative_mode") then if not minetest.settings:get_bool("creative_mode") then
itemstack:take_item() itemstack:take_item()