Commit Graph

89 Commits

Author SHA1 Message Date
HybridDog
8bebf6324e
Fix error when picking up a node with deprecated tile definition (#40)
If `image` instead of `tile` was used, the mod passed nil to minetest.inventorycube.
The color field of a tile is now also supported (the code is used only for the particle image calculation).
2022-10-06 18:36:50 +02:00
sfan5
d19d00d690
Mark pickup sound as ephemeral 2021-09-02 23:42:56 +02:00
HybridDog
1545f82cb7
Fix error for 'nil' player in minetest.handle_node_drops (#36) 2020-09-27 19:15:57 +02:00
David Leal
de38b20fa6
Add GitHub workflow and LuaCheck (#34)
* Add GitHub workflow and LuaCheck

* Fix LuaCheck warnings

* Improve README.md
2020-05-25 20:42:09 +02:00
HybridDog
f015cc1631 Ignore players which are outside the map 2020-05-17 21:12:57 +02:00
HybridDog
72f4225058 Support the moveresult parameter of on_step
The parameter is available in Minetest 5.3.0-dev.
thanks to sofar and VanessaE for the fix and report
2020-05-08 11:54:33 +02:00
Loïc Blot
7cb8086a25
Get player inventory before looping (#30)
This prevents the inventory check on each object in the loop and thus shortens the code.
Additionally, the inventory existence check is removed because get_inventory never returns nil for player objects.
2020-04-15 20:21:48 +02:00
HybridDog
8ef6ba3c0f Do not drop items when a Node Breaker digs a node 2019-09-05 12:00:13 +02:00
HybridDog
682a345495 Handle item drops more carefully
Do not ignore itemstrings which contain more than just the name; fixes missing clay drops
Support dropped items with toolwear and/or metadata
2019-07-01 15:46:06 +02:00
texmex
871be4048e Replace another deprecated function 2019-06-15 13:26:24 +02:00
Panquesito7
faf6d9236d Replace deprecated functions with newer ones 2019-06-14 17:47:21 -05:00
HybridDog
c943cf2042 Enable pickup_keyinvert by default 2019-06-04 16:44:46 +02:00
HybridDog
666ff41136 Allow disabling the pickup key
To support lecagy setting names, I added two functions. They use the old setting only if the new one is not set.
(I'm not sure if enable_item_pickup_key is a valid legacy setting…)

I did not test this commit thoroughly.
2019-05-29 20:44:59 +02:00
HybridDog
aef629f5b3 Fix crash due to a missing function
I accidentally wrote can_pickup instead of item_drop.can_pickup in a previous commit.
2019-05-26 14:13:54 +02:00
HybridDog
6637bbb813 Fix missing ore drops 2019-05-16 11:36:15 +02:00
texmex
0aa32c1fed Remove unneeded variable assertion, fix #20 2019-02-12 13:25:34 +01:00
tacotexmex
0cee07b9d5 Add setting for disabling manual item pickups by mouse 2019-02-12 01:12:59 +01:00
HybridDog
97158f7fac Ignore items where picking failed
tested with item_helpers
2019-02-05 19:29:40 +01:00
HybridDog
dd01ddf5ff Fix crash when trying to spawn an unknown item 2019-02-01 17:55:12 +01:00
HybridDog
d3687f027a Add three functions which can be used by other mods 2019-01-05 13:54:12 +01:00
HybridDog
62dbd6bc0d Fix a legacy setting support 2019-01-05 13:26:29 +01:00
HybridDog
02683056e5 Fix item magnet
There is no field named physical_state, so the item didn't lose the physical property, but it happily hopped towards me after I dropped it.
Disabling physical looked quite wrong, because the item flew through mountains. Instead, it gets zero acceleration now.
To avoid resetting the acceleration in the on_step function, it is overridden to disable acceleration and velocity changes during executing the original on_step.
Small code fix: Add underscores in set_velocity and set_acceleration
2018-10-03 17:58:58 +02:00
HybridDog
1d2e42eaab Fix crash when a node texture is a table 2018-08-12 10:33:55 +02:00
HybridDog
0112f1f9ec Tidy up pickup_particle code 2018-08-12 10:33:49 +02:00
tacotexmex
608b5dfe6e Simplify inventorycube code (again) 2018-06-23 10:09:02 +02:00
tacotexmex
1e5718cbac Fix settings bug 2018-06-23 10:02:04 +02:00
tacotexmex
c57d3c1514 Fix crash on no drops (@HybridDog) 2018-06-23 10:01:40 +02:00
tacotexmex
b6b1a8e95b Complete pickup particle feature 2018-06-18 10:18:06 +02:00
tacotexmex
08ba364510 Look for legacy setting names 2018-06-17 09:27:43 +02:00
Hybrid Dog
f1fcc478a1 Rename the key press test function 2017-09-16 13:18:20 +02:00
Hybrid Dog
3d88b7b5c6 Disable item pickup age if the player has to hold a key for taking items 2017-09-16 12:59:28 +02:00
tacotexmex
70068fd307 Typo 2017-09-15 18:40:11 +02:00
Hybrid Dog
d5b28e01b0 Fix missing division for dropped item velocity calculation 2017-09-15 10:27:28 +02:00
Hybrid Dog
609d441ef4 Always collect items one by one 2017-09-12 10:13:49 +02:00
Hybrid Dog
3a9a985cfc Revert "Adjust default key settings"
This reverts commit 3bc3a4bd25d445e0fbffe0158140a13346ced041.
2017-09-12 09:55:16 +02:00
Hybrid Dog
8543bad2aa Call on_punch to pick items (DS) 2017-09-11 14:44:31 +02:00
Hybrid Dog
f811009c80 Don't override handle_node_drops in creative mode 2017-09-11 14:35:55 +02:00
Hybrid Dog
ac2da1689e Update item dropping code 2017-09-11 14:22:17 +02:00
Hybrid Dog
35786b597c Update mod load logging
There's no official setting called log_mods
2017-09-11 14:09:24 +02:00
Hybrid Dog
1e2287a672 Do not pick items if the player has no interact 2017-09-11 14:08:01 +02:00
texmex
06c1212d5b Lower pickup sound gain 2017-09-11 13:09:11 +02:00
Hybrid Dog
253cc75c51 Higher update delay if no item was found
avoid loud pop noise (in zero velocity mode)
2017-09-08 21:26:08 +02:00
Hybrid Dog
88df92b125 Fix key triggering disabling 2017-09-08 20:57:05 +02:00
Hybrid Dog
6de1402ebc Remove damage setting test 2017-09-08 20:46:36 +02:00
Hybrid Dog
b06129c3a3 Fix redundant minetest.after invocations 2017-09-08 20:43:30 +02:00
Hybrid Dog
c86bc605bd Add item flight time setting, set it to 5 seconds by default 2017-09-08 20:42:28 +02:00
Hybrid Dog
c21158ffab Adjust default key settings 2017-09-08 20:38:20 +02:00
Hybrid Dog
9de8d39af6 Add keyinvert setting 2017-09-08 20:36:36 +02:00
Hybrid Dog
f2e3338265 Add magnet_radius setting 2017-09-08 20:32:48 +02:00
Hybrid Dog
31229760e8 Play the pickup sound positional to all players 2017-09-07 21:22:23 +02:00