Mirrorlandia_minetest/minetest
1
0
Fork 1
mirror of https://github.com/minetest/minetest.git synced 2024-11-30 03:23:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Error when string.split is given empty separator (#13132)

Browse Source
This commit is contained in:
Jude Melton-Houghton 2023-01-10 09:25:48 -05:00 committed by GitHub
parent a3177b89d8
commit ab1fe80150
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
builtin/common/misc_helpers.lua
View File

@ -170,6 +170,9 @@ end
-------------------------------------------------------------------------------- --------------------------------------------------------------------------------
function string.split(str, delim, include_empty, max_splits, sep_is_pattern) function string.split(str, delim, include_empty, max_splits, sep_is_pattern)
delim = delim or "," delim = delim or ","
if delim == "" then
error("string.split separator is empty", 2)
end
max_splits = max_splits or -2 max_splits = max_splits or -2
local items = {} local items = {}
local pos, len = 1, #str local pos, len = 1, #str

6
builtin/common/tests/misc_helpers_spec.lua
View File

@ -38,6 +38,12 @@ describe("string", function()
assert.same({ "one", "two" }, string.split("one,two", ",", false, -1, true)) assert.same({ "one", "two" }, string.split("one,two", ",", false, -1, true))
assert.same({ "one", "two", "three" }, string.split("one2two3three", "%d", false, -1, true)) assert.same({ "one", "two", "three" }, string.split("one2two3three", "%d", false, -1, true))
end) end)
it("rejects empty separator", function()
assert.has.errors(function()
string.split("", "")
end)
end)
end) end)
end) end)

2
doc/lua_api.txt
View File

@ -3623,7 +3623,7 @@ Helper functions
* `math.round(x)`: Returns `x` rounded to the nearest integer. * `math.round(x)`: Returns `x` rounded to the nearest integer.
* At a multiple of 0.5, rounds away from zero. * At a multiple of 0.5, rounds away from zero.
* `string.split(str, separator, include_empty, max_splits, sep_is_pattern)` * `string.split(str, separator, include_empty, max_splits, sep_is_pattern)`
* `separator`: string, default: `","` * `separator`: string, cannot be empty, default: `","`
* `include_empty`: boolean, default: `false` * `include_empty`: boolean, default: `false`
* `max_splits`: number, if it's negative, splits aren't limited, * `max_splits`: number, if it's negative, splits aren't limited,
default: `-1` default: `-1`