Some corp fixes (#236)

This commit is contained in:
Snarling 2022-11-29 08:24:04 -05:00 committed by GitHub
parent ce1879fb62
commit 14e50e5533
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions

@ -462,10 +462,9 @@ export const achievements: Record<string, Achievement> = {
Condition: (): boolean => {
if (Player.corporation === null) return false;
for (const d of Player.corporation.divisions) {
for (const o of Object.values(d.offices)) {
if (o === 0) continue;
if (o.totalEmployees >= 3000) return true;
}
let totalEmployees = 0;
for (const o of Object.values(d.offices)) if (o && o.totalEmployees) totalEmployees += o.totalEmployees;
if (totalEmployees >= 3000) return true;
}
return false;
},

@ -233,7 +233,7 @@ export function NetscriptCorporation(): InternalAPI<NSCorporation> {
const division = getDivision(divisionName);
if (!checkEnum(CityName, cityName)) throw new Error(`Invalid city name '${cityName}'`);
const warehouse = division.warehouses[cityName];
if (warehouse === 0) throw new Error(`${division.name} has not expanded to '${cityName}'`);
if (warehouse === 0) throw new Error(`${division.name} does not have a warehouse in '${cityName}'`);
return warehouse;
}
@ -848,6 +848,8 @@ export function NetscriptCorporation(): InternalAPI<NSCorporation> {
},
goPublic: (ctx) => (_numShares) => {
checkAccess(ctx);
const corporation = getCorporation();
if (corporation.public) throw helpers.makeRuntimeErrorMsg(ctx, "corporation is already public");
const numShares = helpers.number(ctx, "numShares", _numShares);
return goPublic(numShares);
},